From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v2 04/10] x86/cpuid: Handle leaf 0x4 in guest_cpuid() Date: Mon, 13 Mar 2017 06:03:40 -0600 Message-ID: <58C698AC0200007800142796@prv-mh.provo.novell.com> References: <1487588434-4359-5-git-send-email-andrew.cooper3@citrix.com> <1489163231-15769-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1489163231-15769-1-git-send-email-andrew.cooper3@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper Cc: Xen-devel List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDEwLjAzLjE3IGF0IDE3OjI3LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3Jv dGU6Cj4gTGVhZiAweDQgaXMgcmVzZXJ2ZWQgYnkgQU1ELiAgRm9yIEludGVsLCBpdCBpcyBhIG11 bHRpLWludm9jYXRpb24gbGVhZiB3aXRoCj4gZWN4IGVudW1lcmF0aW5nIGRpZmZlcmVudCBjYWNo ZSBkZXRhaWxzLgo+IAo+IEFkZCBhIG5ldyB1bmlvbiBmb3IgaXQgaW4gc3RydWN0IGNwdWlkX3Bv bGljeSwgY29sbGVjdCBpdCBmcm9tIGhhcmR3YXJlIGluCj4gY2FsY3VsYXRlX3Jhd19wb2xpY3ko KSwgYXVkaXQgaXQgaW4gcmVjYWxjdWxhdGVfY3B1aWRfcG9saWN5KCkgYW5kIHVwZGF0ZQo+IGd1 ZXN0X2NwdWlkKCkgYW5kIHVwZGF0ZV9kb21haW5fY3B1aWRfaW5mbygpIHRvIHByb3Blcmx5IGlu c2VydC9leHRyYWN0IAo+IGRhdGEuCj4gCj4gQSBsb3Qgb2YgdGhlIGRhdGEgaGVyZSB3aWxsIG5l ZWQgZnVydGhlciBhdWRpdGluZy9yZWZpbmVtZW50IHdoZW4gYmV0dGVyCj4gdG9wb2xvZ3kgc3Vw cG9ydCBpcyBpbnRyb2R1Y2VkLCBidXQgZm9yIG5vdywgdGhpcyBtYXRjaGVzIHRoZSBleGlzdGlu Zwo+IHRvb2xzdGFjayBiZWhhdmlvdXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3Bl ciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8 amJldWxpY2hAc3VzZS5jb20+CgpidXQgd2l0aCBhIGNvdXBsZSBvZiByZW1hcmtzOgoKPiBAQCAt MjQyLDYgKzI0MywyNSBAQCBzdGF0aWMgdm9pZCBfX2luaXQgY2FsY3VsYXRlX3Jhd19wb2xpY3ko dm9pZCkKPiAgICAgICAgICBjcHVpZF9sZWFmKGksICZwLT5iYXNpYy5yYXdbaV0pOwo+ICAgICAg fQo+ICAKPiArICAgIGlmICggcC0+YmFzaWMubWF4X2xlYWYgPj0gNCApCj4gKyAgICB7Cj4gKyAg ICAgICAgZm9yICggaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHAtPmNhY2hlLnJhdyk7ICsraSApCj4g KyAgICAgICAgewo+ICsgICAgICAgICAgICBjcHVpZF9jb3VudF9sZWFmKDQsIGksICZwLT5jYWNo ZS5yYXdbaV0pOwo+ICsKPiArICAgICAgICAgICAgaWYgKCBwLT5jYWNoZS5zdWJsZWFmW2ldLnR5 cGUgPT0gMCApCj4gKyAgICAgICAgICAgICAgICBicmVhazsKPiArICAgICAgICB9Cj4gKwo+ICsg ICAgICAgIC8qCj4gKyAgICAgICAgICogVGhlIGNob2ljZSBvZiBDUFVJRF9HVUVTVF9OUl9DQUNI RSBpcyBhcmJpdHJhcnkuICBJdCBpcyBleHBlY3RlZAo+ICsgICAgICAgICAqIHRoYXQgaXQgd2ls bCBldmVudHVhbGx5IG5lZWQgaW5jcmVhc2luZyBmb3IgZnV0dXJlIGhhcmR3YXJlLgo+ICsgICAg ICAgICAqLwo+ICsgICAgICAgIGlmICggaSA9PSBBUlJBWV9TSVpFKHAtPmNhY2hlLnJhdykgKQo+ ICsgICAgICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5JTkcKPiArICAgICAgICAgICAgICAgICAg ICJDUFVJRDogSW5zdWZmaWNpZW50IExlYWYgNCBzcGFjZSBmb3IgdGhpcyBoYXJkd2FyZVxuIik7 Cj4gKyAgICB9CgpBcyBleHByZXNzZWQgYmVmb3JlIChwZXJoYXBzIGluIHRoZSBjb250ZXh0IG9m IGFub3RoZXIgcGF0Y2gpLAp0aGUgd2FybmluZyBtYXkgYmUgbG9nZ2VkIHByZW1hdHVyZWx5LCB3 aGljaCBJJ2QgcHJlZmVyIHRvIGJlCmF2b2lkZWQuCgo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9kb21j dGwuYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9kb21jdGwuYwo+IEBAIC0xMDEsNiArMTAxLDEwIEBA IHN0YXRpYyBpbnQgdXBkYXRlX2RvbWFpbl9jcHVpZF9pbmZvKHN0cnVjdCBkb21haW4gKmQsCj4g ICAgICBzd2l0Y2ggKCBjdGwtPmlucHV0WzBdICkKPiAgICAgIHsKPiAgICAgIGNhc2UgMHgwMDAw MDAwMCAuLi4gQVJSQVlfU0laRShwLT5iYXNpYy5yYXcpIC0gMToKPiArICAgICAgICBpZiAoIGN0 bC0+aW5wdXRbMF0gPT0gNCAmJgo+ICsgICAgICAgICAgICAgY3RsLT5pbnB1dFsxXSA+PSBBUlJB WV9TSVpFKHAtPmNhY2hlLnJhdykgKQo+ICsgICAgICAgICAgICByZXR1cm4gMDsKPiArCj4gICAg ICAgICAgaWYgKCBjdGwtPmlucHV0WzBdID09IDcgJiYKPiAgICAgICAgICAgICAgIGN0bC0+aW5w dXRbMV0gPj0gQVJSQVlfU0laRShwLT5mZWF0LnJhdykgKQo+ICAgICAgICAgICAgICByZXR1cm4g MDsKPiBAQCAtMTI5LDcgKzEzMyw5IEBAIHN0YXRpYyBpbnQgdXBkYXRlX2RvbWFpbl9jcHVpZF9p bmZvKHN0cnVjdCBkb21haW4gKmQsCj4gICAgICBzd2l0Y2ggKCBjdGwtPmlucHV0WzBdICkKPiAg ICAgIHsKPiAgICAgIGNhc2UgMHgwMDAwMDAwMCAuLi4gQVJSQVlfU0laRShwLT5iYXNpYy5yYXcp IC0gMToKPiAtICAgICAgICBpZiAoIGN0bC0+aW5wdXRbMF0gPT0gNyApCj4gKyAgICAgICAgaWYg KCBjdGwtPmlucHV0WzBdID09IDQgKQo+ICsgICAgICAgICAgICBwLT5jYWNoZS5yYXdbY3RsLT5p bnB1dFsxXV0gPSBsZWFmOwo+ICsgICAgICAgIGVsc2UgaWYgKCBjdGwtPmlucHV0WzBdID09IDcg KQo+ICAgICAgICAgICAgICBwLT5mZWF0LnJhd1tjdGwtPmlucHV0WzFdXSA9IGxlYWY7Cj4gICAg ICAgICAgZWxzZSBpZiAoIGN0bC0+aW5wdXRbMF0gPT0gWFNUQVRFX0NQVUlEICkKPiAgICAgICAg ICAgICAgcC0+eHN0YXRlLnJhd1tjdGwtPmlucHV0WzFdXSA9IGxlYWY7CgpUaGUgY29udGV4dHMg b2YgdGhlc2UgdHdvIGh1bmtzIG1ha2UgaXQgcHJldHR5IGxpa2VseSB0aGF0IGlubmVyCnN3aXRj aCgpIHN0YXRlbWVudHMgd291bGQgaGVscCByZWFkYWJpbGl0eS4KCkphbgoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxp c3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZl bAo=