From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752215AbdCPL2e (ORCPT ); Thu, 16 Mar 2017 07:28:34 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49184 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752038AbdCPL2b (ORCPT ); Thu, 16 Mar 2017 07:28:31 -0400 Subject: Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' To: Masami Hiramatsu References: <20170314150658.7065-1-ravi.bangoria@linux.vnet.ibm.com> <20170316185140.a17b885479976d4be36349f4@kernel.org> Cc: mingo@redhat.com, acme@kernel.org, brendan.d.gregg@gmail.com, peterz@infradead.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jolsa@kernel.org, ak@linux.intel.com, treeze.taeung@gmail.com, mathieu.poirier@linaro.org, hekuang@huawei.com, sukadev@linux.vnet.ibm.com, ananth@in.ibm.com, naveen.n.rao@linux.vnet.ibm.com, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, hemant@linux.vnet.ibm.com, Ravi Bangoria From: Ravi Bangoria Date: Thu, 16 Mar 2017 16:57:52 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170316185140.a17b885479976d4be36349f4@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17031611-0044-0000-0000-000002D928EE X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006792; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00834613; UDB=6.00409891; IPR=6.00612269; BA=6.00005214; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014672; XFM=3.00000013; UTC=2017-03-16 11:28:05 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17031611-0045-0000-0000-000007072818 Message-Id: <58CA76B8.1030706@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-16_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703160093 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masami, On Thursday 16 March 2017 03:21 PM, Masami Hiramatsu wrote: > On Tue, 14 Mar 2017 20:36:51 +0530 > Ravi Bangoria wrote: > >> Changes in v5: >> - Patch 2/7 is new. New option introduced in this patch helps to pass >> custome data from builtin-*.c to libperf. >> >> - All direct callbacks from libelf to builtin-record.c is removed. >> Minor correction.. s/libelf/libperf/ >> - Merged 2nd and 4th patch of v4 into patch 2 of v5. s/patch 2 of v5/patch 3 of v5/ >> >> - Moved all functions from util/probe-file.c to util/probe-event.c >> which operates on perf_probe_event. >> >> - Made free_sdt_list() static as it's only used inside util/probe-event.c. >> >> - Couple of other changes as Masami has suggested in v4 review. > Hi Ravi, > Could you also describe which patches are updated? It seems 1/7 is not > modified, correct? Let me list a patch-wise brief changelog. patch 1/7:- Introduced dummy version of is_sdt_event() which always return false if !HAVE_LIBELF_SUPPORT. patch 2/7: - is new. A new option introduced in this patch helps to passcustom data from builtin-*.c to libperf. patch 3/7: - Removed direct calls from libperf to builtin-record.c which was used to prepare record.sdt_event_list. Instead pass list to libperf and let libperf manage it. - Introduce new wrapper func record__parse_events_option() that can differentiate between sdt and other events while parsing them in perf record. - Moved all functions from util/probe-file.c to util/probe-event.c which operates on perf_probe_event. - Merged 2nd and 4th patch of v4 into this patch. - Made free_sdt_list() static as it's only used inside util/probe-event.c. patch 4/7:- Removed direct calls from libperf to builtin-record.c which was used to prepare record.sdt_event_list. Instead pass list to libperf and let libperf manage it. - Moved all functions from util/probe-file.c to util/probe-event.c which operates on perf_probe_event. patch 5/7: No changes patch 6/7: No changes patch 7/7: No changes Let me know if you need more details. Thanks, Ravi