From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756894AbdCUIFA (ORCPT ); Tue, 21 Mar 2017 04:05:00 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:47775 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755241AbdCUIBt (ORCPT ); Tue, 21 Mar 2017 04:01:49 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: cl@rock-chips.com X-FST-TO: jic23@kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: cl@rock-chips.com X-UNIQUE-TAG: <96d9ebbb2363ad6d6b0ee9ca512cd095> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v1 6/7] arm64: dts: rockchip: add dts file for RK3328 evaluation board To: Heiko Stuebner References: <1489572237-6649-1-git-send-email-cl@rock-chips.com> <63969127-3fcd-658c-2986-8ded6d93c433@arm.com> <58CB4945.9020408@rock-chips.com> <4559383.EsY2O1vJ7P@phil> Cc: Andre Przywara , mark.rutland@arm.com, wsa@the-dreams.de, linux-iio@vger.kernel.org, catalin.marinas@arm.com, shawn.lin@rock-chips.com, will.deacon@arm.com, kever.yang@rock-chips.com, dianders@chromium.org, yamada.masahiro@socionext.com, tony.xie@rock-chips.com, linux-i2c@vger.kernel.org, pmeerw@pmeerw.net, lars@metafoo.de, zhengxing@rock-chips.com, khilman@baylibre.com, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, wxt@rock-chips.com, huangtao@rock-chips.com, devicetree@vger.kernel.org, zhangqing@rock-chips.com, paweljarosz3691@gmail.com, arnd@arndb.de, yhx@rock-chips.com, knaack.h@gmx.de, robh+dt@kernel.org, matthias.bgg@gmail.com, rocky.hao@rock-chips.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, david.wu@rock-chips.com, fabio.estevam@nxp.com, andy.yan@rock-chips.com, akpm@linux-foundation.org, shawnguo@kernel.org, afaerber@suse.de, jic23@kernel.org From: =?UTF-8?B?6ZmI5Lqu?= Message-ID: <58D0DD76.8090909@rock-chips.com> Date: Tue, 21 Mar 2017 15:59:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <4559383.EsY2O1vJ7P@phil> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko： Is there any advice about the big dtsi? I would like to send next version , thanks. 在 2017年03月17日 16:45, Heiko Stuebner 写道: > Am Freitag, 17. März 2017, 10:26:13 CET schrieb 陈亮: >> 在 2017年03月17日 00:18, Andre Przywara 写道: >>> Hi Chen, >>> >>> On 16/03/17 01:45, cl@rock-chips.com wrote: >>>> From: Chen Liang >>>> >>>> This patch add rk3328-evb.dts for RK3328 evaluation board. >>>> Tested on RK3328 evb. >>>> >>>> Signed-off-by: Chen Liang >>>> --- >>>> >>>> arch/arm64/boot/dts/rockchip/Makefile | 1 + >>>> arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 57 >>>> +++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+) >>>> create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-evb.dts >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile >>>> b/arch/arm64/boot/dts/rockchip/Makefile index 3a86289..853fc7d 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/Makefile >>>> +++ b/arch/arm64/boot/dts/rockchip/Makefile >>>> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-orion-r68-meta.dtb >>>> >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5-evb.dtb >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb.dtb >>>> >>>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-evb.dtb >>>> >>>> always := $(dtb-y) >>>> subdir-y := $(dts-dirs) >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts >>>> b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts new file mode 100644 >>>> index 0000000..cf27239 >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts >>>> @@ -0,0 +1,57 @@ >>>> +/* >>>> + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd >>>> + * >>>> + * This file is dual-licensed: you can use it either under the terms >>>> + * of the GPL or the X11 license, at your option. Note that this dual >>>> + * licensing only applies to this file, and not this project as a >>>> + * whole. >>>> + * >>>> + * a) This library is free software; you can redistribute it and/or >>>> + * modify it under the terms of the GNU General Public License as >>>> + * published by the Free Software Foundation; either version 2 of >>>> the >>>> + * License, or (at your option) any later version. >>>> + * >>>> + * This library is distributed in the hope that it will be useful, >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> + * GNU General Public License for more details. >>>> + * >>>> + * Or, alternatively, >>>> + * >>>> + * b) Permission is hereby granted, free of charge, to any person >>>> + * obtaining a copy of this software and associated documentation >>>> + * files (the "Software"), to deal in the Software without >>>> + * restriction, including without limitation the rights to use, >>>> + * copy, modify, merge, publish, distribute, sublicense, and/or >>>> + * sell copies of the Software, and to permit persons to whom the >>>> + * Software is furnished to do so, subject to the following >>>> + * conditions: >>>> + * >>>> + * The above copyright notice and this permission notice shall be >>>> + * included in all copies or substantial portions of the Software. >>>> + * >>>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >>>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >>>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >>>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >>>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >>>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >>>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >>>> + * OTHER DEALINGS IN THE SOFTWARE. >>>> + */ >>>> + >>>> +/dts-v1/; >>>> +#include "rk3328.dtsi" >>>> + >>>> +/ { >>>> + model = "Rockchip RK3328 EVB"; >>>> + compatible = "rockchip,rk3328-evb", "rockchip,rk3328"; >>>> + >>>> + chosen { >>>> + stdout-path = "serial2:1500000n8"; >>> Is that really 1.5MBit/s? >> Yes, the RK3328 EVB board use 1.5MBit/s baud rate. >> >>>> + }; >>>> +}; >>>> + >>>> +&uart2 { >>>> + status = "okay"; >>>> +}; >>> I don't have the board, but would expect to see more peripherals >>> mentioned in the .dtsi enabled here. >>> For sure the board has an (micro)SD card slot, possibly even Ethernet? >> The codes for other peripherals are not ready now for new kernel, so i >> push a base dtsi, and other configration will be pushed later if it is ok. > for me that approach is fine in general, but here, you could enable at least > the watchdog as well? > > But no need to resend just now, I still need to look at the big dtsi. > > > Heiko > From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?6ZmI5Lqu?= Subject: Re: [PATCH v1 6/7] arm64: dts: rockchip: add dts file for RK3328 evaluation board Date: Tue, 21 Mar 2017 15:59:50 +0800 Message-ID: <58D0DD76.8090909@rock-chips.com> References: <1489572237-6649-1-git-send-email-cl@rock-chips.com> <63969127-3fcd-658c-2986-8ded6d93c433@arm.com> <58CB4945.9020408@rock-chips.com> <4559383.EsY2O1vJ7P@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4559383.EsY2O1vJ7P@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Heiko Stuebner Cc: mark.rutland@arm.com, wsa@the-dreams.de, linux-iio@vger.kernel.org, catalin.marinas@arm.com, shawn.lin@rock-chips.com, will.deacon@arm.com, kever.yang@rock-chips.com, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, tony.xie@rock-chips.com, linux-i2c@vger.kernel.org, pmeerw@pmeerw.net, david.wu@rock-chips.com, lars@metafoo.de, zhengxing@rock-chips.com, khilman@baylibre.com, linux-rockchip@lists.infradead.org, yhx@rock-chips.com, jay.xu@rock-chips.com, wxt@rock-chips.com, huangtao@rock-chips.com, devicetree@vger.kernel.org, paweljarosz3691@gmail.com, arnd@arndb.de, Andre Przywara , zhangqing@rock-chips.com, robh+dt@kernel.org, matthias.bgg@gmail.com, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, dianders@chromium.org, knaack.h@gmx.de, fabio.estevam@nxp.com, andy.yan@rock-chips.com, rocky.hao@rock-chips.com, shawnguo@k List-Id: devicetree@vger.kernel.org SGkgSGVpa2/vvJoKCiAgICAgICAgIElzIHRoZXJlIGFueSBhZHZpY2UgYWJvdXQgdGhlIGJpZyBk dHNpPwogICAgICAgICBJIHdvdWxkIGxpa2UgdG8gc2VuZCBuZXh0IHZlcnNpb24gLCB0aGFua3Mu CgrlnKggMjAxN+W5tDAz5pyIMTfml6UgMTY6NDUsIEhlaWtvIFN0dWVibmVyIOWGmemBkzoKPiBB bSBGcmVpdGFnLCAxNy4gTcOkcnogMjAxNywgMTA6MjY6MTMgQ0VUIHNjaHJpZWIg6ZmI5LquOgo+ PiDlnKggMjAxN+W5tDAz5pyIMTfml6UgMDA6MTgsIEFuZHJlIFByenl3YXJhIOWGmemBkzoKPj4+ IEhpIENoZW4sCj4+Pgo+Pj4gT24gMTYvMDMvMTcgMDE6NDUsIGNsQHJvY2stY2hpcHMuY29tIHdy b3RlOgo+Pj4+IEZyb206IENoZW4gTGlhbmcgPGNsQHJvY2stY2hpcHMuY29tPgo+Pj4+Cj4+Pj4g VGhpcyBwYXRjaCBhZGQgcmszMzI4LWV2Yi5kdHMgZm9yIFJLMzMyOCBldmFsdWF0aW9uIGJvYXJk Lgo+Pj4+IFRlc3RlZCBvbiBSSzMzMjggZXZiLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogQ2hl biBMaWFuZyA8Y2xAcm9jay1jaGlwcy5jb20+Cj4+Pj4gLS0tCj4+Pj4KPj4+PiAgICBhcmNoL2Fy bTY0L2Jvb3QvZHRzL3JvY2tjaGlwL01ha2VmaWxlICAgICAgIHwgIDEgKwo+Pj4+ICAgIGFyY2gv YXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzI4LWV2Yi5kdHMgfCA1Nwo+Pj4+ICAgICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrIDIgZmlsZXMgY2hhbmdlZCwgNTggaW5zZXJ0aW9ucygr KQo+Pj4+ICAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlw L3JrMzMyOC1ldmIuZHRzCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0 cy9yb2NrY2hpcC9NYWtlZmlsZQo+Pj4+IGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9N YWtlZmlsZSBpbmRleCAzYTg2Mjg5Li44NTNmYzdkIDEwMDY0NAo+Pj4+IC0tLSBhL2FyY2gvYXJt NjQvYm9vdC9kdHMvcm9ja2NoaXAvTWFrZWZpbGUKPj4+PiArKysgYi9hcmNoL2FybTY0L2Jvb3Qv ZHRzL3JvY2tjaGlwL01ha2VmaWxlCj4+Pj4gQEAgLTQsNiArNCw3IEBAIGR0Yi0kKENPTkZJR19B UkNIX1JPQ0tDSElQKSArPSByazMzNjgtb3Jpb24tcjY4LW1ldGEuZHRiCj4+Pj4KPj4+PiAgICBk dGItJChDT05GSUdfQVJDSF9ST0NLQ0hJUCkgKz0gcmszMzY4LXB4NS1ldmIuZHRiCj4+Pj4gICAg ZHRiLSQoQ09ORklHX0FSQ0hfUk9DS0NISVApICs9IHJrMzM2OC1yODguZHRiCj4+Pj4gICAgZHRi LSQoQ09ORklHX0FSQ0hfUk9DS0NISVApICs9IHJrMzM5OS1ldmIuZHRiCj4+Pj4KPj4+PiArZHRi LSQoQ09ORklHX0FSQ0hfUk9DS0NISVApICs9IHJrMzMyOC1ldmIuZHRiCj4+Pj4KPj4+PiAgICBh bHdheXMJCTo9ICQoZHRiLXkpCj4+Pj4gICAgc3ViZGlyLXkJOj0gJChkdHMtZGlycykKPj4+Pgo+ Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzMyOC1ldmIu ZHRzCj4+Pj4gYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzMyOC1ldmIuZHRzIG5l dyBmaWxlIG1vZGUgMTAwNjQ0Cj4+Pj4gaW5kZXggMDAwMDAwMC4uY2YyNzIzOQo+Pj4+IC0tLSAv ZGV2L251bGwKPj4+PiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzMyOC1l dmIuZHRzCj4+Pj4gQEAgLTAsMCArMSw1NyBAQAo+Pj4+ICsvKgo+Pj4+ICsgKiBDb3B5cmlnaHQg KGMpIDIwMTcgRnV6aG91IFJvY2tjaGlwIEVsZWN0cm9uaWNzIENvLiwgTHRkCj4+Pj4gKyAqCj4+ Pj4gKyAqIFRoaXMgZmlsZSBpcyBkdWFsLWxpY2Vuc2VkOiB5b3UgY2FuIHVzZSBpdCBlaXRoZXIg dW5kZXIgdGhlIHRlcm1zCj4+Pj4gKyAqIG9mIHRoZSBHUEwgb3IgdGhlIFgxMSBsaWNlbnNlLCBh dCB5b3VyIG9wdGlvbi4gTm90ZSB0aGF0IHRoaXMgZHVhbAo+Pj4+ICsgKiBsaWNlbnNpbmcgb25s eSBhcHBsaWVzIHRvIHRoaXMgZmlsZSwgYW5kIG5vdCB0aGlzIHByb2plY3QgYXMgYQo+Pj4+ICsg KiB3aG9sZS4KPj4+PiArICoKPj4+PiArICogIGEpIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3 YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKPj4+PiArICogICAgIG1vZGlmeSBp dCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzCj4+ Pj4gKyAqICAgICBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0 aGVyIHZlcnNpb24gMiBvZgo+Pj4+IHRoZQo+Pj4+ICsgKiAgICAgTGljZW5zZSwgb3IgKGF0IHlv dXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KPj4+PiArICoKPj4+PiArICogICAgIFRoaXMg bGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVs LAo+Pj4+ICsgKiAgICAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhl IGltcGxpZWQgd2FycmFudHkgb2YKPj4+PiArICogICAgIE1FUkNIQU5UQUJJTElUWSBvciBGSVRO RVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKPj4+PiArICogICAgIEdOVSBH ZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCj4+Pj4gKyAqCj4+Pj4gKyAq IE9yLCBhbHRlcm5hdGl2ZWx5LAo+Pj4+ICsgKgo+Pj4+ICsgKiAgYikgUGVybWlzc2lvbiBpcyBo ZXJlYnkgZ3JhbnRlZCwgZnJlZSBvZiBjaGFyZ2UsIHRvIGFueSBwZXJzb24KPj4+PiArICogICAg IG9idGFpbmluZyBhIGNvcHkgb2YgdGhpcyBzb2Z0d2FyZSBhbmQgYXNzb2NpYXRlZCBkb2N1bWVu dGF0aW9uCj4+Pj4gKyAqICAgICBmaWxlcyAodGhlICJTb2Z0d2FyZSIpLCB0byBkZWFsIGluIHRo ZSBTb2Z0d2FyZSB3aXRob3V0Cj4+Pj4gKyAqICAgICByZXN0cmljdGlvbiwgaW5jbHVkaW5nIHdp dGhvdXQgbGltaXRhdGlvbiB0aGUgcmlnaHRzIHRvIHVzZSwKPj4+PiArICogICAgIGNvcHksIG1v ZGlmeSwgbWVyZ2UsIHB1Ymxpc2gsIGRpc3RyaWJ1dGUsIHN1YmxpY2Vuc2UsIGFuZC9vcgo+Pj4+ ICsgKiAgICAgc2VsbCBjb3BpZXMgb2YgdGhlIFNvZnR3YXJlLCBhbmQgdG8gcGVybWl0IHBlcnNv bnMgdG8gd2hvbSB0aGUKPj4+PiArICogICAgIFNvZnR3YXJlIGlzIGZ1cm5pc2hlZCB0byBkbyBz bywgc3ViamVjdCB0byB0aGUgZm9sbG93aW5nCj4+Pj4gKyAqICAgICBjb25kaXRpb25zOgo+Pj4+ ICsgKgo+Pj4+ICsgKiAgICAgVGhlIGFib3ZlIGNvcHlyaWdodCBub3RpY2UgYW5kIHRoaXMgcGVy bWlzc2lvbiBub3RpY2Ugc2hhbGwgYmUKPj4+PiArICogICAgIGluY2x1ZGVkIGluIGFsbCBjb3Bp ZXMgb3Igc3Vic3RhbnRpYWwgcG9ydGlvbnMgb2YgdGhlIFNvZnR3YXJlLgo+Pj4+ICsgKgo+Pj4+ ICsgKiAgICAgVEhFIFNPRlRXQVJFIElTIFBST1ZJREVEICJBUyBJUyIsIFdJVEhPVVQgV0FSUkFO VFkgT0YgQU5ZIEtJTkQsCj4+Pj4gKyAqICAgICBFWFBSRVNTIE9SIElNUExJRUQsIElOQ0xVRElO RyBCVVQgTk9UIExJTUlURUQgVE8gVEhFIFdBUlJBTlRJRVMKPj4+PiArICogICAgIE9GIE1FUkNI QU5UQUJJTElUWSwgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQU5ECj4+Pj4gKyAq ICAgICBOT05JTkZSSU5HRU1FTlQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBBVVRIT1JTIE9SIENP UFlSSUdIVAo+Pj4+ICsgKiAgICAgSE9MREVSUyBCRSBMSUFCTEUgRk9SIEFOWSBDTEFJTSwgREFN QUdFUyBPUiBPVEhFUiBMSUFCSUxJVFksCj4+Pj4gKyAqICAgICBXSEVUSEVSIElOIEFOIEFDVElP TiBPRiBDT05UUkFDVCwgVE9SVCBPUiBPVEhFUldJU0UsIEFSSVNJTkcKPj4+PiArICogICAgIEZS T00sIE9VVCBPRiBPUiBJTiBDT05ORUNUSU9OIFdJVEggVEhFIFNPRlRXQVJFIE9SIFRIRSBVU0Ug T1IKPj4+PiArICogICAgIE9USEVSIERFQUxJTkdTIElOIFRIRSBTT0ZUV0FSRS4KPj4+PiArICov Cj4+Pj4gKwo+Pj4+ICsvZHRzLXYxLzsKPj4+PiArI2luY2x1ZGUgInJrMzMyOC5kdHNpIgo+Pj4+ ICsKPj4+PiArLyB7Cj4+Pj4gKwltb2RlbCA9ICJSb2NrY2hpcCBSSzMzMjggRVZCIjsKPj4+PiAr CWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzI4LWV2YiIsICJyb2NrY2hpcCxyazMzMjgiOwo+ Pj4+ICsKPj4+PiArCWNob3NlbiB7Cj4+Pj4gKwkJc3Rkb3V0LXBhdGggPSAic2VyaWFsMjoxNTAw MDAwbjgiOwo+Pj4gSXMgdGhhdCByZWFsbHkgMS41TUJpdC9zPwo+PiBZZXMsIHRoZSBSSzMzMjgg RVZCIGJvYXJkIHVzZSAxLjVNQml0L3MgYmF1ZCByYXRlLgo+Pgo+Pj4+ICsJfTsKPj4+PiArfTsK Pj4+PiArCj4+Pj4gKyZ1YXJ0MiB7Cj4+Pj4gKwlzdGF0dXMgPSAib2theSI7Cj4+Pj4gK307Cj4+ PiBJIGRvbid0IGhhdmUgdGhlIGJvYXJkLCBidXQgd291bGQgZXhwZWN0IHRvIHNlZSBtb3JlIHBl cmlwaGVyYWxzCj4+PiBtZW50aW9uZWQgaW4gdGhlIC5kdHNpIGVuYWJsZWQgaGVyZS4KPj4+IEZv ciBzdXJlIHRoZSBib2FyZCBoYXMgYW4gKG1pY3JvKVNEIGNhcmQgc2xvdCwgcG9zc2libHkgZXZl biBFdGhlcm5ldD8KPj4gVGhlIGNvZGVzIGZvciBvdGhlciBwZXJpcGhlcmFscyBhcmUgbm90IHJl YWR5IG5vdyBmb3IgbmV3IGtlcm5lbCwgc28gaQo+PiBwdXNoIGEgYmFzZSBkdHNpLCBhbmQgb3Ro ZXIgY29uZmlncmF0aW9uIHdpbGwgYmUgcHVzaGVkIGxhdGVyIGlmIGl0IGlzIG9rLgo+IGZvciBt ZSB0aGF0IGFwcHJvYWNoIGlzIGZpbmUgaW4gZ2VuZXJhbCwgYnV0IGhlcmUsIHlvdSBjb3VsZCBl bmFibGUgYXQgbGVhc3QKPiB0aGUgd2F0Y2hkb2cgYXMgd2VsbD8KPgo+IEJ1dCBubyBuZWVkIHRv IHJlc2VuZCBqdXN0IG5vdywgSSBzdGlsbCBuZWVkIHRvIGxvb2sgYXQgdGhlIGJpZyBkdHNpLgo+ Cj4KPiBIZWlrbwo+CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: cl@rock-chips.com (=?UTF-8?B?6ZmI5Lqu?=) Date: Tue, 21 Mar 2017 15:59:50 +0800 Subject: [PATCH v1 6/7] arm64: dts: rockchip: add dts file for RK3328 evaluation board In-Reply-To: <4559383.EsY2O1vJ7P@phil> References: <1489572237-6649-1-git-send-email-cl@rock-chips.com> <63969127-3fcd-658c-2986-8ded6d93c433@arm.com> <58CB4945.9020408@rock-chips.com> <4559383.EsY2O1vJ7P@phil> Message-ID: <58D0DD76.8090909@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Heiko? Is there any advice about the big dtsi? I would like to send next version , thanks. ? 2017?03?17? 16:45, Heiko Stuebner ??: > Am Freitag, 17. M?rz 2017, 10:26:13 CET schrieb ??: >> ? 2017?03?17? 00:18, Andre Przywara ??: >>> Hi Chen, >>> >>> On 16/03/17 01:45, cl at rock-chips.com wrote: >>>> From: Chen Liang >>>> >>>> This patch add rk3328-evb.dts for RK3328 evaluation board. >>>> Tested on RK3328 evb. >>>> >>>> Signed-off-by: Chen Liang >>>> --- >>>> >>>> arch/arm64/boot/dts/rockchip/Makefile | 1 + >>>> arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 57 >>>> +++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+) >>>> create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-evb.dts >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile >>>> b/arch/arm64/boot/dts/rockchip/Makefile index 3a86289..853fc7d 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/Makefile >>>> +++ b/arch/arm64/boot/dts/rockchip/Makefile >>>> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-orion-r68-meta.dtb >>>> >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5-evb.dtb >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb.dtb >>>> >>>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-evb.dtb >>>> >>>> always := $(dtb-y) >>>> subdir-y := $(dts-dirs) >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts >>>> b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts new file mode 100644 >>>> index 0000000..cf27239 >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts >>>> @@ -0,0 +1,57 @@ >>>> +/* >>>> + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd >>>> + * >>>> + * This file is dual-licensed: you can use it either under the terms >>>> + * of the GPL or the X11 license, at your option. Note that this dual >>>> + * licensing only applies to this file, and not this project as a >>>> + * whole. >>>> + * >>>> + * a) This library is free software; you can redistribute it and/or >>>> + * modify it under the terms of the GNU General Public License as >>>> + * published by the Free Software Foundation; either version 2 of >>>> the >>>> + * License, or (at your option) any later version. >>>> + * >>>> + * This library is distributed in the hope that it will be useful, >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> + * GNU General Public License for more details. >>>> + * >>>> + * Or, alternatively, >>>> + * >>>> + * b) Permission is hereby granted, free of charge, to any person >>>> + * obtaining a copy of this software and associated documentation >>>> + * files (the "Software"), to deal in the Software without >>>> + * restriction, including without limitation the rights to use, >>>> + * copy, modify, merge, publish, distribute, sublicense, and/or >>>> + * sell copies of the Software, and to permit persons to whom the >>>> + * Software is furnished to do so, subject to the following >>>> + * conditions: >>>> + * >>>> + * The above copyright notice and this permission notice shall be >>>> + * included in all copies or substantial portions of the Software. >>>> + * >>>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >>>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >>>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >>>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >>>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >>>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >>>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >>>> + * OTHER DEALINGS IN THE SOFTWARE. >>>> + */ >>>> + >>>> +/dts-v1/; >>>> +#include "rk3328.dtsi" >>>> + >>>> +/ { >>>> + model = "Rockchip RK3328 EVB"; >>>> + compatible = "rockchip,rk3328-evb", "rockchip,rk3328"; >>>> + >>>> + chosen { >>>> + stdout-path = "serial2:1500000n8"; >>> Is that really 1.5MBit/s? >> Yes, the RK3328 EVB board use 1.5MBit/s baud rate. >> >>>> + }; >>>> +}; >>>> + >>>> +&uart2 { >>>> + status = "okay"; >>>> +}; >>> I don't have the board, but would expect to see more peripherals >>> mentioned in the .dtsi enabled here. >>> For sure the board has an (micro)SD card slot, possibly even Ethernet? >> The codes for other peripherals are not ready now for new kernel, so i >> push a base dtsi, and other configration will be pushed later if it is ok. > for me that approach is fine in general, but here, you could enable at least > the watchdog as well? > > But no need to resend just now, I still need to look at the big dtsi. > > > Heiko >