All of lore.kernel.org
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 0/4] meson_uart: add support for core clock handling
Date: Thu, 23 Mar 2017 08:43:40 +0100	[thread overview]
Message-ID: <58D37CAC.7030902@baylibre.com> (raw)
In-Reply-To: <839065e6-8329-068f-8da3-7d0163ac37e0@gmail.com>

Le 22/03/2017 21:45, Helmut Klein a ?crit :
> to be able to use the none AO uarts of the s905 SoCs, the core clock has to be enabled.
> (see chapter 22.3 of the public s905 data sheet)
> at least the u-boot of my s905 based media player (netxeon minimx) doesn't do this.
> so the driver has to do this.
> 
> this patch set does:
> - exposes the CLKID_UART0 to the dtb
> - adds documentation for the dt-bindings of meson_uart
> - adds the core clock handling to the driver
> 
> none of the available s905 dts use uart_A actively. so there is no patch for any of the existing dts files.

Hi Heiner,

Thanks for these patches, I'm surprise neither the gate clock handling or the dt-bindings were pushed with the serial driver.

Nevertheless, please use the git "format-patch" tool to generate the patchset.

My steps to generate a patchset are :

- Order all the commits in the order and form you want to have them sent
- Use "git rebase -i" to reword (change commit message), change order or edit each patches
- When you have a clean set, generate the email files with :
# git format-patch -3 -s --cover-letter -o my-patchset-directory/
The "-3" gives the number of patches to extract
The "-s" will add the Signed-off-by tag
The "--cover-letter" will generate the 0000-cover-letter to fill up
- Then fill the cover letter and check all your patches with scripts/checkpatch.pl
- When it's clean, get the maintainers emails with scripts/get_maintainer.pl
- Then send them with the "git send-email" tool :
# git send-email my-patchset-directory/*

If you have more questions, please ask ! It's not easy to understand, but it will save you a lot of time !

Neil

      parent reply	other threads:[~2017-03-23  7:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 20:45 [PATCH 0/4] meson_uart: add support for core clock handling Helmut Klein
2017-03-22 20:54 ` Helmut Klein
2017-03-23  7:43 ` Neil Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58D37CAC.7030902@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.