From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 2/3] drm/amdgpu: Fix Vega10 VM initialization Date: Wed, 29 Mar 2017 10:56:17 +0800 Message-ID: <58DB2251.4060705@amd.com> References: <1490749231-16157-1-git-send-email-Felix.Kuehling@amd.com> <1490749231-16157-3-git-send-email-Felix.Kuehling@amd.com> <58DB1061.7000403@amd.com> <0091f779-a045-7009-3746-6957ccacd62f@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <0091f779-a045-7009-3746-6957ccacd62f-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Felix Kuehling , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Christian.Koenig-5C7GfCeVMHo@public.gmane.org, David1.Zhou-5C7GfCeVMHo@public.gmane.org Cc: Alexander.Deucher-5C7GfCeVMHo@public.gmane.org, Kent.Russell-5C7GfCeVMHo@public.gmane.org T24gMDMvMjkvMjAxNyAwOTo0OCBBTSwgRmVsaXggS3VlaGxpbmcgd3JvdGU6Cj4gT24gMTctMDMt MjggMDk6MzkgUE0sIFpoYW5nLCBKZXJyeSAoSnVud2VpKSB3cm90ZToKPj4gT24gMDMvMjkvMjAx NyAwOTowMCBBTSwgRmVsaXggS3VlaGxpbmcgd3JvdGU6Cj4+PiBhZGV2LT5mYW1pbHkgaXMgbm90 IGluaXRpYWxpemVkIHlldCB3aGVuIGFtZGdwdV9nZXRfYmxvY2tfc2l6ZSBpcwo+Pj4gY2FsbGVk LiBVc2UgYWRldi0+YXNpY190eXBlIGluc3RlYWQuCj4+Pgo+Pj4gTWluaW11bSBWTSBzaXplIGlz IDUxMkdCLCBub3QgMjU2R0IsIGZvciBhIHNpbmdsZSBwYWdlIHRhYmxlIGVudHJ5Cj4+PiBpbiB0 aGUgcm9vdCBwYWdlIHRhYmxlLgo+Pj4KPj4+IGdtY192OV8wX3ZtX2luaXQgaXMgY2FsbGVkIGFm dGVyIGFkZXYtPnZtX21hbmFnZXIubWF4X3BmbiBpcwo+Pj4gaW5pdGlhbGl6ZWQuIE1vdmUgdGhl IG1pbmltdW0gVk0tc2l6ZSBlbmZvcmNlbWVudCBhaGVhZCBvZiBtYXhfcGZuCj4+PiBpbml0aWFs aXp0aW9uLiBDYXN0IHRvIDY0LWJpdCBiZWZvcmUgdGhlIGxlZnQtc2hpZnQuCj4+Pgo+Pj4gU2ln bmVkLW9mZi1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhsaW5nQGFtZC5jb20+Cj4+IFJl dmlld2VkLWJ5OiBKdW53ZWkgWmhhbmcgPEplcnJ5LlpoYW5nQGFtZC5jb20+Cj4+Cj4+IEp1c3Qg bm90ZToKPj4gRm9yIG5vdywgaXQncyBPSyB0byBzZXQgdGhlIG1pbmltdW0gdm0gc2l6ZSAyNTZH LAo+PiBJbiB0aGlzIGNhc2UsIHRoZXJlIGlzIG5vIFBEIGJpdCBhbnl3YXkuCj4KPiBXaXRoIFZN IHNpemUgb2YgMjU2R0IsIHRoZSBhbWRncHVfdm1fYm9fc2l6ZShhZGV2LCAwKSBjYWxjdWxhdGVz IDAsIGFuZAo+IHRoZSBwYWdlIGRpcmVjdG9yeSBhbGxvY2F0aW9uIHdpdGggYW1kZ3B1X2JvX2Ny ZWF0ZSBmYWlscyBpbiBhbWRncHVfdm1faW5pdC4KPgo+IEluIG90aGVyIHdvcmRzLCBhbWRncHVf dm1fbnVtX2VudHJpZXMoYWRldiwgMCkgbmVlZHMgdG8gcmV0dXJuIGF0IGxlYXN0Cj4gMS4gVGhh dCBtZWFucyB2bV9zaXplIG5lZWRzIHRvIGJlIGF0IGxlYXN0IDUxMkdCLgoKU29ycnkgZm9yIHRo ZSB0eXBvLCBJJ2QgbGlrZSB0byBzYXkgNTEyR0IuCk1heWJlIGl0IHdpbGwgYmVjb21lIDI1NlRC LCBkZXBlbmRpbmcgb24gdGhlIGRpc2N1c3Npb24gaW4gdGhlIGZ1dHVyZS4KCkplcnJ5Cgo+Cj4g UmVnYXJkcywKPiAgICBGZWxpeAo+Cj4+Cj4+IENocmlzdGlhbiBhbHNvIG1lbnRpb25lZCB0aGF0 IFBEIHNob3VsZCBiZSA0ayBzaXplLCB0aGVuIDI1NlQgd2FzCj4+IHJlcXVpcmVkLgo+PiBXaGVu IHJlYWNoIGFuIGFncmVlbWVudCwgd2UgbWF5IHVwZGF0ZSB0aGVtIGFsbC4KPj4KPj4+IC0tLQo+ Pj4gICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jIHwgIDYgKysr LS0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjlfMC5jICAgICAgfCAx NyArKysrKysrLS0tLS0tLS0tLQo+Pj4gICAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25z KCspLCAxMyBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9kZXZpY2UuYwo+Pj4gaW5kZXggMzUwMGRhMy4uNTdjY2FjNCAxMDA2NDQKPj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+Pj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4+PiBAQCAtMTA0 MiwxMCArMTA0MiwxMCBAQCBzdGF0aWMgYm9vbCBhbWRncHVfY2hlY2tfcG90X2FyZ3VtZW50KGlu dCBhcmcpCj4+PiAgICBzdGF0aWMgdm9pZCBhbWRncHVfZ2V0X2Jsb2NrX3NpemUoc3RydWN0IGFt ZGdwdV9kZXZpY2UgKmFkZXYpCj4+PiAgICB7Cj4+PiAgICAgICAgLyogZnJvbSBBSSwgYXNpYyBz dGFydHMgdG8gc3VwcG9ydCBtdWx0aXBsZSBsZXZlbCBWTVBUICovCj4+PiAtICAgIGlmIChhZGV2 LT5mYW1pbHkgPj0gQU1ER1BVX0ZBTUlMWV9BSSkgewo+Pj4gKyAgICBpZiAoYWRldi0+YXNpY190 eXBlID49IENISVBfVkVHQTEwKSB7Cj4+PiAgICAgICAgICAgIGlmIChhbWRncHVfdm1fYmxvY2tf c2l6ZSAhPSA5KQo+Pj4gLSAgICAgICAgICAgIGRldl93YXJuKGFkZXYtPmRldiwgIk11bHRpLVZN UFQgbGltaXRzIGJsb2NrIHNpemUgdG8iCj4+PiAtICAgICAgICAgICAgICAgICAib25lIHBhZ2Uh XG4iKTsKPj4+ICsgICAgICAgICAgICBkZXZfd2FybihhZGV2LT5kZXYsCj4+PiArICAgICAgICAg ICAgICAgICAiTXVsdGktVk1QVCBsaW1pdHMgYmxvY2sgc2l6ZSB0byBvbmUgcGFnZSFcbiIpOwo+ Pj4gICAgICAgICAgICBhbWRncHVfdm1fYmxvY2tfc2l6ZSA9IDk7Cj4+PiAgICAgICAgICAgIHJl dHVybjsKPj4+ICAgICAgICB9Cj4+Cj4+IE5pY2UgY2F0Y2guCj4+Cj4+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAuYwo+Pj4gYi9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGdwdS9nbWNfdjlfMC5jCj4+PiBpbmRleCAxZTQ3MzRkLi5kZjY5YWFlIDEwMDY0 NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAuYwo+Pj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAuYwo+Pj4gQEAgLTUxMSwxMiAr NTExLDYgQEAgc3RhdGljIGludCBnbWNfdjlfMF92bV9pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNl Cj4+PiAqYWRldikKPj4+ICAgICAgICAgKiBhbWRrZmQgd2lsbCB1c2UgVk1JRHMgOC0xNQo+Pj4g ICAgICAgICAqLwo+Pj4gICAgICAgIGFkZXYtPnZtX21hbmFnZXIubnVtX2lkcyA9IEFNREdQVV9O VU1fT0ZfVk1JRFM7Cj4+PiAtICAgIC8qIEJlY2F1c2Ugb2YgZm91ciBsZXZlbCBWTVBUcywgdm0g c2l6ZSBhdCBsZWFzdCBpcyAyNTZHQi4KPj4+IC0gICAgMjU2VEIgaXMgT0sgYXMgd2VsbCAqLwo+ Pj4gLSAgICBpZiAoYW1kZ3B1X3ZtX3NpemUgPCAyNTYpIHsKPj4+IC0gICAgICAgIERSTV9XQVJO KCJ2bSBzaXplIGF0IGxlYXN0IGlzIDI1NkdCIVxuIik7Cj4+PiAtICAgICAgICBhbWRncHVfdm1f c2l6ZSA9IDI1NjsKPj4+IC0gICAgfQo+Pgo+PiBEYXZpZCBoYWQgYSBwYXRjaCB0byBmaXggaXQg eWVzdGVyZGF5Lgo+PiBCdXQgeW91ciBwYXRjaCBpbnZvbHZlcyBieSB2bSBzaXplIGNoZWNraW5n LiA6KQo+Pgo+Pj4gICAgICAgIGFkZXYtPnZtX21hbmFnZXIubnVtX2xldmVsID0gMzsKPj4+ICAg ICAgICBhbWRncHVfdm1fbWFuYWdlcl9pbml0KGFkZXYpOwo+Pj4KPj4+IEBAIC01NjMsMTEgKzU1 NywxNCBAQCBzdGF0aWMgaW50IGdtY192OV8wX3N3X2luaXQodm9pZCAqaGFuZGxlKQo+Pj4gICAg ICAgIGlmIChyKQo+Pj4gICAgICAgICAgICByZXR1cm4gcjsKPj4+Cj4+PiAtICAgIC8qIEFkanVz dCBWTSBzaXplIGhlcmUuCj4+PiAtICAgICAqIEN1cnJlbnRseSBkZWZhdWx0IHRvIDY0R0IgKCgx NiA8PCAyMCkgNGsgcGFnZXMpLgo+Pj4gLSAgICAgKiBNYXggR1BVVk0gc2l6ZSBpcyA0OCBiaXRz Lgo+Pj4gKyAgICAvKiBCZWNhdXNlIG9mIGZvdXIgbGV2ZWwgVk1QVHMsIHZtIHNpemUgaXMgYXQg bGVhc3QgNTEyR0IuCj4+PiArICAgICAqIFRoZSBtYXhpbXVtIHNpemUgaXMgMjU2VEIgKDQ4Yml0 KS4KPj4+ICAgICAgICAgKi8KPj4+IC0gICAgYWRldi0+dm1fbWFuYWdlci5tYXhfcGZuID0gYW1k Z3B1X3ZtX3NpemUgPDwgMTg7Cj4+PiArICAgIGlmIChhbWRncHVfdm1fc2l6ZSA8IDUxMikgewo+ Pj4gKyAgICAgICAgRFJNX1dBUk4oIlZNIHNpemUgaXMgYXQgbGVhc3QgNTEyR0IhXG4iKTsKPj4+ ICsgICAgICAgIGFtZGdwdV92bV9zaXplID0gNTEyOwo+Pj4gKyAgICB9Cj4+PiArICAgIGFkZXYt PnZtX21hbmFnZXIubWF4X3BmbiA9ICh1aW50NjRfdClhbWRncHVfdm1fc2l6ZSA8PCAxODsKPj4+ Cj4+PiAgICAgICAgLyogU2V0IHRoZSBpbnRlcm5hbCBNQyBhZGRyZXNzIG1hc2sKPj4+ICAgICAg ICAgKiBUaGlzIGlzIHRoZSBtYXggYWRkcmVzcyBvZiB0aGUgR1BVJ3MKPj4+Cj4KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxp c3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==