From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs Date: Wed, 29 Mar 2017 13:58:26 +0800 Message-ID: <58DB4D02.7020903@amd.com> References: <1490749231-16157-1-git-send-email-Felix.Kuehling@amd.com> <1490749231-16157-4-git-send-email-Felix.Kuehling@amd.com>, <58DB21CB.4090800@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Kuehling, Felix" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Koenig, Christian" , "Zhou, David(ChunMing)" Cc: "Deucher, Alexander" , "Russell, Kent" SGkgRmVsaXgsCgpUaGFua3MgZm9yIHlvdXIgaWxsdXN0cmF0aW9uIHdpdGggcGF0aWVuY2UuCkkg Z290IHlvdXIgbWVhbmluZyB0aGVuLCBhbmQgdGhhbmtzIHRvIGZpeCB0aGF0LgoKID4gSSB0aGlu ayB5b3UncmUgcmlnaHQsIHRoZXJlIGFyZSBzb21lIGV4dHJhIGhpZ2ggYml0cyBpbiBzYWRkciBh bmQgZWFkZHIsIGJ1dAogPiB0aGV5IGdldCBkaXNjYXJkZWQgYnkgdGhlIG1vZHVsby1kaXZpc2lv biBpbiB0aGUgbmV4dCByZWN1cnNpb24gbGV2ZWwuIEZvcgogPiBhZGRlZCBjbGFyaXR5IHRoZSBt b2R1bG8gZGl2aXNpb24gKG9yIG1hc2tpbmcgb2YgaGlnaCBiaXRzKSBjb3VsZCBiZSBtb3ZlZCB1 cAogPiB0byB0aGUgY2FsbGVyLgoKSXQgbWF5IGJlIG1vcmUgY2xlYXIgaWYgbW9kdWxvLWRpdmlz aW9uIGNhbGxlZCBiZWZvcmUgdGhlIGNhbGxlci4KQW55d2F5LApSZXZpZXdlZC1ieTogSnVud2Vp IFpoYW5nIDxKZXJyeS5aaGFuZ0BhbWQuY29tPgoKCk9uIDAzLzI5LzIwMTcgMTE6MjQgQU0sIEt1 ZWhsaW5nLCBGZWxpeCB3cm90ZToKPiBIaSBKZXJyeSwKPgo+IExldCBtZSBjbGFyaWZ5IG15IHVu ZGVyc3RhbmRpbmcgb2YgdGhlIHByb2JsZW0gYW5kIHRoZSBpbnRlbnRpb24gb2YgdGhlIGZpeC4K Pgo+IEFkZHJlc3MgcmFuZ2UgcGVyIHBhZ2U6IDRLQgo+IEFkZHJlc3MgcmFuZ2UgcGVyIFBUIChs ZXZlbCAzKTogMk1CCj4gQWRkcmVzcyByYW5nZSBwZXIgUEQgKGxldmVsIDIpOiAxR0IKPiBBZGRy ZXNzIHJhbmdlIHBlciBQRCAobGV2ZWwgMSk6IDUxMkdCCj4gQWRkcmVzcyByYW5nZSBwZXIgUEQg KGxldmVsIDApOiAyNTZUQgo+Cj4gSW1hZ2luZSBmb3IgZXhhbXBsZSBhIG1hcHBpbmcgdGhhdCBz cGFucyBtdWx0aXBsZSBsZXZlbCAyIHBhZ2UgZGlyZWN0b3JpZXMuIFNheQo+IGZyb20gMC41R0Ig dG8gMi41R0IuCj4KPiBBdCBsZXZlbCAwOgo+IGZyb20gPSAwCj4gdG8gPSAwCj4KPiBBdCBsZXZl bCAxOgo+IGZyb20gPSAwCj4gdG8gPSAyCj4KPiBTbyBmb3IgbGV2ZWwgMiBhbWRncHVfdm1fYWxs b2NfbGV2ZWxzIGdldHMgY2FsbGVkIDMgdGltZXMgKHB0X2lkeCA9IFswLi4yXSkuCj4gV2l0aG91 dCBteSBjaGFuZ2UsIGl0IGdldHMgY2FsbGVkIHdpdGggdGhlIHNhbWUgc2FkZHIgYW5kIGVhZGRy IDMgdGltZXMuIFNvIGl0Cj4gY2FsY3VsYXRlcyB0aGUgc2FtZSAiZnJvbSIgYW5kICJ0byIgZWFj aCB0aW1lOgo+IGZyb20gPSAyNTYgJSA1MTIgPSAyNTYKPiB0byA9IDc2NyAlIDUxMiA9IDI1NQo+ Cj4gT2J2aW91c2x5IHRoYXQgZG9lc24ndCB3b3JrLiBXaGF0IHdlIHJlYWxseSB3YW50IGlzIHRo aXMgKGZyb20uLnRvIGluIGxldmVsIDIKPiB3aGVuIGNhbGxlZCBmb3IgcHRfaWR4IHZhbHVlcyBm cm9tIGxldmVsIDEpOgo+Cj4gRm9yIHB0X2lkeD0wIHdlIHdhbnQgdG8gZmlsbCB0aGUgc2Vjb25k IGhhbGYgb2YgdGhlIGxldmVsIDIgcGFnZSBkaXJlY3Rvcnkgd2l0aAo+IHBhZ2UgdGFibGVzOgo+ IGZyb20gPSAyNTYKPiB0byA9IDUxMQo+Cj4gRm9yIHB0X2lkeD0xIHdlIG5lZWQgdG8gZmlsbCB0 aGUgZW50aXJlIGxldmVsIDIgcGFnZSBkaXJlY3RvcmllcyB3aXRoIHBhZ2UgdGFibGVzOgo+IGZy b20gPSAwCj4gdG8gPSA1MTEKPgo+IEZvciBwdF9pZHg9MiB3ZSB3YW50IHRvIGZpbGwgdGhlIGZp cnN0IGhhbGYgb2YgdGhlIGxldmVsIDIgcGFnZSBkaXJlY3Rvcnkgd2l0aAo+IHBhZ2UgdGFibGVz Ogo+IGZyb20gPSAwCj4gdG8gPSAyNTUKPgo+IFRoaXMgY3JlYXRlcyBhIGNvbnRpZ3VvdXMgcmFu Z2Ugb2YgcGFnZSB0YWJsZXMgYWNyb3NzIHRoZSB0aHJlZSBsZXZlbCAyIHBhZ2UKPiBkaXJlY3Rv cmllcyB0aGF0IGFyZSBzcGFubmVkIGJ5IHRoZSBhbGxvY2F0aW9uLiBNeSBjaGFuZ2UgYWNoaWV2 ZXMgdGhhdC4KPgo+IEkgdGhpbmsgeW91J3JlIHJpZ2h0LCB0aGVyZSBhcmUgc29tZSBleHRyYSBo aWdoIGJpdHMgaW4gc2FkZHIgYW5kIGVhZGRyLCBidXQKPiB0aGV5IGdldCBkaXNjYXJkZWQgYnkg dGhlIG1vZHVsby1kaXZpc2lvbiBpbiB0aGUgbmV4dCByZWN1cnNpb24gbGV2ZWwuIEZvcgo+IGFk ZGVkIGNsYXJpdHkgdGhlIG1vZHVsbyBkaXZpc2lvbiAob3IgbWFza2luZyBvZiBoaWdoIGJpdHMp IGNvdWxkIGJlIG1vdmVkIHVwCj4gdG8gdGhlIGNhbGxlci4KPgo+IFJlZ2FyZHMsCj4gICAgRmVs aXgKPgo+Cj4gLS0KPiBGIGUgbCBpIHggICBLIHUgZSBoIGwgaSBuIGcKPiBTTVRTIFNvZnR3YXJl IERldmVsb3BtZW50IEVuZ2luZWVyIHwgVmVydGljYWwgV29ya3N0YXRpb24vQ29tcHV0ZQo+IDEg Q29tbWVyY2UgVmFsbGV5IERyLiBFYXN0LCBNYXJraGFtLCBPTiBMM1QgN1g2IENhbmFkYQo+IChP KSArMSgyODkpNjk1LTE1OTcKPiAgICAgXyAgICAgXyAgIF8gICBfX19fXyAgIF9fX19fCj4gICAg LyBcICAgfCBcIC8gfCB8ICBfICBcICBcIF8gIHwKPiAgIC8gQSBcICB8IFxNLyB8IHwgfEQpICkg IC98X3wgfAo+IC9fLyBcX1wgfF98IHxffCB8X19fX18vIHxfXy8gXHwgICBmYWNlYm9vay5jb20v QU1EIHwgYW1kLmNvbQo+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAqRnJvbToqIFpoYW5nLCBK ZXJyeQo+ICpTZW50OiogVHVlc2RheSwgTWFyY2ggMjgsIDIwMTcgMTA6NTQ6MDMgUE0KPiAqVG86 KiBLdWVobGluZywgRmVsaXg7IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnOyBLb2VuaWcs IENocmlzdGlhbjsgWmhvdSwKPiBEYXZpZChDaHVuTWluZykKPiAqQ2M6KiBEZXVjaGVyLCBBbGV4 YW5kZXI7IFJ1c3NlbGwsIEtlbnQKPiAqU3ViamVjdDoqIFJlOiBbUEFUQ0ggMy8zXSBkcm0vYW1k Z3B1OiBGaXggbXVsdGktbGV2ZWwgcGFnZSB0YWJsZSBidWdzIGZvcgo+IGxhcmdlIEJPcwo+IE9u IDAzLzI5LzIwMTcgMDk6MDAgQU0sIEZlbGl4IEt1ZWhsaW5nIHdyb3RlOgo+PiBGaXggdGhlIHN0 YXJ0L2VuZCBhZGRyZXNzIGNhbGN1bGF0aW9uIGZvciBhZGRyZXNzIHJhbmdlcyB0aGF0IHNwYW4K Pj4gbXVsdGlwbGUgcGFnZSBkaXJlY3RvcmllcyBpbiBhbWRncHVfdm1fYWxsb2NfbGV2ZWxzLgo+ Pgo+PiBBZGQgV0FSTl9PTnMgaWYgcGFnZSB0YWJsZXMgYXJlbid0IGZvdW5kLiBPdGhlcndpc2Ug dGhlIHBhZ2UgdGFibGUKPj4gdXBkYXRlIHdvdWxkIGp1c3QgZmFpbCBzaWxlbnRseS4KPj4KPj4g U2lnbmVkLW9mZi1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhsaW5nQGFtZC5jb20+Cj4+ IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jIHwgMTMgKysr KysrKysrKy0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAzIGRlbGV0 aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X3ZtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+PiBpbmRl eCA4MTg3NDdmLi40NGFhMDM5IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfdm0uYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfdm0uYwo+PiBAQCAtMjc4LDYgKzI3OCw4IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX2FsbG9j X2xldmVscyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPj4gICAgICAgIGZyb20gPSAoc2Fk ZHIgPj4gc2hpZnQpICUgYW1kZ3B1X3ZtX251bV9lbnRyaWVzKGFkZXYsIGxldmVsKTsKPj4gICAg ICAgIHRvID0gKGVhZGRyID4+IHNoaWZ0KSAlIGFtZGdwdV92bV9udW1fZW50cmllcyhhZGV2LCBs ZXZlbCk7Cj4+Cj4+ICsgICAgIFdBUk5fT04oZnJvbSA+IHRvKTsKPj4gKwo+PiAgICAgICAgaWYg KHRvID4gcGFyZW50LT5sYXN0X2VudHJ5X3VzZWQpCj4+ICAgICAgICAgICAgICAgIHBhcmVudC0+ bGFzdF9lbnRyeV91c2VkID0gdG87Cj4+Cj4+IEBAIC0zMTIsOCArMzE0LDExIEBAIHN0YXRpYyBp bnQgYW1kZ3B1X3ZtX2FsbG9jX2xldmVscyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPj4g ICAgICAgICAgICAgICAgfQo+Pgo+PiAgICAgICAgICAgICAgICBpZiAobGV2ZWwgPCBhZGV2LT52 bV9tYW5hZ2VyLm51bV9sZXZlbCkgewo+PiAtICAgICAgICAgICAgICAgICAgICAgciA9IGFtZGdw dV92bV9hbGxvY19sZXZlbHMoYWRldiwgdm0sIGVudHJ5LCBzYWRkciwKPj4gLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVhZGRyLCBsZXZlbCk7Cj4+ICsg ICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCBzdWJfc2FkZHIgPSAocHRfaWR4ID09IGZyb20p ID8gc2FkZHIgOiAwOwo+PiArICAgICAgICAgICAgICAgICAgICAgdWludDY0X3Qgc3ViX2VhZGRy ID0gKHB0X2lkeCA9PSB0bykgPyBlYWRkciA6Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICgoMSA8PCBzaGlmdCkgLSAxKTsKPj4gKyAgICAgICAgICAgICAgICAgICAgIHIgPSBhbWRn cHVfdm1fYWxsb2NfbGV2ZWxzKGFkZXYsIHZtLCBlbnRyeSwgc3ViX3NhZGRyLAo+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3ViX2VhZGRyLCBsZXZl bCk7Cj4KPiBEbyB5b3UgbWVhbiB0byBjcmVhdGUgYSBmdWxsIHN1Yi1wdCBpZiBwdF9pZHggIT0g ZnJvbSBhbmQgIT0gdG8/Cj4gSSBkaWRuJ3QgY2F0Y2ggaXQgdXAgY2xlYXIuCj4KPiBJbiBteSBw ZXJzcGVjdGl2ZSwgd2UgbWF5IG5lZWQgdG8gY2xlYXIgdGhlIHNhZGRyIGFuZCBlYWRkciB1cHBl ciBsZXZlbCBiaXQKPiBiZWZvcmUgZ29pbmcgb24gdG8gYWxsb2NhdGUgdGhlIG5leHQgbGV2ZWwg UFQuCj4gT3RoZXJ3aXNlLCB0aGUgbnVtYmVyIG9mIG5leHQgUFQgZW50cnkgd2lsbCBiZSBpbmNv cnJlY3QsIG1vcmUgdGhhbiBudW1fZW50cmllcwo+IGFzIHRoZSB1cHBlciBsZXZlbCBQVCBudW1i ZXIgY2FsY3VsYXRlZCBpbi4KPgo+IGUuZy4KPiB0aGVyZSBpcyBhIGFkZHJlc3MgY29udGFpbnMK PiBQRCArIFBUMSArIFBUMiArIFBUMwo+Cj4gZm9yIHRoZSBmaXJzdCByb3VuZCwgd2UgY291bGQg Z2V0IGNvcnJlY3QgImZyb20iIGFuZCAidG8iIGFkZHJlc3Mgd2l0aCByaWdodAo+ICJzaGlmdCIo MyBibG9ja3MpLCB0aGVuIHdhbGsgb3ZlciB0aGUgYWRkcmVzcyBzcGFjZSBpbiBQRCByYW5nZS4K Pgo+IFRoZW4gZm9yIHRoZSAybmQgcm91bmQsIHdlIGNhbm5vdCBnZXQgdGhlIGV4cGVjdGVkICJm cm9tIiBhbmQgInRvIiBhZGRyZXNzIHdpdGgKPiAic2hpZnQiKDIgYmxvY2tzKSwgYXMgaXQgd2Fs a3Mgb3ZlciB0aGUgYWRkcmVzcyBzcGFjZSBpbiBQRCArIFBUMSByYW5nZS4KPiBXaGlsZSB3ZSdk IGxpa2UgaXQncyBpbiByYW5nZSBQVDEgaW5kZWVkLgo+Cj4gVGhlIGZhdWx0IHdheSBnb2VzIG9u IHdpdGggbGF0ZXIgcm91bmQuCj4KPiBQZXJoYXBzLCB0aGF0J3MgdGhlIHJvb3QgY2F1c2UgYWJv dXQgdGhlIGlzc3VlIHlvdSBmYWNlLgo+Cj4gSmVycnkuCj4KPj4gICAgICAgICAgICAgICAgICAg ICAgICBpZiAocikKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiByOwo+ PiAgICAgICAgICAgICAgICB9Cj4+IEBAIC05NTcsOSArOTYyLDExIEBAIHN0YXRpYyBzdHJ1Y3Qg YW1kZ3B1X2JvICphbWRncHVfdm1fZ2V0X3B0KHN0cnVjdCBhbWRncHVfcHRlX3VwZGF0ZV9wYXJh bXMgKnAsCj4+ICAgICAgICAgICAgICAgIGVudHJ5ID0gJmVudHJ5LT5lbnRyaWVzW2lkeF07Cj4+ ICAgICAgICB9Cj4+Cj4+IC0gICAgIGlmIChsZXZlbCkKPj4gKyAgICAgaWYgKFdBUk5fT04obGV2 ZWwpKQo+PiAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPj4KPj4gKyAgICAgV0FSTl9PTigh ZW50cnktPmJvKTsKPj4gKwo+PiAgICAgICAgcmV0dXJuIGVudHJ5LT5ibzsKPj4gICB9Cj4+Cj4+ Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZngg bWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=