From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 2/3] drm/amdgpu: Fix Vega10 VM initialization Date: Wed, 29 Mar 2017 15:09:20 +0800 Message-ID: <58DB5DA0.9060607@amd.com> References: <1490749231-16157-1-git-send-email-Felix.Kuehling@amd.com> <1490749231-16157-3-git-send-email-Felix.Kuehling@amd.com> <58DB1061.7000403@amd.com> <0091f779-a045-7009-3746-6957ccacd62f@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , Felix Kuehling , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, David1.Zhou-5C7GfCeVMHo@public.gmane.org Cc: Alexander.Deucher-5C7GfCeVMHo@public.gmane.org, Kent.Russell-5C7GfCeVMHo@public.gmane.org T24gMDMvMjkvMjAxNyAwMjo0NyBQTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBBbSAyOS4w My4yMDE3IHVtIDAzOjQ4IHNjaHJpZWIgRmVsaXggS3VlaGxpbmc6Cj4+IE9uIDE3LTAzLTI4IDA5 OjM5IFBNLCBaaGFuZywgSmVycnkgKEp1bndlaSkgd3JvdGU6Cj4+PiBPbiAwMy8yOS8yMDE3IDA5 OjAwIEFNLCBGZWxpeCBLdWVobGluZyB3cm90ZToKPj4+PiBhZGV2LT5mYW1pbHkgaXMgbm90IGlu aXRpYWxpemVkIHlldCB3aGVuIGFtZGdwdV9nZXRfYmxvY2tfc2l6ZSBpcwo+Pj4+IGNhbGxlZC4g VXNlIGFkZXYtPmFzaWNfdHlwZSBpbnN0ZWFkLgo+Pj4+Cj4+Pj4gTWluaW11bSBWTSBzaXplIGlz IDUxMkdCLCBub3QgMjU2R0IsIGZvciBhIHNpbmdsZSBwYWdlIHRhYmxlIGVudHJ5Cj4+Pj4gaW4g dGhlIHJvb3QgcGFnZSB0YWJsZS4KPj4+Pgo+Pj4+IGdtY192OV8wX3ZtX2luaXQgaXMgY2FsbGVk IGFmdGVyIGFkZXYtPnZtX21hbmFnZXIubWF4X3BmbiBpcwo+Pj4+IGluaXRpYWxpemVkLiBNb3Zl IHRoZSBtaW5pbXVtIFZNLXNpemUgZW5mb3JjZW1lbnQgYWhlYWQgb2YgbWF4X3Bmbgo+Pj4+IGlu aXRpYWxpenRpb24uIENhc3QgdG8gNjQtYml0IGJlZm9yZSB0aGUgbGVmdC1zaGlmdC4KPj4+Pgo+ Pj4+IFNpZ25lZC1vZmYtYnk6IEZlbGl4IEt1ZWhsaW5nIDxGZWxpeC5LdWVobGluZ0BhbWQuY29t Pgo+Pj4gUmV2aWV3ZWQtYnk6IEp1bndlaSBaaGFuZyA8SmVycnkuWmhhbmdAYW1kLmNvbT4KPj4+ Cj4+PiBKdXN0IG5vdGU6Cj4+PiBGb3Igbm93LCBpdCdzIE9LIHRvIHNldCB0aGUgbWluaW11bSB2 bSBzaXplIDI1NkcsCj4+PiBJbiB0aGlzIGNhc2UsIHRoZXJlIGlzIG5vIFBEIGJpdCBhbnl3YXku Cj4+IFdpdGggVk0gc2l6ZSBvZiAyNTZHQiwgdGhlIGFtZGdwdV92bV9ib19zaXplKGFkZXYsIDAp IGNhbGN1bGF0ZXMgMCwgYW5kCj4+IHRoZSBwYWdlIGRpcmVjdG9yeSBhbGxvY2F0aW9uIHdpdGgg YW1kZ3B1X2JvX2NyZWF0ZSBmYWlscyBpbiBhbWRncHVfdm1faW5pdC4KPj4KPj4gSW4gb3RoZXIg d29yZHMsIGFtZGdwdV92bV9udW1fZW50cmllcyhhZGV2LCAwKSBuZWVkcyB0byByZXR1cm4gYXQg bGVhc3QKPj4gMS4gVGhhdCBtZWFucyB2bV9zaXplIG5lZWRzIHRvIGJlIGF0IGxlYXN0IDUxMkdC Lgo+Cj4gVGhvc2UgZml4ZXMgYXJlIGNvcnJlY3QsIGJ1dCBkb2Vzbid0IGFkZHJlc3MgdGhlIHJl YWwgcHJvYmxlbS4KPgo+IFRoZSBpbnRlbnRpb24gb2YgYW1kZ3B1X3ZtX3NpemUgYW5kIGFtZ3B1 X3ZtX2Jsb2NrX3NpemUgaXMgdG8gc2F2ZSBtZW1vcnkgYnkKPiByZWR1Y2luZyB0aGUgc2l6ZSBv ZiB0aGUgUEQvUFRzLgo+Cj4gU2luY2Ugd2Ugbm93IHVzZSA0IGxldmVsIFBEcy9QVHMgdGhlIHNp emUgb2YgZWFjaCBpcyA0S0IsIHdoaWNoIGlzIHVzdWFsbHkgdGhlCj4gc21hbGxlc3QgYWxsb2Nh dGlvbiBzaXplIGFueXdheS4KCkkgcmVtZW1iZXIgd2UgdXNlIDUxMkIgKDktYml0KSBmb3IgZWFj aCBQRC9QVCBmb3IgVmVnYTEwLgoKPgo+IFNvIEkgc3VnZ2VzdCB0byBqdXN0IGRyb3Agc3VwcG9y dCBmb3IgYW1kZ3B1X3ZtX3NpemUgZm9yIFZlZ2ExMCBhbmQgYWx3YXlzIHVzZQo+IDI1NlRCIGlu c3RlYWQuCj4KPiBKZXJyeSBkbyB5b3Ugd2FudCB0byB0YWtlIGNhcmUgb2YgdGhpcyBvciBzaG91 bGQgSSBsb29rIGludG8gaXQ/IFNob3VsZCBiZQo+IHRyaXZpYWwgdG8gZG8uCgpEbyB5b3UgbWVh biB0byBmaXggdGhlIHZtX3NpemUgZm9yIFZlZ2ExMD8KWWVzLCBJIHdpbGwgdGFrZSBvdmVyIGl0 LgoKSmVycnkKCj4KPiBSZWdhcmRzLAo+IENocmlzdGlhbi4KPgo+Pgo+PiBSZWdhcmRzLAo+PiAg ICBGZWxpeAo+Pgo+Pj4gQ2hyaXN0aWFuIGFsc28gbWVudGlvbmVkIHRoYXQgUEQgc2hvdWxkIGJl IDRrIHNpemUsIHRoZW4gMjU2VCB3YXMKPj4+IHJlcXVpcmVkLgo+Pj4gV2hlbiByZWFjaCBhbiBh Z3JlZW1lbnQsIHdlIG1heSB1cGRhdGUgdGhlbSBhbGwuCj4+Pgo+Pj4+IC0tLQo+Pj4+ICAgIGRy aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyB8ICA2ICsrKy0tLQo+Pj4+ ICAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192OV8wLmMgICAgICB8IDE3ICsrKysr KystLS0tLS0tLS0tCj4+Pj4gICAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAx MyBkZWxldGlvbnMoLSkKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfZGV2aWNlLmMKPj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV9kZXZpY2UuYwo+Pj4+IGluZGV4IDM1MDBkYTMuLjU3Y2NhYzQgMTAwNjQ0Cj4+Pj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4+Pj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4+Pj4gQEAgLTEw NDIsMTAgKzEwNDIsMTAgQEAgc3RhdGljIGJvb2wgYW1kZ3B1X2NoZWNrX3BvdF9hcmd1bWVudChp bnQgYXJnKQo+Pj4+ICAgIHN0YXRpYyB2b2lkIGFtZGdwdV9nZXRfYmxvY2tfc2l6ZShzdHJ1Y3Qg YW1kZ3B1X2RldmljZSAqYWRldikKPj4+PiAgICB7Cj4+Pj4gICAgICAgIC8qIGZyb20gQUksIGFz aWMgc3RhcnRzIHRvIHN1cHBvcnQgbXVsdGlwbGUgbGV2ZWwgVk1QVCAqLwo+Pj4+IC0gICAgaWYg KGFkZXYtPmZhbWlseSA+PSBBTURHUFVfRkFNSUxZX0FJKSB7Cj4+Pj4gKyAgICBpZiAoYWRldi0+ YXNpY190eXBlID49IENISVBfVkVHQTEwKSB7Cj4+Pj4gICAgICAgICAgICBpZiAoYW1kZ3B1X3Zt X2Jsb2NrX3NpemUgIT0gOSkKPj4+PiAtICAgICAgICAgICAgZGV2X3dhcm4oYWRldi0+ZGV2LCAi TXVsdGktVk1QVCBsaW1pdHMgYmxvY2sgc2l6ZSB0byIKPj4+PiAtICAgICAgICAgICAgICAgICAi b25lIHBhZ2UhXG4iKTsKPj4+PiArICAgICAgICAgICAgZGV2X3dhcm4oYWRldi0+ZGV2LAo+Pj4+ ICsgICAgICAgICAgICAgICAgICJNdWx0aS1WTVBUIGxpbWl0cyBibG9jayBzaXplIHRvIG9uZSBw YWdlIVxuIik7Cj4+Pj4gICAgICAgICAgICBhbWRncHVfdm1fYmxvY2tfc2l6ZSA9IDk7Cj4+Pj4g ICAgICAgICAgICByZXR1cm47Cj4+Pj4gICAgICAgIH0KPj4+IE5pY2UgY2F0Y2guCj4+Pgo+Pj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjlfMC5jCj4+Pj4g Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjlfMC5jCj4+Pj4gaW5kZXggMWU0NzM0 ZC4uZGY2OWFhZSAxMDA2NDQKPj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9n bWNfdjlfMC5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAu Ywo+Pj4+IEBAIC01MTEsMTIgKzUxMSw2IEBAIHN0YXRpYyBpbnQgZ21jX3Y5XzBfdm1faW5pdChz dHJ1Y3QgYW1kZ3B1X2RldmljZQo+Pj4+ICphZGV2KQo+Pj4+ICAgICAgICAgKiBhbWRrZmQgd2ls bCB1c2UgVk1JRHMgOC0xNQo+Pj4+ICAgICAgICAgKi8KPj4+PiAgICAgICAgYWRldi0+dm1fbWFu YWdlci5udW1faWRzID0gQU1ER1BVX05VTV9PRl9WTUlEUzsKPj4+PiAtICAgIC8qIEJlY2F1c2Ug b2YgZm91ciBsZXZlbCBWTVBUcywgdm0gc2l6ZSBhdCBsZWFzdCBpcyAyNTZHQi4KPj4+PiAtICAg IDI1NlRCIGlzIE9LIGFzIHdlbGwgKi8KPj4+PiAtICAgIGlmIChhbWRncHVfdm1fc2l6ZSA8IDI1 Nikgewo+Pj4+IC0gICAgICAgIERSTV9XQVJOKCJ2bSBzaXplIGF0IGxlYXN0IGlzIDI1NkdCIVxu Iik7Cj4+Pj4gLSAgICAgICAgYW1kZ3B1X3ZtX3NpemUgPSAyNTY7Cj4+Pj4gLSAgICB9Cj4+PiBE YXZpZCBoYWQgYSBwYXRjaCB0byBmaXggaXQgeWVzdGVyZGF5Lgo+Pj4gQnV0IHlvdXIgcGF0Y2gg aW52b2x2ZXMgYnkgdm0gc2l6ZSBjaGVja2luZy4gOikKPj4+Cj4+Pj4gICAgICAgIGFkZXYtPnZt X21hbmFnZXIubnVtX2xldmVsID0gMzsKPj4+PiAgICAgICAgYW1kZ3B1X3ZtX21hbmFnZXJfaW5p dChhZGV2KTsKPj4+Pgo+Pj4+IEBAIC01NjMsMTEgKzU1NywxNCBAQCBzdGF0aWMgaW50IGdtY192 OV8wX3N3X2luaXQodm9pZCAqaGFuZGxlKQo+Pj4+ICAgICAgICBpZiAocikKPj4+PiAgICAgICAg ICAgIHJldHVybiByOwo+Pj4+Cj4+Pj4gLSAgICAvKiBBZGp1c3QgVk0gc2l6ZSBoZXJlLgo+Pj4+ IC0gICAgICogQ3VycmVudGx5IGRlZmF1bHQgdG8gNjRHQiAoKDE2IDw8IDIwKSA0ayBwYWdlcyku Cj4+Pj4gLSAgICAgKiBNYXggR1BVVk0gc2l6ZSBpcyA0OCBiaXRzLgo+Pj4+ICsgICAgLyogQmVj YXVzZSBvZiBmb3VyIGxldmVsIFZNUFRzLCB2bSBzaXplIGlzIGF0IGxlYXN0IDUxMkdCLgo+Pj4+ ICsgICAgICogVGhlIG1heGltdW0gc2l6ZSBpcyAyNTZUQiAoNDhiaXQpLgo+Pj4+ICAgICAgICAg Ki8KPj4+PiAtICAgIGFkZXYtPnZtX21hbmFnZXIubWF4X3BmbiA9IGFtZGdwdV92bV9zaXplIDw8 IDE4Owo+Pj4+ICsgICAgaWYgKGFtZGdwdV92bV9zaXplIDwgNTEyKSB7Cj4+Pj4gKyAgICAgICAg RFJNX1dBUk4oIlZNIHNpemUgaXMgYXQgbGVhc3QgNTEyR0IhXG4iKTsKPj4+PiArICAgICAgICBh bWRncHVfdm1fc2l6ZSA9IDUxMjsKPj4+PiArICAgIH0KPj4+PiArICAgIGFkZXYtPnZtX21hbmFn ZXIubWF4X3BmbiA9ICh1aW50NjRfdClhbWRncHVfdm1fc2l6ZSA8PCAxODsKPj4+Pgo+Pj4+ICAg ICAgICAvKiBTZXQgdGhlIGludGVybmFsIE1DIGFkZHJlc3MgbWFzawo+Pj4+ICAgICAgICAgKiBU aGlzIGlzIHRoZSBtYXggYWRkcmVzcyBvZiB0aGUgR1BVJ3MKPj4+Pgo+Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFt ZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=