From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] x86/mm: Drop MEM_LOG() and correct some printed information Date: Wed, 29 Mar 2017 07:06:38 -0600 Message-ID: <58DBCD7E020000780014A093@prv-mh.provo.novell.com> References: <1490790572-19840-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1490790572-19840-1-git-send-email-andrew.cooper3@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper Cc: Wei Liu , Xen-devel List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDI5LjAzLjE3IGF0IDE0OjI5LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3Jv dGU6Cj4gICogVXNlIDB4IHByZWZpeCBmb3Igb3RoZXJ3aXNlIHVucXVhbGlmaWVkIGhleCBudW1i ZXJzLgoKSSdtIGdsYWQgdGhpcyBpbiBmYWN0IHJlZmVycyB0byBqdXN0IGEgc2luZ2xlIHBsYWNl LgoKPiBAQCAtMTA1NywxMCArMTA2MiwxMCBAQCBnZXRfcGFnZV9mcm9tX2wxZSgKPiAgICAgICAg ICAgICAgICAgIHB1dF9wYWdlX3R5cGUocGFnZSk7Cj4gICAgICAgICAgICAgIHB1dF9wYWdlKHBh Z2UpOwo+ICAKPiAtICAgICAgICAgICAgTUVNX0xPRygiRXJyb3IgdXBkYXRpbmcgbWFwcGluZ3Mg Zm9yIG1mbiAlbHggKHBmbiAlbHgsIgo+IC0gICAgICAgICAgICAgICAgICAgICIgZnJvbSBMMSBl bnRyeSAlIiBQUklwdGUgIikgZm9yICVkIiwKPiAtICAgICAgICAgICAgICAgICAgICBtZm4sIGdl dF9ncGZuX2Zyb21fbWZuKG1mbiksCj4gLSAgICAgICAgICAgICAgICAgICAgbDFlX2dldF9pbnRw dGUobDFlKSwgbDFlX293bmVyLT5kb21haW5faWQpOwo+ICsgICAgICAgICAgICBnZHByaW50ayhY RU5MT0dfV0FSTklORywgIkVycm9yIHVwZGF0aW5nIG1hcHBpbmdzIGZvciBtZm4gJSIgUFJJX21m bgo+ICsgICAgICAgICAgICAgICAgICAgICAiIChwZm4gJSIgUFJJX3BmbiAiLCBmcm9tIEwxIGVu dHJ5ICUiIFBSSXB0ZSAiKSBmb3IgZCVkXG4iLAo+ICsgICAgICAgICAgICAgICAgICAgICBtZm4s IGdldF9ncGZuX2Zyb21fbWZuKG1mbiksCj4gKyAgICAgICAgICAgICAgICAgICAgIGwxZV9nZXRf aW50cHRlKGwxZSksIGwxZV9vd25lci0+ZG9tYWluX2lkKTsKPiAgICAgICAgICAgICAgcmV0dXJu IGVycjsKPiAgICAgICAgICB9Cj4gICAgICB9Cj4gQEAgLTEwNjgsMTAgKzEwNzMsMTAgQEAgZ2V0 X3BhZ2VfZnJvbV9sMWUoCj4gICAgICByZXR1cm4gMDsKPiAgCj4gICBjb3VsZF9ub3RfcGluOgo+ IC0gICAgTUVNX0xPRygiRXJyb3IgZ2V0dGluZyBtZm4gJWx4IChwZm4gJWx4KSBmcm9tIEwxIGVu dHJ5ICUiIFBSSXB0ZQo+IC0gICAgICAgICAgICAiIGZvciBsMWVfb3duZXI9JWQsIHBnX293bmVy PSVkIiwKPiAtICAgICAgICAgICAgbWZuLCBnZXRfZ3Bmbl9mcm9tX21mbihtZm4pLAo+IC0gICAg ICAgICAgICBsMWVfZ2V0X2ludHB0ZShsMWUpLCBsMWVfb3duZXItPmRvbWFpbl9pZCwgcGdfb3du ZXItPmRvbWFpbl9pZCk7Cj4gKyAgICBnZHByaW50ayhYRU5MT0dfV0FSTklORywgIkVycm9yIGdl dHRpbmcgbWZuICUiIFBSSV9tZm4gIiAocGZuICUiIFBSSV9wZm4KPiArICAgICAgICAgICAgICIp IGZyb20gTDEgZW50cnkgJSIgUFJJcHRlICIgZm9yIGwxZV9vd25lciBkJWQsIHBnX293bmVyIGQl ZCIsCj4gKyAgICAgICAgICAgICBtZm4sIGdldF9ncGZuX2Zyb21fbWZuKG1mbiksCj4gKyAgICAg ICAgICAgICBsMWVfZ2V0X2ludHB0ZShsMWUpLCBsMWVfb3duZXItPmRvbWFpbl9pZCwgcGdfb3du ZXItPmRvbWFpbl9pZCk7CgpFc3BlY2lhbGx5IGhlcmUgdGhlIHdyYXBwaW5nIG9mIHRoZSBmb3Jt YXQgc3RyaW5nIGlzIHJhdGhlcgp1bmZvcnR1bmF0ZS4gRGlkbid0IHdlIGFncmVlIHRvIGFsbG93 IGZvcm1hdCBzdHJpbmdzIHRvIGV4Y2VlZAp0aGUgODAgY29sdW1uIHJlc3RyaWN0aW9uIGFueXdh eT8KCj4gQEAgLTEzODgsNyArMTM5OCw3IEBAIHN0YXRpYyBpbnQgYWxsb2NfbDFfdGFibGUoc3Ry dWN0IHBhZ2VfaW5mbyAqcGFnZSkKPiAgICAgIHJldHVybiAwOwo+ICAKPiAgIGZhaWw6Cj4gLSAg ICBNRU1fTE9HKCJGYWlsdXJlIGluIGFsbG9jX2wxX3RhYmxlOiBlbnRyeSAlZCIsIGkpOwo+ICsg ICAgZ2RwcmludGsoWEVOTE9HX1dBUk5JTkcsICJGYWlsdXJlIGluIGFsbG9jX2wxX3RhYmxlOiBl bnRyeSAlZFxuIiwgaSk7CgoldSAob3IgZXZlbiAlMDN4OyBzYW1lIGluIGFsbG9jX2xbMjM0XV90 YWJsZSgpKQoKPiBAQCAtMTk3OSw3ICsxOTkxLDggQEAgc3RhdGljIGludCBtb2RfbDJfZW50cnko bDJfcGdlbnRyeV90ICpwbDJlLAo+ICAKPiAgICAgIGlmICggdW5saWtlbHkoIWlzX2d1ZXN0X2wy X3Nsb3QoZCwgdHlwZSwgcGdlbnRyeV9wdHJfdG9fc2xvdChwbDJlKSkpICkKPiAgICAgIHsKPiAt ICAgICAgICBNRU1fTE9HKCJJbGxlZ2FsIEwyIHVwZGF0ZSBhdHRlbXB0IGluIFhlbi1wcml2YXRl IGFyZWEgJXAiLCBwbDJlKTsKPiArICAgICAgICBnZHByaW50ayhYRU5MT0dfV0FSTklORywKPiAr ICAgICAgICAgICAgICAgICAiSWxsZWdhbCBMMiB1cGRhdGUgYXR0ZW1wdCBpbiBYZW4tcHJpdmF0 ZSBhcmVhICVwXG4iLCBwbDJlKTsKCkNvdWxkIHlvdSBtYWtlIHRoaXMgbWVzc2FnZSB1c2VmdWwg YXQgb25jZT8gVGhlIHBvaW50ZXIgaXMKbm90IHJlYWxseSBoZWxwZnVsIHRvIGRpYWdub3NlIGFu eXRoaW5nLCBJIHRoaW5rLiBTYW1lIGZvcgptb2RfbFszNF1fZW50cnkoKSB0aGVuLgoKPiBAQCAt MzE3OSw3ICszMjA4LDcgQEAgbG9uZyBkb19tbXVleHRfb3AoCj4gIAo+ICAgICAgICAgIGlmICgg dW5saWtlbHkoX19jb3B5X2Zyb21fZ3Vlc3QoJm9wLCB1b3BzLCAxKSAhPSAwKSApCj4gICAgICAg ICAgewo+IC0gICAgICAgICAgICBNRU1fTE9HKCJCYWQgX19jb3B5X2Zyb21fZ3Vlc3QiKTsKPiAr ICAgICAgICAgICAgZ2RwcmludGsoWEVOTE9HX1dBUk5JTkcsICJCYWQgX19jb3B5X2Zyb21fZ3Vl c3RcbiIpOwoKSSdkIHN1Z2dlc3QgdG8gZHJvcCB0aGlzIG9uZSBhbHRvZ2V0aGVyLgoKPiBAQCAt MzE5NSw3ICszMjI0LDggQEAgbG9uZyBkb19tbXVleHRfb3AoCj4gICAgICAgICAgICAgIGNhc2Ug TU1VRVhUX1VOUElOX1RBQkxFOgo+ICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gICAgICAgICAg ICAgIGRlZmF1bHQ6Cj4gLSAgICAgICAgICAgICAgICBNRU1fTE9HKCJJbnZhbGlkIGV4dGVuZGVk IHB0IGNvbW1hbmQgJSN4Iiwgb3AuY21kKTsKPiArICAgICAgICAgICAgICAgIGdkcHJpbnRrKFhF TkxPR19XQVJOSU5HLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIkludmFsaWQgZXh0ZW5k ZWQgcHQgY29tbWFuZCAlI3hcbiIsIG9wLmNtZCk7CgpBbmQgdGhpcyBvbmUgdG9vLgoKPiBAQCAt MzI5Nyw3ICszMzI5LDggQEAgbG9uZyBkb19tbXVleHRfb3AoCj4gICAgICAgICAgICAgIHBhZ2Ug PSBnZXRfcGFnZV9mcm9tX2dmbihwZ19vd25lciwgb3AuYXJnMS5tZm4sIE5VTEwsIFAyTV9BTExP Qyk7Cj4gICAgICAgICAgICAgIGlmICggdW5saWtlbHkoIXBhZ2UpICkKPiAgICAgICAgICAgICAg ewo+IC0gICAgICAgICAgICAgICAgTUVNX0xPRygiTWZuICVseCBiYWQgZG9tYWluIiwgb3AuYXJn MS5tZm4pOwo+ICsgICAgICAgICAgICAgICAgZ2RwcmludGsoWEVOTE9HX1dBUk5JTkcsCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAibWZuICUiIFBSSV9tZm4gIiBiYWQgZG9tYWluXG4iLCBv cC5hcmcxLm1mbik7CgpQZXJoYXBzIGFsc28gaW5jbHVkZSB0aGUgZG9tYWluIHdoaWNoIHdhcyBz dXBwb3NlZGx5IGJhZD8KCj4gQEAgLTM0NTgsNyArMzQ5Myw4IEBAIGxvbmcgZG9fbW11ZXh0X29w KAo+ICAgICAgICAgICAgICAgICAgcmMgPSAtRVBFUk07Cj4gICAgICAgICAgICAgIGVsc2UgaWYg KCB1bmxpa2VseSghY2FjaGVfZmx1c2hfcGVybWl0dGVkKGQpKSApCj4gICAgICAgICAgICAgIHsK PiAtICAgICAgICAgICAgICAgIE1FTV9MT0coIk5vbi1waHlzZGV2IGRvbWFpbiB0cmllZCB0byBG TFVTSF9DQUNIRS4iKTsKPiArICAgICAgICAgICAgICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5H LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIk5vbi1waHlzZGV2IGRvbWFpbiB0cmllZCB0 byBGTFVTSF9DQUNIRVxuIik7Cj4gICAgICAgICAgICAgICAgICByYyA9IC1FQUNDRVM7Cj4gICAg ICAgICAgICAgIH0KPiAgICAgICAgICAgICAgZWxzZQo+IEBAIC0zNDg0LDcgKzM1MjAsOCBAQCBs b25nIGRvX21tdWV4dF9vcCgKPiAgICAgICAgICAgICAgfQo+ICAgICAgICAgICAgICBlbHNlCj4g ICAgICAgICAgICAgIHsKPiAtICAgICAgICAgICAgICAgIE1FTV9MT0coIk5vbi1waHlzZGV2IGRv bWFpbiB0cmllZCB0byBGTFVTSF9DQUNIRV9HTE9CQUwiKTsKPiArICAgICAgICAgICAgICAgIGdk cHJpbnRrKFhFTkxPR19XQVJOSU5HLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIk5vbi1w aHlzZGV2IGRvbWFpbiB0cmllZCB0byBGTFVTSF9DQUNIRV9HTE9CQUxcbiIpOwo+ICAgICAgICAg ICAgICAgICAgcmMgPSAtRUlOVkFMOwo+ICAgICAgICAgICAgICB9Cj4gICAgICAgICAgICAgIGJy ZWFrOwoKSSB0aGluayB0aGVzZSBjb3VsZCBhbHNvIGJlIGRyb3BwZWQgKGFuZCBwZXJoYXBzIGEg ZmV3IG1vcmUgcmlnaHQKYmVsb3cgaGVyZSkuCgo+IEBAIC0zNzM0LDcgKzM3NzksNyBAQCBsb25n IGRvX21tdV91cGRhdGUoCj4gIAo+ICAgICAgICAgIGlmICggdW5saWtlbHkoX19jb3B5X2Zyb21f Z3Vlc3QoJnJlcSwgdXJlcXMsIDEpICE9IDApICkKPiAgICAgICAgICB7Cj4gLSAgICAgICAgICAg IE1FTV9MT0coIkJhZCBfX2NvcHlfZnJvbV9ndWVzdCIpOwo+ICsgICAgICAgICAgICBnZHByaW50 ayhYRU5MT0dfV0FSTklORywgIkJhZCBfX2NvcHlfZnJvbV9ndWVzdFxuIik7CgpBbmQgdGhpcyBv bmUuCgo+IEBAIC00MjAxLDcgKzQyNTAsOCBAQCBzdGF0aWMgaW50IHJlcGxhY2VfZ3JhbnRfdmFf bWFwcGluZygKPiAgICAgIC8qIERlbGV0ZSBwYWdldGFibGUgZW50cnkuICovCj4gICAgICBpZiAo IHVubGlrZWx5KCFVUERBVEVfRU5UUlkobDEsIHBsMWUsIG9sMWUsIG5sMWUsIGdsMW1mbiwgdiwg MCkpICkKPiAgICAgIHsKPiAtICAgICAgICBNRU1fTE9HKCJDYW5ub3QgZGVsZXRlIFBURSBlbnRy eSBhdCAlcCIsICh1bnNpZ25lZCBsb25nICopcGwxZSk7Cj4gKyAgICAgICAgZ2RwcmludGsoWEVO TE9HX1dBUk5JTkcsCj4gKyAgICAgICAgICAgICAgICAgIkNhbm5vdCBkZWxldGUgUFRFIGVudHJ5 IGF0ICVwXG4iLCAodW5zaWduZWQgbG9uZyAqKXBsMWUpOwoKUGxlYXNlIGRyb3AgdGhlIHN0cmF5 IGNhc3QuCgo+IEBAIC00MzE2LDcgKzQzNjcsNyBAQCBpbnQgcmVwbGFjZV9ncmFudF9ob3N0X21h cHBpbmcoCj4gICAgICAgICAgaWYgKCAhbmV3X2FkZHIgKQo+ICAgICAgICAgICAgICByZXR1cm4g ZGVzdHJveV9ncmFudF9wdGVfbWFwcGluZyhhZGRyLCBmcmFtZSwgY3Vyci0+ZG9tYWluKTsKPiAg ICAgICAgICAKPiAtICAgICAgICBNRU1fTE9HKCJVbnN1cHBvcnRlZCBncmFudCB0YWJsZSBvcGVy YXRpb24iKTsKPiArICAgICAgICBnZHByaW50ayhYRU5MT0dfV0FSTklORywgIlVuc3VwcG9ydGVk IGdyYW50IHRhYmxlIG9wZXJhdGlvblxuIik7Cj4gICAgICAgICAgcmV0dXJuIEdOVFNUX2dlbmVy YWxfZXJyb3I7Cj4gICAgICB9CgpEcm9wIGFnYWluPwoKPiBAQCAtNDQwOCwxMCArNDQ2MCwxMSBA QCBpbnQgZG9uYXRlX3BhZ2UoCj4gIAo+ICAgZmFpbDoKPiAgICAgIHNwaW5fdW5sb2NrKCZkLT5w YWdlX2FsbG9jX2xvY2spOwo+IC0gICAgTUVNX0xPRygiQmFkIGRvbmF0ZSAlbHg6IGVkPSVkIHNk PSVkIGNhZj0lMDhseCB0YWY9JSIgUFJ0eXBlX2luZm8sCj4gLSAgICAgICAgICAgIHBhZ2VfdG9f bWZuKHBhZ2UpLCBkLT5kb21haW5faWQsCj4gLSAgICAgICAgICAgIG93bmVyID8gb3duZXItPmRv bWFpbl9pZCA6IERPTUlEX0lOVkFMSUQsCj4gLSAgICAgICAgICAgIHBhZ2UtPmNvdW50X2luZm8s IHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvKTsKPiArICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5H LCAiQmFkIGRvbmF0ZSBtZm4gJSIgUFJJX21mbgo+ICsgICAgICAgICAgICAgIjogZWQ9JWQgc2Q9 JWQgY2FmPSUwOGx4IHRhZj0lIiBQUnR5cGVfaW5mbyAiXG4iLAo+ICsgICAgICAgICAgICAgcGFn ZV90b19tZm4ocGFnZSksIGQtPmRvbWFpbl9pZCwKPiArICAgICAgICAgICAgIG93bmVyID8gb3du ZXItPmRvbWFpbl9pZCA6IERPTUlEX0lOVkFMSUQsCj4gKyAgICAgICAgICAgICBwYWdlLT5jb3Vu dF9pbmZvLCBwYWdlLT51LmludXNlLnR5cGVfaW5mbyk7CgpXaHkgZGlkIHlvdSBub3QgdXNlIGQl ZCBmb3JtYXR0aW5nIGhlcmU/Cgo+IEBAIC00NDU5LDEwICs0NTEyLDExIEBAIGludCBzdGVhbF9w YWdlKAo+ICAKPiAgIGZhaWw6Cj4gICAgICBzcGluX3VubG9jaygmZC0+cGFnZV9hbGxvY19sb2Nr KTsKPiAtICAgIE1FTV9MT0coIkJhZCBwYWdlICVseDogZWQ9JWQgc2Q9JWQgY2FmPSUwOGx4IHRh Zj0lIiBQUnR5cGVfaW5mbywKPiAtICAgICAgICAgICAgcGFnZV90b19tZm4ocGFnZSksIGQtPmRv bWFpbl9pZCwKPiAtICAgICAgICAgICAgb3duZXIgPyBvd25lci0+ZG9tYWluX2lkIDogRE9NSURf SU5WQUxJRCwKPiAtICAgICAgICAgICAgcGFnZS0+Y291bnRfaW5mbywgcGFnZS0+dS5pbnVzZS50 eXBlX2luZm8pOwo+ICsgICAgZ2RwcmludGsoWEVOTE9HX1dBUk5JTkcsICJCYWQgbWZuICUiIFBS SV9tZm4KPiArICAgICAgICAgICAgICI6IGVkPSVkIHNkPSVkIGNhZj0lMDhseCB0YWY9JSIgUFJ0 eXBlX2luZm8gIlxuIiwKPiArICAgICAgICAgICAgIHBhZ2VfdG9fbWZuKHBhZ2UpLCBkLT5kb21h aW5faWQsCj4gKyAgICAgICAgICAgICBvd25lciA/IG93bmVyLT5kb21haW5faWQgOiBET01JRF9J TlZBTElELAo+ICsgICAgICAgICAgICAgcGFnZS0+Y291bnRfaW5mbywgcGFnZS0+dS5pbnVzZS50 eXBlX2luZm8pOwoKU2FtZSBoZXJlLgoKSXMgdGhpcyBpbnRlbmRlZCBmb3IgNC45PwoKSmFuCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwg bWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK