From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752946AbdDCNOI (ORCPT ); Mon, 3 Apr 2017 09:14:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46800 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751759AbdDCNOG (ORCPT ); Mon, 3 Apr 2017 09:14:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C6150C04B948 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=cavery@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C6150C04B948 Subject: Re: [PATCH v2] scsi: storvsc: Add support for FC rport. To: Christoph Hellwig References: <1491219195-3692-1-git-send-email-cavery@redhat.com> <20170403121718.GA13130@infradead.org> Cc: kys@microsoft.com, haiyangz@microsoft.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, stephen@networkplumber.org, dan.carpenter@oracle.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org From: Cathy Avery Message-ID: <58E24A9A.30200@redhat.com> Date: Mon, 3 Apr 2017 09:14:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20170403121718.GA13130@infradead.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 03 Apr 2017 13:14:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2017 08:17 AM, Christoph Hellwig wrote: >> if (host->transportt == fc_transport_template) { >> + struct fc_rport_identifiers ids = { >> + .roles = FC_PORT_ROLE_FCP_TARGET, >> + }; > I don't think storvsc ever acts as FCP target. In order to implement the work around so that the scsi scan works indicating FC_PORT_ROLE_FCP_TARGET as a role was necessary due to its test in fc_scsi_scan_rport. The idea here is to avoid making any changes to the fc_transport driver which was of some concern. Thanks, Cathy