From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754062AbdDDL6w (ORCPT ); Tue, 4 Apr 2017 07:58:52 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:48331 "EHLO epoutp02.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753423AbdDDL6u (ORCPT ); Tue, 4 Apr 2017 07:58:50 -0400 X-AuditID: b6c32a36-f79446d000002bcd-4e-58e38a778aef MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <58E38A76.6090303@samsung.com> Date: Tue, 04 Apr 2017 20:58:46 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: Takashi Iwai , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] extcon: intel-cht-wc: Make error messages consistent In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA01Se0hTcRTmt3s3r9LqNh8djGxdicjY9M6pM5pmWQy0EkOYhsyL3nztIbub 2QPKrDR7UPpHtQbaAzSJLGdhCiqm+EdkschKaUoKmYn21Bm97naL/O873/nO6+MQmOynOJwo NttYq5kxUpIg/MGjjQrFgdoJfcxkXZhmZvCSSPO80ynRjFY2SzTvXTOirbhurvuFRHe+vQXp XI8P6760RWTgOeyWIpYpYK1y1pxvKSg2F2qptL2G7Ya4+BhaQSdqEii5mTGxWio1PUOxs9jI T6Tk5YzRzlMZDMdR0UlbrBa7jZUXWTibltpH0yolHZOgVKlUSnVs7mZVHC/JY4tOVt0Rl3nC KlqHh0THUOfKWkQQQKrhmnNDLQrkYRg887RKalEQISM7EEzediAhqBbB6bkeiaBSg8s7hwmJ JgTT3h6xLyElV4K33oP7umLkWuh3l/pojNwIU1/rcEHvQbDYcQYT9FHgGXf7a3FyPcwPzPl5 Cc/3TL3yD1tBroMX3gnkw6GkHh42zAf4cAiZCa8WmsXCgCRwf6/342ByD0yO9fv7BPL8y9lp /6JA1gdA84xTIpy8Btp6MeGYVHh31xMg4GCYHmz/i1dDy68RkVBbjcDl9OBCUINg7FalWFDF wti4BxO2WA6z386KhQFSqDklEyQ6cP7+/Ne5FLi66PJjGTmG4MnNXReQ3LHEO8d/7xxLvGtE WAsKY8s4UyHL0WUqJceYOLu5UJlvMbUh/+tFxXeg60PpfYgkELVM2rjtrV4mZsq5g6Y+BARG hUhv1EzoZdIC5uAh1moxWO1GlutDcbz1F7Hw0HwL/8hmm4FWJ8ao41X81yXSNLVKGto6rJeR hYyNLWXZMtb6r05EBIYfQ12X6hXqD3mOteK0hKxNsbat1e5Z70DWYG+J9bIys8RhcL6MTO7s yimQdeWVHpm4V/Up0BWwf3eDNvfMm+ymc1h36NSImRg99REi208YU1oWwqMbklNf0z+S3CmK xaMRw+fs2Ys75hVPK25cyTh7HK+s6MIH0ojTCu3twefeuvsUzhUxdBRm5Zg/UXHGt5ADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsVy+t9jAd3yrscRBjducVu8OT6dyeLyrjls FrcbV7BZvNz8hsmBxeP9vqtsHn1bVjF6bD5d7fF5k1wAS5SbTUZqYkpqkUJqXnJ+SmZeuq1S aIibroWSQl5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMlqb17EW3BOrWH/tHFMD 4y7BLkZODgkBE4nNP94zQ9hiEhfurWfrYuTiEBJYyihxd+p6JpAEr4CgxI/J91i6GDk4mAXk JY5cyoYw1SWmTMmFKH/AKDH50m92iHItiXsPLrGC2CwCqhLfjkLMZwOK739xgw3E5hdQlLj6 4zEjyBxRgQiJ7hOVIGERgQCJn6f6wcYwC9hJXPo1GWyMsICvxJVlPxkhdj1klDi5fAMjSIIT qOj6u1fMExgFZyG5dBbCpbMQLl3AyLyKUSK1ILmgOCk91zAvtVyvODG3uDQvXS85P3cTIziW nkntYDy4y/0QowAHoxIP7wKnRxFCrIllxZW5hxglOJiVRHgXdzyOEOJNSaysSi3Kjy8qzUkt PsRoCvTqRGYp0eR8YJznlcQbmpibmBsbWJhbWpoYKYnzNs5+Fi4kkJ5YkpqdmlqQWgTTx8TB KQWMDHPObe23p85dzbi2gjvW4t6iqE5L7t3n1lb+v7nphfE+KeE3wkrW/AnnDN+yyE26t3dh V9C7/m1rQ53O32Ped/Sc6WFlyQNdnx7o+zoq/+5aN/nYUqujcew+vFNco99kCel7yz++8+/y wYklC56HuTClLwh6EF9m1d9zVse+9dn5xpQVaokpSizFGYmGWsxFxYkAxPUV+bsCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170404115847epcas1p1355ddb3ee24c6754eb933bae5d49f0ae X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170403112709epcas3p331d80584db95bebe4d0ce2a020ffdbf0 X-RootMTR: 20170403112709epcas3p331d80584db95bebe4d0ce2a020ffdbf0 References: <20170403112630.30625-1-hdegoede@redhat.com> <58E33ADC.1000005@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 04월 04일 17:53, Hans de Goede wrote: > Hi, > > On 04-04-17 08:19, Chanwoo Choi wrote: >> Hi, >> >> The intel-cht-wc.c[1] was merged on only extcon-next branch. >> I think that this patch better to be squashed with patch[1]. >> [1] commit 6786e42f31637 ("extcon: intel-cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver") >> >> How about it? > > That is fine with me. OK. Applied it. > > Regards, > > Hans > > > >> >> On 2017년 04월 03일 20:26, Hans de Goede wrote: >>> Before this commit the error messages were a mix of "Failed to ..." and >>> "Error ...ing ...". >>> >>> This commit makes all the error messages consistently use "Error ...ing". >>> >>> Signed-off-by: Hans de Goede >>> --- >>> drivers/extcon/extcon-intel-cht-wc.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/extcon/extcon-intel-cht-wc.c b/drivers/extcon/extcon-intel-cht-wc.c >>> index 0a05cc3..f1c43af 100644 >>> --- a/drivers/extcon/extcon-intel-cht-wc.c >>> +++ b/drivers/extcon/extcon-intel-cht-wc.c >>> @@ -252,7 +252,7 @@ static int cht_wc_extcon_sw_control(struct cht_wc_extcon_data *ext, bool enable) >>> val = enable ? mask : 0; >>> ret = regmap_update_bits(ext->regmap, CHT_WC_CHGRCTRL0, mask, val); >>> if (ret) >>> - dev_err(ext->dev, "Failed setting sw control: %d\n", ret); >>> + dev_err(ext->dev, "Error setting sw control: %d\n", ret); >>> >>> return ret; >>> } >>> @@ -288,7 +288,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) >>> /* Register extcon device */ >>> ret = devm_extcon_dev_register(ext->dev, ext->edev); >>> if (ret) { >>> - dev_err(ext->dev, "Failed to register extcon device\n"); >>> + dev_err(ext->dev, "Error registering extcon device: %d\n", ret); >>> goto disable_sw_control; >>> } >>> >>> @@ -301,7 +301,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) >>> ret = devm_request_threaded_irq(ext->dev, irq, NULL, cht_wc_extcon_isr, >>> IRQF_ONESHOT, pdev->name, ext); >>> if (ret) { >>> - dev_err(ext->dev, "Failed to request interrupt\n"); >>> + dev_err(ext->dev, "Error requesting interrupt: %d\n", ret); >>> goto disable_sw_control; >>> } >>> >>> @@ -310,7 +310,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) >>> (int)~(CHT_WC_PWRSRC_VBUS | CHT_WC_PWRSRC_ID_GND | >>> CHT_WC_PWRSRC_ID_FLOAT)); >>> if (ret) { >>> - dev_err(ext->dev, "Failed to write the irq-mask: %d\n", ret); >>> + dev_err(ext->dev, "Error writing irq-mask: %d\n", ret); >>> goto disable_sw_control; >>> } >>> >> >> > > > -- Best Regards, Chanwoo Choi Samsung Electronics