Re: [PATCH v12 5/6] x86/ioreq server: Asynchronously reset outstanding p2m_ioreq_server entries.

From: "Jan Beulich" <JBeulich@suse.com>
To: Yu Zhang <yu.c.zhang@linux.intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	xen-devel@lists.xen.org, Paul Durrant <paul.durrant@citrix.com>,
	zhiyuan.lv@intel.com, Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH v12 5/6] x86/ioreq server: Asynchronously reset outstanding p2m_ioreq_server entries.
Date: Fri, 07 Apr 2017 06:36:04 -0600	[thread overview]
Message-ID: <58E7A3D4020000780014E8E1@prv-mh.provo.novell.com> (raw)
In-Reply-To: <58E78368.9020904@linux.intel.com>

>>> On 07.04.17 at 14:17, <yu.c.zhang@linux.intel.com> wrote:
> On 4/7/2017 7:28 PM, Jan Beulich wrote:
>>>>> On 07.04.17 at 12:50, <yu.c.zhang@linux.intel.com> wrote:
>>> @@ -546,12 +546,16 @@ static int resolve_misconfig(struct p2m_domain *p2m, unsigned long gfn)
>>>                        {
>>>                             if ( e.sa_p2mt == p2m_ioreq_server )
>>>                             {
>>> -                             ASSERT(p2m->ioreq.entry_count > 0);
>>> -                             p2m->ioreq.entry_count--;
>>> +                             if ( p2m->ioreq.server == NULL )
>>> +                             {
>>> +                                 ASSERT(p2m->ioreq.entry_count > 0);
>>> +                                 p2m->ioreq.entry_count--;
>>> +                                 e.sa_p2mt = p2m_ram_rw;
>>> +                             }
>>>                             }
>>> -
>>> -                         e.sa_p2mt = p2m_is_logdirty_range(p2m, gfn + i, gfn + i)
>>> -                                     ? p2m_ram_logdirty : p2m_ram_rw;
>>> +                         else
>>> +                             e.sa_p2mt = p2m_is_logdirty_range(p2m, gfn + i, gfn + i)
>>> +                                         ? p2m_ram_logdirty : p2m_ram_rw;
>> Now you _never_ change away from ioreq-server, you only adjust
>> the counter.
> 
> Oh right.

Oh, wrong (i.e. I was wrong), you do change the type, and did
overlook that extra new line. So your first suggestion (still visible
above) seems right to me now.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel