From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Hardy <laurent.hardy@6wind.com>
Subject: Re: [PATCH v2] net/ixgbe: ensure link status is updated
Date: Tue, 11 Apr 2017 14:13:17 +0200
Message-ID: <58ECC85D.4010403@6wind.com>
References: <1479403792-11928-1-git-send-email-laurent.hardy@6wind.com>
 <1487262721-22370-1-git-send-email-olivier.matz@6wind.com>
 <20170330111959.43ac9078@platinum>
 <49759EB36A64CF4892C1AFEC9231E8D650A23CB0@PGSMSX101.gar.corp.intel.com>
 <58E24CC8.1080406@6wind.com> <8ce85605-3e52-6088-754e-29ee892681c6@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: Ferruh Yigit <ferruh.yigit@intel.com>, "Dai, Wei" <wei.dai@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Helin" <helin.zhang@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com
 [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 3024C2BB0
 for <dev@dpdk.org>; Tue, 11 Apr 2017 14:13:25 +0200 (CEST)
Received: by mail-wr0-f179.google.com with SMTP id c55so93922802wrc.3
 for <dev@dpdk.org>; Tue, 11 Apr 2017 05:13:25 -0700 (PDT)
In-Reply-To: <8ce85605-3e52-6088-754e-29ee892681c6@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 04/10/2017 03:36 PM, Ferruh Yigit wrote:
> On 4/3/2017 2:23 PM, Laurent Hardy wrote:
>> Hi Wei,
>> Thanks for your reply.
>>
>> If autoneg is false, then we set a default speed to the highest value
>> before performing the link setup.
>> You are right, there is no relevant reason to keep this check on speed
>> mask> should be:
>> +                       if (!autoneg)
>> +                               speed = IXGBE_LINK_SPEED_10GB_FULL;
> Hi Laurent,
>
> Should we expect a new version of the patch with above update?
Hi Ferruh,
yes, I will send a new version today.

regards,
Laurent
> Thanks,
> ferruh
>
>> Patch has been tested using testpmd with following setups:
>>
>> Autoneg setup:
>> =========
>> - On dut, both ports of 82599 are connected to a switch with 1Gb ports
>> - auto-negotiate option is enabled on switch
>>
>> Defined speed setup:
>> ============
>> - set link speed to 1Gb on both ports of the switch connected to the dut
>>
> <...>
>
>>
>> Thanks & regards,
>> Laurent
>>
>> On 03/30/2017 06:32 PM, Dai, Wei wrote:
>>> Hi, Olivier
>>>
>>> Has anyone already tested this patch ?
>>> Can you present some useful info on how to test it ?
>>> Can I use ethtool with some argument to downgrade or upgrade the rate of peer port ?
>>>
>>> I have just run testpmd with 82599, the hw->phy. autoneg_advertised is 0 after rte_eal_init() and rte_eth_dev_start().
>>> So I think the codes in if (!speed) { ... } is likely to be run.
>>> I agree with most of your codes.
>>> But why to limit speed of NIC to 10Gbps if autoneg is false and 10Gbps is supported ?
>>> In this case,  how about setting multiple speed ?
>>>
>>> Thanks
>>> -Wei
>>>
>>>
> <...>
>
>