From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753092AbdDNFjp (ORCPT ); Fri, 14 Apr 2017 01:39:45 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:46791 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752097AbdDNFjm (ORCPT ); Fri, 14 Apr 2017 01:39:42 -0400 Message-ID: <58F06092.9080409@mentor.com> Date: Thu, 13 Apr 2017 22:39:30 -0700 From: Jiada Wang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Mark Brown , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , linux-spi , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH RFC 0/5] *** SPI Slave mode support *** References: <1492085644-4195-1-git-send-email-jiada_wang@mentor.com> <20170413125929.dygodgj6c35ydh5p@sirena.org.uk> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SVR-ORW-MBX-09.mgc.mentorg.com (147.34.90.209) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Geert On 04/13/2017 12:47 PM, Geert Uytterhoeven wrote: > On Thu, Apr 13, 2017 at 2:59 PM, Mark Brown wrote: >> On Thu, Apr 13, 2017 at 05:13:59AM -0700, jiada_wang@mentor.com wrote: >>> From: Jiada Wang >>> >>> v1: >>> add Slave mode support in SPI core >>> spidev create slave device when SPI controller work in slave mode >>> spi-imx support to work in slave mode >> Adding Geert who also had a series doing this in progress that was >> getting very near to being merged. > Thank you! > > Actually my plan is to fix the last remaining issues and resubmit for v4.13. I noticed your patch set for SPI slave support, (I am sure you can find out some of the change in this patch set is based on your work). we have similar requirement to add slave mode support to ecspi IP on imx6 Soc. Our use case is to use spidev as an interface to communicate with external SPI master devices. meanwhile the SPI bus controller can also act as master device to send data to other SPI slave devices on the board. I found in your implementation, SPI bus controller is limited to either work in master mode or slave mode, is there any reasoning to not configure SPI mode based on SPI devices use case? Thanks, Jiada > References: > - v2: https://lkml.org/lkml/2016/9/12/1065 > - v1: https://lkml.org/lkml/2016/6/22/423 > > BTW Jiada, what's your use case? Just spidev? > > Thx! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiada Wang Subject: Re: [PATCH RFC 0/5] *** SPI Slave mode support *** Date: Thu, 13 Apr 2017 22:39:30 -0700 Message-ID: <58F06092.9080409@mentor.com> References: <1492085644-4195-1-git-send-email-jiada_wang@mentor.com> <20170413125929.dygodgj6c35ydh5p@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Mark Brown , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , linux-spi , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org Hello Geert On 04/13/2017 12:47 PM, Geert Uytterhoeven wrote: > On Thu, Apr 13, 2017 at 2:59 PM, Mark Brown wrote: >> On Thu, Apr 13, 2017 at 05:13:59AM -0700, jiada_wang-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org wrote: >>> From: Jiada Wang >>> >>> v1: >>> add Slave mode support in SPI core >>> spidev create slave device when SPI controller work in slave mode >>> spi-imx support to work in slave mode >> Adding Geert who also had a series doing this in progress that was >> getting very near to being merged. > Thank you! > > Actually my plan is to fix the last remaining issues and resubmit for v4.13. I noticed your patch set for SPI slave support, (I am sure you can find out some of the change in this patch set is based on your work). we have similar requirement to add slave mode support to ecspi IP on imx6 Soc. Our use case is to use spidev as an interface to communicate with external SPI master devices. meanwhile the SPI bus controller can also act as master device to send data to other SPI slave devices on the board. I found in your implementation, SPI bus controller is limited to either work in master mode or slave mode, is there any reasoning to not configure SPI mode based on SPI devices use case? Thanks, Jiada > References: > - v2: https://lkml.org/lkml/2016/9/12/1065 > - v1: https://lkml.org/lkml/2016/6/22/423 > > BTW Jiada, what's your use case? Just spidev? > > Thx! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jiada_wang@mentor.com (Jiada Wang) Date: Thu, 13 Apr 2017 22:39:30 -0700 Subject: [PATCH RFC 0/5] *** SPI Slave mode support *** In-Reply-To: References: <1492085644-4195-1-git-send-email-jiada_wang@mentor.com> <20170413125929.dygodgj6c35ydh5p@sirena.org.uk> Message-ID: <58F06092.9080409@mentor.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Geert On 04/13/2017 12:47 PM, Geert Uytterhoeven wrote: > On Thu, Apr 13, 2017 at 2:59 PM, Mark Brown wrote: >> On Thu, Apr 13, 2017 at 05:13:59AM -0700, jiada_wang at mentor.com wrote: >>> From: Jiada Wang >>> >>> v1: >>> add Slave mode support in SPI core >>> spidev create slave device when SPI controller work in slave mode >>> spi-imx support to work in slave mode >> Adding Geert who also had a series doing this in progress that was >> getting very near to being merged. > Thank you! > > Actually my plan is to fix the last remaining issues and resubmit for v4.13. I noticed your patch set for SPI slave support, (I am sure you can find out some of the change in this patch set is based on your work). we have similar requirement to add slave mode support to ecspi IP on imx6 Soc. Our use case is to use spidev as an interface to communicate with external SPI master devices. meanwhile the SPI bus controller can also act as master device to send data to other SPI slave devices on the board. I found in your implementation, SPI bus controller is limited to either work in master mode or slave mode, is there any reasoning to not configure SPI mode based on SPI devices use case? Thanks, Jiada > References: > - v2: https://lkml.org/lkml/2016/9/12/1065 > - v1: https://lkml.org/lkml/2016/6/22/423 > > BTW Jiada, what's your use case? Just spidev? > > Thx! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds