From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754152AbdDOD7z (ORCPT ); Fri, 14 Apr 2017 23:59:55 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36335 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752042AbdDOD7x (ORCPT ); Fri, 14 Apr 2017 23:59:53 -0400 Subject: Re: [PATCH 2/4] of: make __of_attach_node() static To: Rob Herring , Stephen Boyd References: <1492228520-12450-1-git-send-email-frowand.list@gmail.com> <1492228520-12450-3-git-send-email-frowand.list@gmail.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Frank Rowand Message-ID: <58F19A9B.1060001@gmail.com> Date: Fri, 14 Apr 2017 20:59:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1492228520-12450-3-git-send-email-frowand.list@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding Stephen. On 04/14/17 20:55, frowand.list@gmail.com wrote: > From: Frank Rowand > > __of_attach_node() is not used outside of drivers/of/dynamic.c. Make > it static and remove it from drivers/of/of_private.h. > > Signed-off-by: Frank Rowand > --- > drivers/of/dynamic.c | 2 +- > drivers/of/of_private.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c > index c6fd3f32bfcb..74aafe594ad5 100644 > --- a/drivers/of/dynamic.c > +++ b/drivers/of/dynamic.c > @@ -216,7 +216,7 @@ int of_property_notify(int action, struct device_node *np, > return of_reconfig_notify(action, &pr); > } > > -void __of_attach_node(struct device_node *np) > +static void __of_attach_node(struct device_node *np) > { > np->child = NULL; > np->sibling = np->parent->child; > diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h > index 18bbb4517e25..efcedcff7dba 100644 > --- a/drivers/of/of_private.h > +++ b/drivers/of/of_private.h > @@ -78,7 +78,6 @@ extern int __of_update_property(struct device_node *np, > extern void __of_update_property_sysfs(struct device_node *np, > struct property *newprop, struct property *oldprop); > > -extern void __of_attach_node(struct device_node *np); > extern int __of_attach_node_sysfs(struct device_node *np); > extern void __of_detach_node(struct device_node *np); > extern void __of_detach_node_sysfs(struct device_node *np); >