From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbdDOEAK (ORCPT ); Sat, 15 Apr 2017 00:00:10 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33860 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbdDOEAG (ORCPT ); Sat, 15 Apr 2017 00:00:06 -0400 Subject: Re: [PATCH 3/4] of: be consistent in form of file mode To: Rob Herring , Stephen Boyd References: <1492228520-12450-1-git-send-email-frowand.list@gmail.com> <1492228520-12450-4-git-send-email-frowand.list@gmail.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Frank Rowand Message-ID: <58F19AA4.8070001@gmail.com> Date: Fri, 14 Apr 2017 20:59:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1492228520-12450-4-git-send-email-frowand.list@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding Stephen. On 04/14/17 20:55, frowand.list@gmail.com wrote: > From: Frank Rowand > > checkpatch whined about using S_IRUGO instead of octal equivalent > when adding phandle sysfs code, so used octal in that patch. > Change other instances of the S_* constants in the same file to > the octal form. > > Signed-off-by: Frank Rowand > --- > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 197946615503..4a8bd9623140 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -168,7 +168,7 @@ int __of_add_property_sysfs(struct device_node *np, struct property *pp) > > sysfs_bin_attr_init(&pp->attr); > pp->attr.attr.name = safe_name(&np->kobj, pp->name); > - pp->attr.attr.mode = secure ? S_IRUSR : S_IRUGO; > + pp->attr.attr.mode = secure ? 0400 : 0444; > pp->attr.size = secure ? 0 : pp->length; > pp->attr.read = of_node_property_read; > >