From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932484AbdDQJbi (ORCPT ); Mon, 17 Apr 2017 05:31:38 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:54969 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779AbdDQJbg (ORCPT ); Mon, 17 Apr 2017 05:31:36 -0400 Message-ID: <58F48B70.1080602@mentor.com> Date: Mon, 17 Apr 2017 02:31:28 -0700 From: Jiada Wang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jiri Olsa CC: , , , , , , , , , Subject: Re: [PATCH v3 1/1] perf tools: fix perf build with ARCH=x86_64 References: <1491373544-14504-1-git-send-email-jiada_wang@mentor.com> <1491373544-14504-2-git-send-email-jiada_wang@mentor.com> <20170409172711.GA16588@krava> <58EAF143.7090509@mentor.com> <20170410074457.GB25354@krava> In-Reply-To: <20170410074457.GB25354@krava> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2017 12:44 AM, Jiri Olsa wrote: > On Sun, Apr 09, 2017 at 07:43:15PM -0700, Jiada Wang wrote: >> Hello Jiri >> >> On 04/09/2017 10:27 AM, Jiri Olsa wrote: >>> On Tue, Apr 04, 2017 at 11:25:44PM -0700, jiada_wang@mentor.com wrote: >>>> From: Jiada Wang >>>> >>>> with commit: 0a943cb10ce78 (tools build: Add HOSTARCH Makefile variable) >>>> the following build failure is seen when build with ARCH=x86_64 >>> is that described somewhere as a valid building interface? >>> I never use it so I have no idea.. would you describe your >>> build env/process? >> I used "ARCH=x86_64 make -C tools perf V=1" to build perf for x86_64 ARCH. > you're on x86 machine right? I don't see CROSS_COMPILE being used.. > > what's the purpose of the ARCH var setup then? Sorry for late response. Yes, I am on x86 machine, and want to build for x86_64, I didn't mention CROSS_COMPILE option in my last reply is because no matter what 'CROSS_COMPILE' is, the issue can be reproduced when ARCH=X86_64. The full command I used to build perf, is somewhat near to make -C tools perf V=2 ARCH=x86_64 CROSS_COMPILE=i686-pc-linux-gnc-g CC=i686-pc-linux-gnc-gcc Thanks, Jiada > >>>> In file included from util/event.c:2:0: >>>> tools/include/uapi/linux/mman.h:4:27: fatal error: uapi/asm/mman.h: No such file or directory >>>> compilation terminated. >>>> >>>> fix this issue by use SRCARCH instead of ARCH in perf. >>> please describe also the the issue itself in the changelog, not just the fix >> I will update changelog with detail information about the issue in v4 >>> >>> so objtool is using SRCARCH this way, I guess it's fine >>> >>> if we go this way, you also need to change the pmu-events/Build >>> and there's some comment using $(ARCH) in util/header.c >> will update pmu-events/Build in v4 > I'll check > > thanks, > jirka