From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751753AbdDRVI4 (ORCPT ); Tue, 18 Apr 2017 17:08:56 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36226 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbdDRVIw (ORCPT ); Tue, 18 Apr 2017 17:08:52 -0400 Subject: Re: [PATCH 0/4] of: remove *phandle properties from expanded device tree To: Rob Herring , Stephen Boyd References: <1492228520-12450-1-git-send-email-frowand.list@gmail.com> <58F19A75.80500@gmail.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Frank Rowand Message-ID: <58F6804A.3080206@gmail.com> Date: Tue, 18 Apr 2017 14:08:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <58F19A75.80500@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Please do not apply this patch series. The more context I look at, the less this approach seems good. I hope to have a simpler version completed quickly. Thanks, - Frank On 04/14/17 20:58, Frank Rowand wrote: > Hi Stephen, > > I left you off the distribution list, sorry... > > On 04/14/17 20:55, frowand.list@gmail.com wrote: >> From: Frank Rowand >> >> Remove "phandle" and "linux,phandle" properties from the internal >> device tree. The phandle will still be in the struct device_node >> phandle field. >> >> This is to resolve the issue found by Stephen Boyd [1] when he changed >> the type of struct property.value from void * to const void *. As >> a result of the type change, the overlay code had compile errors >> where the resolver updates phandle values. >> >> [1] http://lkml.iu.edu/hypermail/linux/kernel/1702.1/04160.html >> >> Patch 1 is the phandle related changes. >> >> Patches 2 - 4 are minor fixups for issues that became visible >> while implementing patch 1. >> >> Frank Rowand (4): >> of: remove *phandle properties from expanded device tree >> of: make __of_attach_node() static >> of: be consistent in form of file mode >> of: detect invalid phandle in overlay >> >> drivers/of/base.c | 53 +++++++++++++++++++++++++++++++++++++++++++++---- >> drivers/of/dynamic.c | 31 ++++++++++++++++------------- >> drivers/of/fdt.c | 40 ++++++++++++++++++++++--------------- >> drivers/of/of_private.h | 1 - >> drivers/of/overlay.c | 8 +++++--- >> drivers/of/resolver.c | 23 +-------------------- >> include/linux/of.h | 1 + >> 7 files changed, 97 insertions(+), 60 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH 0/4] of: remove *phandle properties from expanded device tree Date: Tue, 18 Apr 2017 14:08:26 -0700 Message-ID: <58F6804A.3080206@gmail.com> References: <1492228520-12450-1-git-send-email-frowand.list@gmail.com> <58F19A75.80500@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <58F19A75.80500-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring , Stephen Boyd Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Rob, Please do not apply this patch series. The more context I look at, the less this approach seems good. I hope to have a simpler version completed quickly. Thanks, - Frank On 04/14/17 20:58, Frank Rowand wrote: > Hi Stephen, > > I left you off the distribution list, sorry... > > On 04/14/17 20:55, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: >> From: Frank Rowand >> >> Remove "phandle" and "linux,phandle" properties from the internal >> device tree. The phandle will still be in the struct device_node >> phandle field. >> >> This is to resolve the issue found by Stephen Boyd [1] when he changed >> the type of struct property.value from void * to const void *. As >> a result of the type change, the overlay code had compile errors >> where the resolver updates phandle values. >> >> [1] http://lkml.iu.edu/hypermail/linux/kernel/1702.1/04160.html >> >> Patch 1 is the phandle related changes. >> >> Patches 2 - 4 are minor fixups for issues that became visible >> while implementing patch 1. >> >> Frank Rowand (4): >> of: remove *phandle properties from expanded device tree >> of: make __of_attach_node() static >> of: be consistent in form of file mode >> of: detect invalid phandle in overlay >> >> drivers/of/base.c | 53 +++++++++++++++++++++++++++++++++++++++++++++---- >> drivers/of/dynamic.c | 31 ++++++++++++++++------------- >> drivers/of/fdt.c | 40 ++++++++++++++++++++++--------------- >> drivers/of/of_private.h | 1 - >> drivers/of/overlay.c | 8 +++++--- >> drivers/of/resolver.c | 23 +-------------------- >> include/linux/of.h | 1 + >> 7 files changed, 97 insertions(+), 60 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html