From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] x86/vpmu_intel: Fix hypervisor crash by catching wrmsr fault Date: Fri, 21 Apr 2017 01:14:28 -0600 Message-ID: <58F9CD740200007800152B3E@prv-mh.provo.novell.com> References: <20170420174942.12913-1-mohit.gambhir@oracle.com> <20170420174942.12913-2-mohit.gambhir@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170420174942.12913-2-mohit.gambhir@oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Mohit Gambhir Cc: kevin.tian@intel.com, boris.ostrovsky@oracle.com, jun.nakajima@intel.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDIwLjA0LjE3IGF0IDE5OjQ5LCA8bW9oaXQuZ2FtYmhpckBvcmFjbGUuY29tPiB3cm90 ZToKPiBUaGlzIHBhdGNoIGNoYW5nZXMgd3Jtc3JsKCkgY2FsbHMgdG8gd3JpdGUgdG8gTVNSX1A2 X0VWVFNFTCByZWdpc3RlciBpbiB0aGUKPiBWUE1VIHRvIHdybXNyX3NhZmUoKS4gVGhlcmUgYXJl IGtub3duIChhbmQgcG9zc2libHkgc29tZSB1bmtub3duKSBjYXNlcyB3aGVyZQo+IHNldHRpbmcg Y2VydGFpbiBiaXRzIGluIE1TUl9QNl9FVlRTRUwgcmVnLiBjYW4gY2F1c2UgYSBHZW5lcmFsIFBy b3RlY3Rpb24KPiBmYXVsdCBvbiBzb21lIG1hY2hpbmVzLiBVbmxlc3Mgd2UgY2F0Y2ggdGhpcyBm YXVsdCB3aGVuIGl0IGhhcHBlbnMsIGl0IHdpbGwKPiByZXN1bHQgaW4gYSBoeXBlcnZpc29yIGNy YXNoLgo+IAo+IEZvciBpbnN0YW5jZSwgc2V0dGluZyBQaW4gQ29udHJvbCAoUEMpIGJpdCAoMTkp IGluIE1TUl9QNl9FVk5UU0VMIHJlc3VsdHMKPiBpbiBhIEdlbmVyYWwgUHJvdGVjdGlvbiBGYXVs dCBvbiBCcm9hZHdlbGwgbWFjaGluZXMgYW5kIHRodXMgY2F1c2VzIHRoZQo+IGh5cGVydmlzb3Ig dG8gY3Jhc2guCgpJIGNhbid0IHNlZW0gdG8gZmluZCBpbmRpY2F0aW9uIG9mIHRoaXMgaW4gdGhl IFNETS4gSXMgdGhpcyByZW1vdmFsIG9mIGEKdmFsaWQgYml0IGZyb20gYW4gYXJjaGl0ZWN0dXJh bCBNU1IgZG9jdW1lbnRlZCBhbnl3aGVyZT8KCj4gQEAgLTM1Niw3ICszNTYsOSBAQCBzdGF0aWMg aW5saW5lIHZvaWQgX19jb3JlMl92cG11X2xvYWQoc3RydWN0IHZjcHUgKnYpCj4gICAgICBmb3Ig KCBpID0gMDsgaSA8IGFyY2hfcG1jX2NudDsgaSsrICkKPiAgICAgIHsKPiAgICAgICAgICB3cm1z cmwocG1jX3N0YXJ0ICsgaSwgeGVuX3BtdV9jbnRyX3BhaXJbaV0uY291bnRlcik7Cj4gLSAgICAg ICAgd3Jtc3JsKE1TUl9QNl9FVk5UU0VMKGkpLCB4ZW5fcG11X2NudHJfcGFpcltpXS5jb250cm9s KTsKPiArICAgICAgICBpZiAoIHdybXNyX3NhZmUoTVNSX1A2X0VWTlRTRUwoaSksIHhlbl9wbXVf Y250cl9wYWlyW2ldLmNvbnRyb2wpID09Cj4gKyAgICAgICAgICAgICAgICAtRUZBVUxUKQo+ICsg ICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsKCklmIHRoZSBmdW5jdGlvbiBhbHJlYWR5IHJldHVy bnMgYW4gZXJyb3IgY29kZSwgcGxlYXNlIHVzZSBpdCB0byBhdm9pZAphIGxhdGVudCBidWcgd2hl biBpbiB0aGUgZnV0dXJlIGl0IG1heSBhbHNvIHJldHVybiBvdGhlciB0aGFuIC1FRkFVTFQuCgo+ IEBAIC0zNjksNiArMzcxLDcgQEAgc3RhdGljIGlubGluZSB2b2lkIF9fY29yZTJfdnBtdV9sb2Fk KHN0cnVjdCB2Y3B1ICp2KQo+ICAgICAgICAgIGNvcmUyX3ZwbXVfY3h0LT5nbG9iYWxfb3ZmX2N0 cmwgPSAwOwo+ICAgICAgICAgIHdybXNybChNU1JfQ09SRV9QRVJGX0dMT0JBTF9DVFJMLCBjb3Jl Ml92cG11X2N4dC0+Z2xvYmFsX2N0cmwpOwo+ICAgICAgfQo+ICsgICAgcmV0dXJuIDA7CgpCbGFu ayBsaW5lIGFib3ZlIHRoZSBtYWluIHJldHVybiBzdGF0ZW1lbnQgb2YgYSBmdW5jdGlvbiBwbGVh c2UuCgo+IEBAIC00NjEsOSArNDY0LDggQEAgc3RhdGljIGludCBjb3JlMl92cG11X2xvYWQoc3Ry dWN0IHZjcHUgKnYsIGJvb2xfdCAKPiBmcm9tX2d1ZXN0KQo+ICAKPiAgICAgIHZwbXVfc2V0KHZw bXUsIFZQTVVfQ09OVEVYVF9MT0FERUQpOwo+ICAKPiAtICAgIF9fY29yZTJfdnBtdV9sb2FkKHYp Owo+ICsgICAgcmV0dXJuIF9fY29yZTJfdnBtdV9sb2FkKHYpOwo+ICAKPiAtICAgIHJldHVybiAw Owo+ICB9CgpQbGVhc2UgYWxzbyByZW1vdmUgdGhlIG5vdyBzdHJheSBibGFuayBsaW5lLgoKPiBA QCAtNTM4LDcgKzU0MCw4IEBAIHN0YXRpYyBpbnQgY29yZTJfdnBtdV9tc3JfY29tbW9uX2NoZWNr KHUzMiBtc3JfaW5kZXgsIGludCAqdHlwZSwgaW50ICppbmRleCkKPiAgICAgIC8qIERvIHRoZSBs YXp5IGxvYWQgc3RhZmYuICovCj4gICAgICBpZiAoICF2cG11X2lzX3NldCh2cG11LCBWUE1VX0NP TlRFWFRfTE9BREVEKSApCj4gICAgICB7Cj4gLSAgICAgICAgX19jb3JlMl92cG11X2xvYWQoY3Vy cmVudCk7Cj4gKyAgICAgICAgaWYgKCBfX2NvcmUyX3ZwbXVfbG9hZChjdXJyZW50KSApCj4gKyAg ICAgICAgICAgIHJldHVybiAwOwoKTm90aGluZyB5b3UgbmVlZCB0byBjaGFuZ2UsIGJ1dCB0aGUg Y2hhbmdlIGhlcmUgcG9pbnQgb3V0IHRoYXQKdGhlIGZ1bmN0aW9uIHJlYWxseSBuZWVkcyBzd2l0 Y2hpbmcgdG8gcmV0dXJuaW5nIGJvb2wuCgo+IEBAIC03MTksOCArNzIyLDExIEBAIHN0YXRpYyBp bnQgY29yZTJfdnBtdV9kb193cm1zcih1bnNpZ25lZCBpbnQgbXNyLCB1aW50NjRfdCBtc3JfY29u dGVudCwKPiAgICAgICAgICB9Cj4gICAgICB9Cj4gIAo+IC0gICAgaWYgKCB0eXBlICE9IE1TUl9U WVBFX0dMT0JBTCApCj4gLSAgICAgICAgd3Jtc3JsKG1zciwgbXNyX2NvbnRlbnQpOwo+ICsgICAg aWYgKCB0eXBlICE9IE1TUl9UWVBFX0dMT0JBTCkKPiArICAgIHsKPiArICAgICAgICBpZiAoIHdy bXNyX3NhZmUobXNyLCBtc3JfY29udGVudCkgPT0gLUVGQVVMVCApCj4gKyAgICAgICAgICAgIHJl dHVybiAtRUZBVUxUOwoKU2VlIHRoZSBlYXJsaWVyIHNpbWlsYXIgY29tbWVudC4KCkZ1cnRoZXIg YSBtb3JlIGdlbmVyYWwgcXVlc3Rpb246IFdoeSBkbyB5b3UgZG8gdGhpcyBvbmx5IGZvcgpNU1Jf UDZfRVZOVFNFTCosIGJ1dCBub3QgY29uc2lzdGVudGx5IGZvciBhbGwgTVNScyB3aGljaCBhcmUK YmVpbmcgd3JpdHRlbiB3aXRoIChwYXJ0aWFsbHkpIGd1ZXN0IGNvbnRyb2xsZWQgdmFsdWVzPyBJ J2QgbmFtZWx5CmV4cGVjdCBhbGwgd3Jtc3JsKCkgdG8gYmUgc3dpdGNoZWQgb3ZlciwgdW5sZXNz IGl0IGlzIGNsZWFyIHRoYXQKd2UncmUgZGVhbGluZyB3aXRoIGFuIGVycmF0dW0gaGVyZSBhbmQg d2UgdGhlcmVmb3JlIGNhbgphc3N1bWUgdGhhdCBub3JtYWwgZ3VhcmFudGVlcyBmb3IgYXJjaGl0 ZWN0dXJhbCBNU1JzIGFwcGx5IHRvCmV2ZXJ5dGhpbmcgZWxzZS4KCkFuZCBmaW5hbGx5LCBpbiB0 aGUgZGVzY3JpcHRpb24geW91IHRhbGsgYWJvdXQgZm9yd2FyZGluZyB0aGUKZmF1bHQgLSBJIGNh biBzZWUgdGhpcyBiZWluZyB0aGUgY2FzZSBmb3IgY29yZTJfdnBtdV9kb193cm1zcigpLApidXQg aG93IGRvZXMgdGhpcyBtYXRjaCB1cCB3aXRoIF9fY29yZTJfdnBtdV9sb2FkKCkgYW5kIGl0cwpj YWxsZXJzPyBOYW1lbHkgeW91IG1heSByZXBvcnQgYW4gZXJyb3IgdGhlcmUgYWZ0ZXIgYWxyZWFk eQpoYXZpbmcgdXBkYXRlZCBzb21lIE1TUnMuIExlYXZpbmcgdGhlIG92ZXJhbGwgc2V0IG9mIE1T UnMgaW4KYW4gaW5jb25zaXN0ZW50IHN0YXRlIGlzIG5vdCB2ZXJ5IGxpa2VseSB0byBiZSBhIGdv b2QgaWRlYS4KCkphbgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0 cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=