Re: [dpdk-dev] [PATCH v7 1/3] ethdev: add actions to modify TCP header fields

[Andrew Rybchenko <arybchenko@solarflare.com>]

On 6/27/19 8:39 PM, Dekel Peled wrote:
> Add actions:
> - INC_TCP_SEQ - Increase sequence number in the outermost TCP header.
> - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header.
> - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP
> 		header.
> - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP
> 		header.
>
> Original work by Xiaoyu Min.
>
> This patch introduces a new approach, using a simple integer instead
> of using an action-specific structure for each of these actions.
> This approach can be later applied to modify existing actions which
> require only a single integer.

If we allow it, may be we should fix at least experimental API and
remove dummy structures.

I think ideally it should be a pre-patch which allows to avoid structures.
Right now it is a mixture of two logical changes.

> Signed-off-by: Dekel Peled <dekelp@mellanox.com>

A nit below (plus above), other than that
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>


[...]

> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index f3a8fb1..8c962d0 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -1650,6 +1650,46 @@ enum rte_flow_action_type {
>   	 * See struct rte_flow_action_set_mac.
>   	 */
>   	RTE_FLOW_ACTION_TYPE_SET_MAC_DST,
> +
> +	/**
> +	 * Increase sequence number in the outermost TCP header.
> +	 *
> +	 * Using this action on non-matching traffic will result in
> +	 * undefined behavior.
> +	 *
> +	 * See struct rte_flow_integer_action.

There is no  rte_flow_integer_action, please, fix.

[...]