From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D884C433EF for ; Thu, 9 Jun 2022 13:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238572AbiFINH5 (ORCPT ); Thu, 9 Jun 2022 09:07:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237515AbiFINHp (ORCPT ); Thu, 9 Jun 2022 09:07:45 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC07A85EE4; Thu, 9 Jun 2022 06:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1654780062; x=1686316062; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PTrfA4+QXjPYtg7WES29RLAhtkp56K5doQjbZoUFJhE=; b=jNsOoN3zr0VsoaCsDIUIirWSxEpEmyil8DZK4060SeD1KHnHYlZQgRkW 01GRR4LJq9QBdRHDxtSzfT4AxAs3CuLKQRuJyYbpH6Lg2qzT0tMxMCGa0 HQJzKPLN6mTymJSM95TQqGXW7jW0Vn/mERVG5cSYm04oJ7xKaHL1UTTiF M=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-02.qualcomm.com with ESMTP; 09 Jun 2022 06:07:41 -0700 X-QCInternal: smtphost Received: from unknown (HELO nasanex01a.na.qualcomm.com) ([10.52.223.231]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 06:07:41 -0700 Received: from [10.242.59.11] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 9 Jun 2022 06:07:37 -0700 Message-ID: <58c87a74-52e3-1133-f5cc-56c098f0273e@quicinc.com> Date: Thu, 9 Jun 2022 18:37:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V5] arm64: perf: Make exporting of pmu events configurable Content-Language: en-US To: Will Deacon CC: , , , , , , , , , , References: <1653306574-20946-1-git-send-email-quic_c_spathi@quicinc.com> <20220609100247.GA2187@willie-the-truck> <4f5dbc00-e25b-f6ff-8585-31fc50f48a21@quicinc.com> <20220609113225.GA2326@willie-the-truck> From: Srinivasarao Pathipati In-Reply-To: <20220609113225.GA2326@willie-the-truck> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/2022 5:02 PM, Will Deacon wrote: > [Please don't top-post] > > On Thu, Jun 09, 2022 at 04:05:20PM +0530, Srinivasarao Pathipati wrote: >> On 6/9/2022 3:32 PM, Will Deacon wrote: >>> On Mon, May 23, 2022 at 05:19:34PM +0530, Srinivasarao Pathipati wrote: >>>> The PMU export bit (PMCR_EL0.X) is getting reset during pmu reset, >>>> Make is configurable using sysctls to enable/disable at runtime. >>>> It can also be enabled at early bootup with kernel arguments. >>>> >>>> Signed-off-by: Srinivasarao Pathipati >>>> --- >>>> Changes since V4: >>>> - Registering sysctls dynamically for only arm64 as suggested by Will >>>> - Not removed the code to configure with kernel parameters >>>> as the sysctl's kernel parameter(sysctl.kernel.export_pmu_events) >>>> is not working at early bootup. pmu_reset() getting called before >>>> sysctl's kernel parameter is set. >>> Why do you need this during early bootup? Perf won't program any events >>> until much later and if somebody else is configuring the PMU before >>> entering Linux then they can also set that X bit in the PMCR. >> On our Qualcomm platforms, The X bit is getting set by firmware at early >> bootup for Qualcomm use cases >> and non-secure world is resetting it, that causing issue. > What "Qualcomm use cases" and why should we care about them upstream? Thanks Will & Robin for your inputs . Understood your point ,  pushed next version [V6] after removing kernel parameters code. > > Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C42EC433EF for ; Thu, 9 Jun 2022 13:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fDVCnzSk9cwHRikUEKaY2zE5EQeHMVhetZyxhK9NRwk=; b=NY0Vzd64N8h6B+ 7NVFa93+UHHJHxkIJ5VV/qzFHbfaA0DDtJIMtCYQojnTxRTlHd4+0Qojq7VJKDkaPTf1bosIjq2sK Ax1lWqDViy+6XdqrxFdqjUn2hRWI4823A4HZgfcIbl4zt0mBsG+Nf9Kc6PWq8Vttv4Lv2Ms2eS77i tZWPpMjvAfZKxlLiy2TwbTaHA8xltkcOWdvPsYzkOokfcL052mPmfM7//TVfLxgremeAsPeE8S6qS 7AXDqhv/H/a0nnjoYzt+YXuyaT+u8WfQqevCNY4C4Q9q77B5XEozJQ7C6g2Em9u8FxrTdg1cb7NhF mVF/+gLZ0sFX/3P0OUGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzHt4-001zdc-T2; Thu, 09 Jun 2022 13:07:47 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzHt1-001zcC-6d for linux-arm-kernel@lists.infradead.org; Thu, 09 Jun 2022 13:07:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1654780063; x=1686316063; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PTrfA4+QXjPYtg7WES29RLAhtkp56K5doQjbZoUFJhE=; b=KtvOtc4HIKu0wvPcKHmALcP2zaQk/vkFXSIbFDsDO4+na+11+eaClUQk UF1GoFBhjsNjdSs3gj8KOcRp4ER4bcfjMiXbIcnT9/YsfaICxND3uc80X j5bEhGAI7k2q0LDRRvqWEDnsgIFhIcU9dY8Dn7lDvFnXlvv1S9vR1r0fS Q=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 09 Jun 2022 06:07:41 -0700 X-QCInternal: smtphost Received: from unknown (HELO nasanex01a.na.qualcomm.com) ([10.52.223.231]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 06:07:41 -0700 Received: from [10.242.59.11] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 9 Jun 2022 06:07:37 -0700 Message-ID: <58c87a74-52e3-1133-f5cc-56c098f0273e@quicinc.com> Date: Thu, 9 Jun 2022 18:37:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V5] arm64: perf: Make exporting of pmu events configurable Content-Language: en-US To: Will Deacon CC: , , , , , , , , , , References: <1653306574-20946-1-git-send-email-quic_c_spathi@quicinc.com> <20220609100247.GA2187@willie-the-truck> <4f5dbc00-e25b-f6ff-8585-31fc50f48a21@quicinc.com> <20220609113225.GA2326@willie-the-truck> From: Srinivasarao Pathipati In-Reply-To: <20220609113225.GA2326@willie-the-truck> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_060743_322757_553722B1 X-CRM114-Status: GOOD ( 10.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDYvOS8yMDIyIDU6MDIgUE0sIFdpbGwgRGVhY29uIHdyb3RlOgo+IFtQbGVhc2UgZG9uJ3Qg dG9wLXBvc3RdCj4KPiBPbiBUaHUsIEp1biAwOSwgMjAyMiBhdCAwNDowNToyMFBNICswNTMwLCBT cmluaXZhc2FyYW8gUGF0aGlwYXRpIHdyb3RlOgo+PiBPbiA2LzkvMjAyMiAzOjMyIFBNLCBXaWxs IERlYWNvbiB3cm90ZToKPj4+IE9uIE1vbiwgTWF5IDIzLCAyMDIyIGF0IDA1OjE5OjM0UE0gKzA1 MzAsIFNyaW5pdmFzYXJhbyBQYXRoaXBhdGkgd3JvdGU6Cj4+Pj4gVGhlIFBNVSBleHBvcnQgYml0 IChQTUNSX0VMMC5YKSBpcyBnZXR0aW5nIHJlc2V0IGR1cmluZyBwbXUgcmVzZXQsCj4+Pj4gTWFr ZSBpcyBjb25maWd1cmFibGUgdXNpbmcgc3lzY3RscyB0byBlbmFibGUvZGlzYWJsZSBhdCBydW50 aW1lLgo+Pj4+IEl0IGNhbiBhbHNvIGJlIGVuYWJsZWQgYXQgZWFybHkgYm9vdHVwIHdpdGgga2Vy bmVsIGFyZ3VtZW50cy4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IFNyaW5pdmFzYXJhbyBQYXRo aXBhdGkgPHF1aWNfY19zcGF0aGlAcXVpY2luYy5jb20+Cj4+Pj4gLS0tCj4+Pj4gQ2hhbmdlcyBz aW5jZSBWNDoKPj4+PiAJLSBSZWdpc3RlcmluZyBzeXNjdGxzIGR5bmFtaWNhbGx5IGZvciBvbmx5 IGFybTY0IGFzIHN1Z2dlc3RlZCBieSBXaWxsCj4+Pj4gCS0gTm90IHJlbW92ZWQgdGhlIGNvZGUg dG8gY29uZmlndXJlIHdpdGgga2VybmVsIHBhcmFtZXRlcnMKPj4+PiAJICBhcyB0aGUgc3lzY3Rs J3Mga2VybmVsIHBhcmFtZXRlcihzeXNjdGwua2VybmVsLmV4cG9ydF9wbXVfZXZlbnRzKQo+Pj4+ IAkgIGlzIG5vdCB3b3JraW5nIGF0IGVhcmx5IGJvb3R1cC4gcG11X3Jlc2V0KCkgZ2V0dGluZyBj YWxsZWQgYmVmb3JlCj4+Pj4gCSAgc3lzY3RsJ3Mga2VybmVsIHBhcmFtZXRlciBpcyBzZXQuCj4+ PiBXaHkgZG8geW91IG5lZWQgdGhpcyBkdXJpbmcgZWFybHkgYm9vdHVwPyBQZXJmIHdvbid0IHBy b2dyYW0gYW55IGV2ZW50cwo+Pj4gdW50aWwgbXVjaCBsYXRlciBhbmQgaWYgc29tZWJvZHkgZWxz ZSBpcyBjb25maWd1cmluZyB0aGUgUE1VIGJlZm9yZQo+Pj4gZW50ZXJpbmcgTGludXggdGhlbiB0 aGV5IGNhbiBhbHNvIHNldCB0aGF0IFggYml0IGluIHRoZSBQTUNSLgo+PiBPbiBvdXIgUXVhbGNv bW0gcGxhdGZvcm1zLCBUaGUgWCBiaXQgaXMgZ2V0dGluZyBzZXQgYnkgZmlybXdhcmUgYXQgZWFy bHkKPj4gYm9vdHVwIGZvciBRdWFsY29tbSB1c2UgY2FzZXMKPj4gYW5kIG5vbi1zZWN1cmUgd29y bGQgaXMgcmVzZXR0aW5nIGl0LCB0aGF0IGNhdXNpbmcgaXNzdWUuCj4gV2hhdCAiUXVhbGNvbW0g dXNlIGNhc2VzIiBhbmQgd2h5IHNob3VsZCB3ZSBjYXJlIGFib3V0IHRoZW0gdXBzdHJlYW0/CgpU aGFua3MgV2lsbCAmIFJvYmluIGZvciB5b3VyIGlucHV0cyAuCgpVbmRlcnN0b29kIHlvdXIgcG9p bnQgLMKgIHB1c2hlZCBuZXh0IHZlcnNpb24gW1Y2XSBhZnRlciByZW1vdmluZyBrZXJuZWwgCnBh cmFtZXRlcnMgY29kZS4KCj4KPiBXaWxsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==