From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752807AbeDSMbY (ORCPT ); Thu, 19 Apr 2018 08:31:24 -0400 Received: from mail.micronovasrl.com ([212.103.203.10]:56618 "EHLO mail.micronovasrl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752578AbeDSMbU (ORCPT ); Thu, 19 Apr 2018 08:31:20 -0400 Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com X-Spam-Flag: NO X-Spam-Score: -2.898 Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel To: Chen-Yu Tsai , Maxime Ripard , David Airlie , Thierry Reding , Rob Herring , Mark Rutland Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jonathan Liu References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> From: Giulio Benetti Message-ID: <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> Date: Thu, 19 Apr 2018 14:31:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180419093225.614-5-wens@csie.org> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: it Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Il 19/04/2018 11:32, Chen-Yu Tsai ha scritto: > This panel is marketed as Banana Pi 7" LCD display. On the back is > a sticker denoting the model name S070WV20-CT16. Judging from the code, the real vendor should be CDTech. Take a look at their website: http://www.cdtech-lcd.com/en/standardscreen.html I point you my patch for inserting another similar panel: https://patchwork.freedesktop.org/patch/211914/ Maybe it would make sense to use CDTech as the vendor, because maybe Bananapi resells only it. Or maybe it is a custom panel done for them, but the same is for other panels I've submitted patches. Micronova srl custom, but vendor is CDTech. What do you think? -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ¤ 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642 > > This is a 7" 800x480 panel connected through a 24-bit RGB interface. > However the panel only does 262k colors. > > Signed-off-by: Chen-Yu Tsai > --- > .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > new file mode 100644 > index 000000000000..2ec35ce36e9a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > @@ -0,0 +1,7 @@ > +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel > + > +Required properties: > +- compatible: should be "bananapi,s070wv20-ct16" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index cbf1ab404ee7..9bc037f74d6c 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -745,6 +745,28 @@ static const struct panel_desc avic_tm070ddh03 = { > }, > }; > > +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { > + .clock = 30000, > + .hdisplay = 800, > + .hsync_start = 800 + 40, > + .hsync_end = 800 + 40 + 48, > + .htotal = 800 + 40 + 48 + 40, > + .vdisplay = 480, > + .vsync_start = 480 + 13, > + .vsync_end = 480 + 13 + 3, > + .vtotal = 480 + 13 + 3 + 29, > +}; > + > +static const struct panel_desc bananapi_s070wv20_ct16 = { > + .modes = &bananapi_s070wv20_ct16_mode, > + .num_modes = 1, > + .bpc = 6, > + .size = { > + .width = 154, > + .height = 86, > + }, > +}; > + > static const struct drm_display_mode boe_nv101wxmn51_modes[] = { > { > .clock = 71900, > @@ -2112,6 +2134,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "avic,tm070ddh03", > .data = &avic_tm070ddh03, > + }, { > + .compatible = "bananapi,s070wv20-ct16", > + .data = &bananapi_s070wv20_ct16, > }, { > .compatible = "boe,nv101wxmn51", > .data = &boe_nv101wxmn51, > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Giulio Benetti Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel Date: Thu, 19 Apr 2018 14:31:13 +0200 Message-ID: <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180419093225.614-5-wens@csie.org> Content-Language: it List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai , Maxime Ripard , David Airlie , Thierry Reding , Rob Herring , Mark Rutland Cc: devicetree@vger.kernel.org, Jonathan Liu , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org SGksCgpJbCAxOS8wNC8yMDE4IDExOjMyLCBDaGVuLVl1IFRzYWkgaGEgc2NyaXR0bzoKPiBUaGlz IHBhbmVsIGlzIG1hcmtldGVkIGFzIEJhbmFuYSBQaSA3IiBMQ0QgZGlzcGxheS4gT24gdGhlIGJh Y2sgaXMKPiBhIHN0aWNrZXIgZGVub3RpbmcgdGhlIG1vZGVsIG5hbWUgUzA3MFdWMjAtQ1QxNi4K Ckp1ZGdpbmcgZnJvbSB0aGUgY29kZSwgdGhlIHJlYWwgdmVuZG9yIHNob3VsZCBiZSBDRFRlY2gu ClRha2UgYSBsb29rIGF0IHRoZWlyIHdlYnNpdGU6Cmh0dHA6Ly93d3cuY2R0ZWNoLWxjZC5jb20v ZW4vc3RhbmRhcmRzY3JlZW4uaHRtbAoKSSBwb2ludCB5b3UgbXkgcGF0Y2ggZm9yIGluc2VydGlu ZyBhbm90aGVyIHNpbWlsYXIgcGFuZWw6Cmh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9y Zy9wYXRjaC8yMTE5MTQvCgpNYXliZSBpdCB3b3VsZCBtYWtlIHNlbnNlIHRvIHVzZSBDRFRlY2gg YXMgdGhlIHZlbmRvciwKYmVjYXVzZSBtYXliZSBCYW5hbmFwaSByZXNlbGxzIG9ubHkgaXQuCk9y IG1heWJlIGl0IGlzIGEgY3VzdG9tIHBhbmVsIGRvbmUgZm9yIHRoZW0sCmJ1dCB0aGUgc2FtZSBp cyBmb3Igb3RoZXIgcGFuZWxzIEkndmUgc3VibWl0dGVkIHBhdGNoZXMuCk1pY3Jvbm92YSBzcmwg Y3VzdG9tLCBidXQgdmVuZG9yIGlzIENEVGVjaC4KCldoYXQgZG8geW91IHRoaW5rPwoKLS0gCkdp dWxpbyBCZW5ldHRpCkNUTwoKTUlDUk9OT1ZBIFNSTApTZWRlOiBWaWEgQS4gTmllZGRhIDMgLSAz NTAxMCBWaWdvbnphIChQRCkKVGVsLiAwNDkvODkzMTU2MyAtIEZheCAwNDkvODkzMTM0NgpDb2Qu RmlzY2FsZSAtIFAuSVZBIDAyNjYzNDIwMjg1CkNhcGl0YWxlIFNvY2lhbGUg4oKsIDI2LjAwMCBp LnYuCklzY3JpdHRhIGFsIFJlZy4gSW1wcmVzZSBkaSBQYWRvdmEgTi4gMDI2NjM0MjAyODUKTnVt ZXJvIFIuRS5BLiAyNTg2NDIKCj4gCj4gVGhpcyBpcyBhIDciIDgwMHg0ODAgcGFuZWwgY29ubmVj dGVkIHRocm91Z2ggYSAyNC1iaXQgUkdCIGludGVyZmFjZS4KPiBIb3dldmVyIHRoZSBwYW5lbCBv bmx5IGRvZXMgMjYyayBjb2xvcnMuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hlbi1ZdSBUc2FpIDx3 ZW5zQGNzaWUub3JnPgo+IC0tLQo+ICAgLi4uL2Rpc3BsYXkvcGFuZWwvYmFuYW5hcGksczA3MHd2 MjAtY3QxNi50eHQgIHwgIDcgKysrKysrCj4gICBkcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwt c2ltcGxlLmMgICAgICAgICAgfCAyNSArKysrKysrKysrKysrKysrKysrCj4gICAyIGZpbGVzIGNo YW5nZWQsIDMyIGluc2VydGlvbnMoKykKPiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9iYW5hbmFwaSxzMDcwd3YyMC1j dDE2LnR4dAo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvZGlzcGxheS9wYW5lbC9iYW5hbmFwaSxzMDcwd3YyMC1jdDE2LnR4dCBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL2JhbmFuYXBpLHMwNzB3djIwLWN0 MTYudHh0Cj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAuLjJlYzM1 Y2UzNmU5YQo+IC0tLSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvZGlzcGxheS9wYW5lbC9iYW5hbmFwaSxzMDcwd3YyMC1jdDE2LnR4dAo+IEBAIC0w LDAgKzEsNyBAQAo+ICtCYW5hbmEgUGkgNyIgKFMwNzBXVjIwLUNUMTYpIFRGVCBMQ0QgUGFuZWwK PiArCj4gK1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gKy0gY29tcGF0aWJsZTogc2hvdWxkIGJlICJi YW5hbmFwaSxzMDcwd3YyMC1jdDE2Igo+ICsKPiArVGhpcyBiaW5kaW5nIGlzIGNvbXBhdGlibGUg d2l0aCB0aGUgc2ltcGxlLXBhbmVsIGJpbmRpbmcsIHdoaWNoIGlzIHNwZWNpZmllZAo+ICtpbiBz aW1wbGUtcGFuZWwudHh0IGluIHRoaXMgZGlyZWN0b3J5Lgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFu ZWwtc2ltcGxlLmMKPiBpbmRleCBjYmYxYWI0MDRlZTcuLjliYzAzN2Y3NGQ2YyAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiBAQCAtNzQ1LDYgKzc0NSwyOCBAQCBzdGF0 aWMgY29uc3Qgc3RydWN0IHBhbmVsX2Rlc2MgYXZpY190bTA3MGRkaDAzID0gewo+ICAgCX0sCj4g ICB9Owo+ICAgCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSBiYW5hbmFw aV9zMDcwd3YyMF9jdDE2X21vZGUgPSB7Cj4gKwkuY2xvY2sgPSAzMDAwMCwKPiArCS5oZGlzcGxh eSA9IDgwMCwKPiArCS5oc3luY19zdGFydCA9IDgwMCArIDQwLAo+ICsJLmhzeW5jX2VuZCA9IDgw MCArIDQwICsgNDgsCj4gKwkuaHRvdGFsID0gODAwICsgNDAgKyA0OCArIDQwLAo+ICsJLnZkaXNw bGF5ID0gNDgwLAo+ICsJLnZzeW5jX3N0YXJ0ID0gNDgwICsgMTMsCj4gKwkudnN5bmNfZW5kID0g NDgwICsgMTMgKyAzLAo+ICsJLnZ0b3RhbCA9IDQ4MCArIDEzICsgMyArIDI5LAo+ICt9Owo+ICsK PiArc3RhdGljIGNvbnN0IHN0cnVjdCBwYW5lbF9kZXNjIGJhbmFuYXBpX3MwNzB3djIwX2N0MTYg PSB7Cj4gKwkubW9kZXMgPSAmYmFuYW5hcGlfczA3MHd2MjBfY3QxNl9tb2RlLAo+ICsJLm51bV9t b2RlcyA9IDEsCj4gKwkuYnBjID0gNiwKPiArCS5zaXplID0gewo+ICsJCS53aWR0aCA9IDE1NCwK PiArCQkuaGVpZ2h0ID0gODYsCj4gKwl9LAo+ICt9Owo+ICsKPiAgIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgZHJtX2Rpc3BsYXlfbW9kZSBib2VfbnYxMDF3eG1uNTFfbW9kZXNbXSA9IHsKPiAgIAl7Cj4g ICAJCS5jbG9jayA9IDcxOTAwLAo+IEBAIC0yMTEyLDYgKzIxMzQsOSBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IG9mX2RldmljZV9pZCBwbGF0Zm9ybV9vZl9tYXRjaFtdID0gewo+ICAgCX0sIHsKPiAg IAkJLmNvbXBhdGlibGUgPSAiYXZpYyx0bTA3MGRkaDAzIiwKPiAgIAkJLmRhdGEgPSAmYXZpY190 bTA3MGRkaDAzLAo+ICsJfSwgewo+ICsJCS5jb21wYXRpYmxlID0gImJhbmFuYXBpLHMwNzB3djIw LWN0MTYiLAo+ICsJCS5kYXRhID0gJmJhbmFuYXBpX3MwNzB3djIwX2N0MTYsCj4gICAJfSwgewo+ ICAgCQkuY29tcGF0aWJsZSA9ICJib2UsbnYxMDF3eG1uNTEiLAo+ICAgCQkuZGF0YSA9ICZib2Vf bnYxMDF3eG1uNTEsCj4gCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: giulio.benetti@micronovasrl.com (Giulio Benetti) Date: Thu, 19 Apr 2018 14:31:13 +0200 Subject: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel In-Reply-To: <20180419093225.614-5-wens@csie.org> References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> Message-ID: <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Il 19/04/2018 11:32, Chen-Yu Tsai ha scritto: > This panel is marketed as Banana Pi 7" LCD display. On the back is > a sticker denoting the model name S070WV20-CT16. Judging from the code, the real vendor should be CDTech. Take a look at their website: http://www.cdtech-lcd.com/en/standardscreen.html I point you my patch for inserting another similar panel: https://patchwork.freedesktop.org/patch/211914/ Maybe it would make sense to use CDTech as the vendor, because maybe Bananapi resells only it. Or maybe it is a custom panel done for them, but the same is for other panels I've submitted patches. Micronova srl custom, but vendor is CDTech. What do you think? -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642 > > This is a 7" 800x480 panel connected through a 24-bit RGB interface. > However the panel only does 262k colors. > > Signed-off-by: Chen-Yu Tsai > --- > .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > new file mode 100644 > index 000000000000..2ec35ce36e9a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > @@ -0,0 +1,7 @@ > +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel > + > +Required properties: > +- compatible: should be "bananapi,s070wv20-ct16" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index cbf1ab404ee7..9bc037f74d6c 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -745,6 +745,28 @@ static const struct panel_desc avic_tm070ddh03 = { > }, > }; > > +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { > + .clock = 30000, > + .hdisplay = 800, > + .hsync_start = 800 + 40, > + .hsync_end = 800 + 40 + 48, > + .htotal = 800 + 40 + 48 + 40, > + .vdisplay = 480, > + .vsync_start = 480 + 13, > + .vsync_end = 480 + 13 + 3, > + .vtotal = 480 + 13 + 3 + 29, > +}; > + > +static const struct panel_desc bananapi_s070wv20_ct16 = { > + .modes = &bananapi_s070wv20_ct16_mode, > + .num_modes = 1, > + .bpc = 6, > + .size = { > + .width = 154, > + .height = 86, > + }, > +}; > + > static const struct drm_display_mode boe_nv101wxmn51_modes[] = { > { > .clock = 71900, > @@ -2112,6 +2134,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "avic,tm070ddh03", > .data = &avic_tm070ddh03, > + }, { > + .compatible = "bananapi,s070wv20-ct16", > + .data = &bananapi_s070wv20_ct16, > }, { > .compatible = "boe,nv101wxmn51", > .data = &boe_nv101wxmn51, >