[PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

There is a spelling mistake in a en_err error message. Fix it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 6b88881b8e35..c1438ae52a11 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -3360,7 +3360,7 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
 	dev->addr_len = ETH_ALEN;
 	mlx4_en_u64_to_mac(dev->dev_addr, mdev->dev->caps.def_mac[priv->port]);
 	if (!is_valid_ether_addr(dev->dev_addr)) {
-		en_err(priv, "Port: %d, invalid mac burned: %pM, quiting\n",
+		en_err(priv, "Port: %d, invalid mac burned: %pM, quitting\n",
 		       priv->port, dev->dev_addr);
 		err = -EINVAL;
 		goto out;
-- 
2.20.1

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[Tariq Toukan]

On 2/18/2019 1:03 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There is a spelling mistake in a en_err error message. Fix it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> index 6b88881b8e35..c1438ae52a11 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> @@ -3360,7 +3360,7 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
>   	dev->addr_len = ETH_ALEN;
>   	mlx4_en_u64_to_mac(dev->dev_addr, mdev->dev->caps.def_mac[priv->port]);
>   	if (!is_valid_ether_addr(dev->dev_addr)) {
> -		en_err(priv, "Port: %d, invalid mac burned: %pM, quiting\n",
> +		en_err(priv, "Port: %d, invalid mac burned: %pM, quitting\n",
>   		       priv->port, dev->dev_addr);
>   		err = -EINVAL;
>   		goto out;
> 

Hi Colin, thanks for your patch.

Reviewed-by: Tariq Toukan <tariqt@mellanox.com>

I would suggest adding a Fixes line, but looking into the history of the 
typo, it went through many patches that modified this line but preserved 
the typo.
Actually, it dates back to the very first commit that introduces mlx4 
driver:

Patches history:
2b3ddf27f48c net/mlx4_core: Replace VF zero mac with random mac in mlx4_core
ef96f7d46ad8 net/mlx4_en: Handle unassigned VF MAC address correctly
6bbb6d99f3d2 net/mlx4_en: Optimize Rx fast path filter checks
453a60827735 mlx4_en: Giving interface name in debug messages
c27a02cd94d6 mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC

I'm not sure what the "Fixes:" policy is in these cases.

Thanks,
Tariq

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[Tariq Toukan]

DQoNCk9uIDIvMTgvMjAxOSAxOjAzIEFNLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBGcm9tOiBDb2xp
biBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gVGhlcmUgaXMgYSBz
cGVsbGluZyBtaXN0YWtlIGluIGEgZW5fZXJyIGVycm9yIG1lc3NhZ2UuIEZpeCBpdC4NCj4gDQo+
IFNpZ25lZC1vZmYtYnk6IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+
DQo+IC0tLQ0KPiAgIGRyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDQvZW5fbmV0ZGV2
LmMgfCAyICstDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9u
KC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4
NC9lbl9uZXRkZXYuYyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDQvZW5fbmV0
ZGV2LmMNCj4gaW5kZXggNmI4ODg4MWI4ZTM1Li5jMTQzOGFlNTJhMTEgMTAwNjQ0DQo+IC0tLSBh
L2RyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDQvZW5fbmV0ZGV2LmMNCj4gKysrIGIv
ZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4NC9lbl9uZXRkZXYuYw0KPiBAQCAtMzM2
MCw3ICszMzYwLDcgQEAgaW50IG1seDRfZW5faW5pdF9uZXRkZXYoc3RydWN0IG1seDRfZW5fZGV2
ICptZGV2LCBpbnQgcG9ydCwNCj4gICAJZGV2LT5hZGRyX2xlbiA9IEVUSF9BTEVOOw0KPiAgIAlt
bHg0X2VuX3U2NF90b19tYWMoZGV2LT5kZXZfYWRkciwgbWRldi0+ZGV2LT5jYXBzLmRlZl9tYWNb
cHJpdi0+cG9ydF0pOw0KPiAgIAlpZiAoIWlzX3ZhbGlkX2V0aGVyX2FkZHIoZGV2LT5kZXZfYWRk
cikpIHsNCj4gLQkJZW5fZXJyKHByaXYsICJQb3J0OiAlZCwgaW52YWxpZCBtYWMgYnVybmVkOiAl
cE0sIHF1aXRpbmdcbiIsDQo+ICsJCWVuX2Vycihwcml2LCAiUG9ydDogJWQsIGludmFsaWQgbWFj
IGJ1cm5lZDogJXBNLCBxdWl0dGluZ1xuIiwNCj4gICAJCSAgICAgICBwcml2LT5wb3J0LCBkZXYt
PmRldl9hZGRyKTsNCj4gICAJCWVyciA9IC1FSU5WQUw7DQo+ICAgCQlnb3RvIG91dDsNCj4gDQoN
CkhpIENvbGluLCB0aGFua3MgZm9yIHlvdXIgcGF0Y2guDQoNClJldmlld2VkLWJ5OiBUYXJpcSBU
b3VrYW4gPHRhcmlxdEBtZWxsYW5veC5jb20+DQoNCkkgd291bGQgc3VnZ2VzdCBhZGRpbmcgYSBG
aXhlcyBsaW5lLCBidXQgbG9va2luZyBpbnRvIHRoZSBoaXN0b3J5IG9mIHRoZSANCnR5cG8sIGl0
IHdlbnQgdGhyb3VnaCBtYW55IHBhdGNoZXMgdGhhdCBtb2RpZmllZCB0aGlzIGxpbmUgYnV0IHBy
ZXNlcnZlZCANCnRoZSB0eXBvLg0KQWN0dWFsbHksIGl0IGRhdGVzIGJhY2sgdG8gdGhlIHZlcnkg
Zmlyc3QgY29tbWl0IHRoYXQgaW50cm9kdWNlcyBtbHg0IA0KZHJpdmVyOg0KDQpQYXRjaGVzIGhp
c3Rvcnk6DQoyYjNkZGYyN2Y0OGMgbmV0L21seDRfY29yZTogUmVwbGFjZSBWRiB6ZXJvIG1hYyB3
aXRoIHJhbmRvbSBtYWMgaW4gbWx4NF9jb3JlDQplZjk2ZjdkNDZhZDggbmV0L21seDRfZW46IEhh
bmRsZSB1bmFzc2lnbmVkIFZGIE1BQyBhZGRyZXNzIGNvcnJlY3RseQ0KNmJiYjZkOTlmM2QyIG5l
dC9tbHg0X2VuOiBPcHRpbWl6ZSBSeCBmYXN0IHBhdGggZmlsdGVyIGNoZWNrcw0KNDUzYTYwODI3
NzM1IG1seDRfZW46IEdpdmluZyBpbnRlcmZhY2UgbmFtZSBpbiBkZWJ1ZyBtZXNzYWdlcw0KYzI3
YTAyY2Q5NGQ2IG1seDRfZW46IEFkZCBkcml2ZXIgZm9yIE1lbGxhbm94IENvbm5lY3RYIDEwR2JF
IE5JQw0KDQpJJ20gbm90IHN1cmUgd2hhdCB0aGUgIkZpeGVzOiIgcG9saWN5IGlzIGluIHRoZXNl
IGNhc2VzLg0KDQpUaGFua3MsDQpUYXJpcQ0K

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[Dan Carpenter]

On Mon, Feb 18, 2019 at 09:37:22AM +0000, Tariq Toukan wrote:
> 
> 
> On 2/18/2019 1:03 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > There is a spelling mistake in a en_err error message. Fix it.
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >   drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> > index 6b88881b8e35..c1438ae52a11 100644
> > --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> > +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> > @@ -3360,7 +3360,7 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
> >   	dev->addr_len = ETH_ALEN;
> >   	mlx4_en_u64_to_mac(dev->dev_addr, mdev->dev->caps.def_mac[priv->port]);
> >   	if (!is_valid_ether_addr(dev->dev_addr)) {
> > -		en_err(priv, "Port: %d, invalid mac burned: %pM, quiting\n",
> > +		en_err(priv, "Port: %d, invalid mac burned: %pM, quitting\n",
> >   		       priv->port, dev->dev_addr);
> >   		err = -EINVAL;
> >   		goto out;
> > 
> 
> Hi Colin, thanks for your patch.
> 
> Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
> 
> I would suggest adding a Fixes line, but looking into the history of the 
> typo, it went through many patches that modified this line but preserved 
> the typo.
> Actually, it dates back to the very first commit that introduces mlx4 
> driver:
> 
> Patches history:
> 2b3ddf27f48c net/mlx4_core: Replace VF zero mac with random mac in mlx4_core
> ef96f7d46ad8 net/mlx4_en: Handle unassigned VF MAC address correctly
> 6bbb6d99f3d2 net/mlx4_en: Optimize Rx fast path filter checks
> 453a60827735 mlx4_en: Giving interface name in debug messages
> c27a02cd94d6 mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC
> 
> I'm not sure what the "Fixes:" policy is in these cases.

I wouldn't necessarily put a Fixes tag on this, because does fixing the
spelling really count as a bugfix?  It's borderline whether it's a fix
or a cleanup.

regards,
daan carpenter

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[Dan Carpenter]

On Mon, Feb 18, 2019 at 09:37:22AM +0000, Tariq Toukan wrote:
> 
> 
> On 2/18/2019 1:03 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > There is a spelling mistake in a en_err error message. Fix it.
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >   drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> > index 6b88881b8e35..c1438ae52a11 100644
> > --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> > +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> > @@ -3360,7 +3360,7 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
> >   	dev->addr_len = ETH_ALEN;
> >   	mlx4_en_u64_to_mac(dev->dev_addr, mdev->dev->caps.def_mac[priv->port]);
> >   	if (!is_valid_ether_addr(dev->dev_addr)) {
> > -		en_err(priv, "Port: %d, invalid mac burned: %pM, quiting\n",
> > +		en_err(priv, "Port: %d, invalid mac burned: %pM, quitting\n",
> >   		       priv->port, dev->dev_addr);
> >   		err = -EINVAL;
> >   		goto out;
> > 
> 
> Hi Colin, thanks for your patch.
> 
> Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
> 
> I would suggest adding a Fixes line, but looking into the history of the 
> typo, it went through many patches that modified this line but preserved 
> the typo.
> Actually, it dates back to the very first commit that introduces mlx4 
> driver:
> 
> Patches history:
> 2b3ddf27f48c net/mlx4_core: Replace VF zero mac with random mac in mlx4_core
> ef96f7d46ad8 net/mlx4_en: Handle unassigned VF MAC address correctly
> 6bbb6d99f3d2 net/mlx4_en: Optimize Rx fast path filter checks
> 453a60827735 mlx4_en: Giving interface name in debug messages
> c27a02cd94d6 mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC
> 
> I'm not sure what the "Fixes:" policy is in these cases.

I wouldn't necessarily put a Fixes tag on this, because does fixing the
spelling really count as a bugfix?  It's borderline whether it's a fix
or a cleanup.

regards,
daan carpenter

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[Tariq Toukan]

On 2/18/2019 12:25 PM, Dan Carpenter wrote:
> On Mon, Feb 18, 2019 at 09:37:22AM +0000, Tariq Toukan wrote:
>>
>>
>> On 2/18/2019 1:03 AM, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> There is a spelling mistake in a en_err error message. Fix it.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>>    drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
>>> index 6b88881b8e35..c1438ae52a11 100644
>>> --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
>>> +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
>>> @@ -3360,7 +3360,7 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
>>>    	dev->addr_len = ETH_ALEN;
>>>    	mlx4_en_u64_to_mac(dev->dev_addr, mdev->dev->caps.def_mac[priv->port]);
>>>    	if (!is_valid_ether_addr(dev->dev_addr)) {
>>> -		en_err(priv, "Port: %d, invalid mac burned: %pM, quiting\n",
>>> +		en_err(priv, "Port: %d, invalid mac burned: %pM, quitting\n",
>>>    		       priv->port, dev->dev_addr);
>>>    		err = -EINVAL;
>>>    		goto out;
>>>
>>
>> Hi Colin, thanks for your patch.
>>
>> Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
>>
>> I would suggest adding a Fixes line, but looking into the history of the
>> typo, it went through many patches that modified this line but preserved
>> the typo.
>> Actually, it dates back to the very first commit that introduces mlx4
>> driver:
>>
>> Patches history:
>> 2b3ddf27f48c net/mlx4_core: Replace VF zero mac with random mac in mlx4_core
>> ef96f7d46ad8 net/mlx4_en: Handle unassigned VF MAC address correctly
>> 6bbb6d99f3d2 net/mlx4_en: Optimize Rx fast path filter checks
>> 453a60827735 mlx4_en: Giving interface name in debug messages
>> c27a02cd94d6 mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC
>>
>> I'm not sure what the "Fixes:" policy is in these cases.
> 
> I wouldn't necessarily put a Fixes tag on this, because does fixing the
> spelling really count as a bugfix?  It's borderline whether it's a fix
> or a cleanup.
> 
> regards,
> daan carpenter
> 

Thanks Dan, I'm fine with that.

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[Tariq Toukan]

DQoNCk9uIDIvMTgvMjAxOSAxMjoyNSBQTSwgRGFuIENhcnBlbnRlciB3cm90ZToNCj4gT24gTW9u
LCBGZWIgMTgsIDIwMTkgYXQgMDk6Mzc6MjJBTSArMDAwMCwgVGFyaXEgVG91a2FuIHdyb3RlOg0K
Pj4NCj4+DQo+PiBPbiAyLzE4LzIwMTkgMTowMyBBTSwgQ29saW4gS2luZyB3cm90ZToNCj4+PiBG
cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPj4+DQo+Pj4g
VGhlcmUgaXMgYSBzcGVsbGluZyBtaXN0YWtlIGluIGEgZW5fZXJyIGVycm9yIG1lc3NhZ2UuIEZp
eCBpdC4NCj4+Pg0KPj4+IFNpZ25lZC1vZmYtYnk6IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5n
QGNhbm9uaWNhbC5jb20+DQo+Pj4gLS0tDQo+Pj4gICAgZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVs
bGFub3gvbWx4NC9lbl9uZXRkZXYuYyB8IDIgKy0NCj4+PiAgICAxIGZpbGUgY2hhbmdlZCwgMSBp
bnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4+Pg0KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz
L25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg0L2VuX25ldGRldi5jIGIvZHJpdmVycy9uZXQvZXRo
ZXJuZXQvbWVsbGFub3gvbWx4NC9lbl9uZXRkZXYuYw0KPj4+IGluZGV4IDZiODg4ODFiOGUzNS4u
YzE0MzhhZTUyYTExIDEwMDY0NA0KPj4+IC0tLSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxh
bm94L21seDQvZW5fbmV0ZGV2LmMNCj4+PiArKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxs
YW5veC9tbHg0L2VuX25ldGRldi5jDQo+Pj4gQEAgLTMzNjAsNyArMzM2MCw3IEBAIGludCBtbHg0
X2VuX2luaXRfbmV0ZGV2KHN0cnVjdCBtbHg0X2VuX2RldiAqbWRldiwgaW50IHBvcnQsDQo+Pj4g
ICAgCWRldi0+YWRkcl9sZW4gPSBFVEhfQUxFTjsNCj4+PiAgICAJbWx4NF9lbl91NjRfdG9fbWFj
KGRldi0+ZGV2X2FkZHIsIG1kZXYtPmRldi0+Y2Fwcy5kZWZfbWFjW3ByaXYtPnBvcnRdKTsNCj4+
PiAgICAJaWYgKCFpc192YWxpZF9ldGhlcl9hZGRyKGRldi0+ZGV2X2FkZHIpKSB7DQo+Pj4gLQkJ
ZW5fZXJyKHByaXYsICJQb3J0OiAlZCwgaW52YWxpZCBtYWMgYnVybmVkOiAlcE0sIHF1aXRpbmdc
biIsDQo+Pj4gKwkJZW5fZXJyKHByaXYsICJQb3J0OiAlZCwgaW52YWxpZCBtYWMgYnVybmVkOiAl
cE0sIHF1aXR0aW5nXG4iLA0KPj4+ICAgIAkJICAgICAgIHByaXYtPnBvcnQsIGRldi0+ZGV2X2Fk
ZHIpOw0KPj4+ICAgIAkJZXJyID0gLUVJTlZBTDsNCj4+PiAgICAJCWdvdG8gb3V0Ow0KPj4+DQo+
Pg0KPj4gSGkgQ29saW4sIHRoYW5rcyBmb3IgeW91ciBwYXRjaC4NCj4+DQo+PiBSZXZpZXdlZC1i
eTogVGFyaXEgVG91a2FuIDx0YXJpcXRAbWVsbGFub3guY29tPg0KPj4NCj4+IEkgd291bGQgc3Vn
Z2VzdCBhZGRpbmcgYSBGaXhlcyBsaW5lLCBidXQgbG9va2luZyBpbnRvIHRoZSBoaXN0b3J5IG9m
IHRoZQ0KPj4gdHlwbywgaXQgd2VudCB0aHJvdWdoIG1hbnkgcGF0Y2hlcyB0aGF0IG1vZGlmaWVk
IHRoaXMgbGluZSBidXQgcHJlc2VydmVkDQo+PiB0aGUgdHlwby4NCj4+IEFjdHVhbGx5LCBpdCBk
YXRlcyBiYWNrIHRvIHRoZSB2ZXJ5IGZpcnN0IGNvbW1pdCB0aGF0IGludHJvZHVjZXMgbWx4NA0K
Pj4gZHJpdmVyOg0KPj4NCj4+IFBhdGNoZXMgaGlzdG9yeToNCj4+IDJiM2RkZjI3ZjQ4YyBuZXQv
bWx4NF9jb3JlOiBSZXBsYWNlIFZGIHplcm8gbWFjIHdpdGggcmFuZG9tIG1hYyBpbiBtbHg0X2Nv
cmUNCj4+IGVmOTZmN2Q0NmFkOCBuZXQvbWx4NF9lbjogSGFuZGxlIHVuYXNzaWduZWQgVkYgTUFD
IGFkZHJlc3MgY29ycmVjdGx5DQo+PiA2YmJiNmQ5OWYzZDIgbmV0L21seDRfZW46IE9wdGltaXpl
IFJ4IGZhc3QgcGF0aCBmaWx0ZXIgY2hlY2tzDQo+PiA0NTNhNjA4Mjc3MzUgbWx4NF9lbjogR2l2
aW5nIGludGVyZmFjZSBuYW1lIGluIGRlYnVnIG1lc3NhZ2VzDQo+PiBjMjdhMDJjZDk0ZDYgbWx4
NF9lbjogQWRkIGRyaXZlciBmb3IgTWVsbGFub3ggQ29ubmVjdFggMTBHYkUgTklDDQo+Pg0KPj4g
SSdtIG5vdCBzdXJlIHdoYXQgdGhlICJGaXhlczoiIHBvbGljeSBpcyBpbiB0aGVzZSBjYXNlcy4N
Cj4gDQo+IEkgd291bGRuJ3QgbmVjZXNzYXJpbHkgcHV0IGEgRml4ZXMgdGFnIG9uIHRoaXMsIGJl
Y2F1c2UgZG9lcyBmaXhpbmcgdGhlDQo+IHNwZWxsaW5nIHJlYWxseSBjb3VudCBhcyBhIGJ1Z2Zp
eD8gIEl0J3MgYm9yZGVybGluZSB3aGV0aGVyIGl0J3MgYSBmaXgNCj4gb3IgYSBjbGVhbnVwLg0K
PiANCj4gcmVnYXJkcywNCj4gZGFhbiBjYXJwZW50ZXINCj4gDQoNClRoYW5rcyBEYW4sIEknbSBm
aW5lIHdpdGggdGhhdC4NCg=

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[David Miller]

From: Colin King <colin.king@canonical.com>
Date: Sun, 17 Feb 2019 23:03:31 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> There is a spelling mistake in a en_err error message. Fix it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks Colin.

And I agree that this doesn't really deserve a Fixes: tag.

Fixes: tags should really be for changes that introduce truly
functional bugs.

And that could even be applied in this case _iff_ the string
was essential in some way for userland tools which parse the
output or similar.  But that is not the case here.

Anyways, thanks.

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[David Miller]

From: Colin King <colin.king@canonical.com>
Date: Sun, 17 Feb 2019 23:03:31 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> There is a spelling mistake in a en_err error message. Fix it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks Colin.

And I agree that this doesn't really deserve a Fixes: tag.

Fixes: tags should really be for changes that introduce truly
functional bugs.

And that could even be applied in this case _iff_ the string
was essential in some way for userland tools which parse the
output or similar.  But that is not the case here.

Anyways, thanks.

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[Tariq Toukan]

On 2/18/2019 10:08 PM, David Miller wrote:
> From: Colin King <colin.king@canonical.com>
> Date: Sun, 17 Feb 2019 23:03:31 +0000
> 
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a spelling mistake in a en_err error message. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Applied, thanks Colin.
> 
> And I agree that this doesn't really deserve a Fixes: tag.
> 
> Fixes: tags should really be for changes that introduce truly
> functional bugs.
> 
> And that could even be applied in this case _iff_ the string
> was essential in some way for userland tools which parse the
> output or similar.  But that is not the case here.
> 

Thanks for the clarification.

> Anyways, thanks.
> 

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

[Tariq Toukan]

DQoNCk9uIDIvMTgvMjAxOSAxMDowOCBQTSwgRGF2aWQgTWlsbGVyIHdyb3RlOg0KPiBGcm9tOiBD
b2xpbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+DQo+IERhdGU6IFN1biwgMTcgRmVi
IDIwMTkgMjM6MDM6MzEgKzAwMDANCj4gDQo+PiBGcm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4u
a2luZ0BjYW5vbmljYWwuY29tPg0KPj4NCj4+IFRoZXJlIGlzIGEgc3BlbGxpbmcgbWlzdGFrZSBp
biBhIGVuX2VyciBlcnJvciBtZXNzYWdlLiBGaXggaXQuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTog
Q29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCj4gDQo+IEFwcGxpZWQs
IHRoYW5rcyBDb2xpbi4NCj4gDQo+IEFuZCBJIGFncmVlIHRoYXQgdGhpcyBkb2Vzbid0IHJlYWxs
eSBkZXNlcnZlIGEgRml4ZXM6IHRhZy4NCj4gDQo+IEZpeGVzOiB0YWdzIHNob3VsZCByZWFsbHkg
YmUgZm9yIGNoYW5nZXMgdGhhdCBpbnRyb2R1Y2UgdHJ1bHkNCj4gZnVuY3Rpb25hbCBidWdzLg0K
PiANCj4gQW5kIHRoYXQgY291bGQgZXZlbiBiZSBhcHBsaWVkIGluIHRoaXMgY2FzZSBfaWZmXyB0
aGUgc3RyaW5nDQo+IHdhcyBlc3NlbnRpYWwgaW4gc29tZSB3YXkgZm9yIHVzZXJsYW5kIHRvb2xz
IHdoaWNoIHBhcnNlIHRoZQ0KPiBvdXRwdXQgb3Igc2ltaWxhci4gIEJ1dCB0aGF0IGlzIG5vdCB0
aGUgY2FzZSBoZXJlLg0KPiANCg0KVGhhbmtzIGZvciB0aGUgY2xhcmlmaWNhdGlvbi4NCg0KPiBB
bnl3YXlzLCB0aGFua3MuDQo+IA0K