Re: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs

[Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>]

2017年4月11日 15:03于 Viresh Kumar <viresh.kumar@linaro.org>写道：
>
> On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> wrote: 
> > Some new Allwinner SoCs get supported in the kernel after the 
> > compatibles are added to cpufreq-dt-platdev driver. 
> > 
> > Add their compatible strings in the cpufreq-dt-platdev driver. 
> > 
> > Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> 
> > --- 
> >  drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++ 
> >  1 file changed, 5 insertions(+) 
> > 
> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c 
> > index 921b4a6c3d16..2180e509e383 100644 
> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c 
> > @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = { 
> >         { .compatible = "allwinner,sun8i-a23", }, 
> >         { .compatible = "allwinner,sun8i-a33", }, 
> >         { .compatible = "allwinner,sun8i-a83t", }, 
> > +       { .compatible = "allwinner,sun8i-h2-plus", }, 
> >         { .compatible = "allwinner,sun8i-h3", }, 
> > +       { .compatible = "allwinner,sun8i-v3s", }, 
> > +       { .compatible = "allwinner,sun50i-a64", }, 
> > +       { .compatible = "allwinner,sun50i-h5", }, 
> > +       { .compatible = "nextthing,gr8", }, 
>
>
> This needs to be in alphabetical order and please cc cpufreq 

However I prefer these sequence -- sun50i is later than sun8i.

Place sun50i between sun4i and sun5i is meaningless, as sun50i in fact have a deep relationship with sun8i, but not sun4/5i.

> maintainers next time. 
>
> _______________________________________________ 
> linux-arm-kernel mailing list 
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org 
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel 

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.