All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate
@ 2018-01-20 12:07 Andreas Färber
  2018-01-21  9:08 ` Kostya Porotchkin
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Andreas Färber @ 2018-01-20 12:07 UTC (permalink / raw)
  To: u-boot

minicom doesn't inherit the baudrate from stty but uses its own
defaults, such as for example 57600, whereas we expect 115200 here.
Explicitly tell minicom which baudrate to use.

Fixes: eee4835d22 ("tools: Add Marvell recovery image download script")
Cc: Konstantin Porotchkin <kostap@marvell.com>
Cc: Stefan Roese <sr@denx.de>
Cc: Igal Liberman <igall@marvell.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 tools/mrvl_uart.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh
index 6b04d7ae2c..500fa117eb 100755
--- a/tools/mrvl_uart.sh
+++ b/tools/mrvl_uart.sh
@@ -115,5 +115,5 @@ sx -vv $file > $port < $port
 stty -F $port raw ignbrk time 5 $default_baudrate
 
 # Optional - fire up Minicom
-minicom -D $port
+minicom -D $port -b $default_baudrate
 
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate
  2018-01-20 12:07 [U-Boot] [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate Andreas Färber
@ 2018-01-21  9:08 ` Kostya Porotchkin
  2018-01-22  8:47 ` Stefan Roese
  2018-01-29 12:40 ` Stefan Roese
  2 siblings, 0 replies; 4+ messages in thread
From: Kostya Porotchkin @ 2018-01-21  9:08 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: Andreas Färber [mailto:afaerber at suse.de]
> Sent: Saturday, January 20, 2018 14:07
> To: u-boot at lists.denx.de
> Cc: Andreas Färber; Kostya Porotchkin; Stefan Roese; Igal Liberman
> Subject: [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate
> 
> minicom doesn't inherit the baudrate from stty but uses its own
> defaults, such as for example 57600, whereas we expect 115200 here.
> Explicitly tell minicom which baudrate to use.
> 
> Fixes: eee4835d22 ("tools: Add Marvell recovery image download script")
> Cc: Konstantin Porotchkin <kostap@marvell.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Igal Liberman <igall@marvell.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  tools/mrvl_uart.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh index
> 6b04d7ae2c..500fa117eb 100755
> --- a/tools/mrvl_uart.sh
> +++ b/tools/mrvl_uart.sh
> @@ -115,5 +115,5 @@ sx -vv $file > $port < $port  stty -F $port raw
> ignbrk time 5 $default_baudrate
> 
>  # Optional - fire up Minicom
> -minicom -D $port
> +minicom -D $port -b $default_baudrate
> 
> --
> 2.13.6
Reviewed-by: Konstantin Porotchkin <kostap@marvell.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate
  2018-01-20 12:07 [U-Boot] [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate Andreas Färber
  2018-01-21  9:08 ` Kostya Porotchkin
@ 2018-01-22  8:47 ` Stefan Roese
  2018-01-29 12:40 ` Stefan Roese
  2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2018-01-22  8:47 UTC (permalink / raw)
  To: u-boot

On 20.01.2018 13:07, Andreas Färber wrote:
> minicom doesn't inherit the baudrate from stty but uses its own
> defaults, such as for example 57600, whereas we expect 115200 here.
> Explicitly tell minicom which baudrate to use.
> 
> Fixes: eee4835d22 ("tools: Add Marvell recovery image download script")
> Cc: Konstantin Porotchkin <kostap@marvell.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Igal Liberman <igall@marvell.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>   tools/mrvl_uart.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh
> index 6b04d7ae2c..500fa117eb 100755
> --- a/tools/mrvl_uart.sh
> +++ b/tools/mrvl_uart.sh
> @@ -115,5 +115,5 @@ sx -vv $file > $port < $port
>   stty -F $port raw ignbrk time 5 $default_baudrate
>   
>   # Optional - fire up Minicom
> -minicom -D $port
> +minicom -D $port -b $default_baudrate
>   
> 

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate
  2018-01-20 12:07 [U-Boot] [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate Andreas Färber
  2018-01-21  9:08 ` Kostya Porotchkin
  2018-01-22  8:47 ` Stefan Roese
@ 2018-01-29 12:40 ` Stefan Roese
  2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2018-01-29 12:40 UTC (permalink / raw)
  To: u-boot

On 20.01.2018 13:07, Andreas Färber wrote:
> minicom doesn't inherit the baudrate from stty but uses its own
> defaults, such as for example 57600, whereas we expect 115200 here.
> Explicitly tell minicom which baudrate to use.
> 
> Fixes: eee4835d22 ("tools: Add Marvell recovery image download script")
> Cc: Konstantin Porotchkin <kostap@marvell.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Igal Liberman <igall@marvell.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>   tools/mrvl_uart.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh
> index 6b04d7ae2c..500fa117eb 100755
> --- a/tools/mrvl_uart.sh
> +++ b/tools/mrvl_uart.sh
> @@ -115,5 +115,5 @@ sx -vv $file > $port < $port
>   stty -F $port raw ignbrk time 5 $default_baudrate
>   
>   # Optional - fire up Minicom
> -minicom -D $port
> +minicom -D $port -b $default_baudrate
>   
> 

Applied to u-boot-marvell/master.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-01-29 12:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-20 12:07 [U-Boot] [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate Andreas Färber
2018-01-21  9:08 ` Kostya Porotchkin
2018-01-22  8:47 ` Stefan Roese
2018-01-29 12:40 ` Stefan Roese

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.