From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752271AbaIJJVr (ORCPT ); Wed, 10 Sep 2014 05:21:47 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:53626 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbaIJJVo (ORCPT ); Wed, 10 Sep 2014 05:21:44 -0400 From: Arnd Bergmann To: Alban Bedel Cc: Mark Rutland , Thierry Reding , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "grant.likely@linaro.org" , Kumar Gala , Ian Campbell , Pawel Moll , Rob Herring , Roland Stigge Subject: Re: [PATCH V3] pwm: lpc32xx - Add a driver for the motor PWM Date: Wed, 10 Sep 2014 11:21:29 +0200 Message-ID: <5900146.ZQPMvSzLeR@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20140910104220.44558cf7@avionic-0020> References: <1410277361-26848-1-git-send-email-alban.bedel@avionic-design.de> <20140909160548.GB3896@leverpostej> <20140910104220.44558cf7@avionic-0020> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V02:K0:EOuBLeOPDge09whn5qVkBnmlWWWzV+LWv6tykejd9jf CuhFuxn3Ww8FuDpcMXj7/bqFGwXbVhmkzlQth8nBkksMz8QMnt s+wTqsD8hrNdD3Poc1EYlwvsAHYULvsuZH1rvQ0EypS0ri/RqJ wenH/X/XLb+Q3+b3gGm5M5sh6P+x/gXS6DGiemhYxWRUzTwQn2 kKtG6eVLPOzb7t5T6Y5w9LT5XubD52SDFBsbXyQEode8dV7bc0 p6lijypAGm8SXVa7+HYxBRn0SxAo683dmUq50fns1W8xrGj7RM m5S3hVRDpo1Bplf9RvbjFDS1IQQcrEXvpLUvG6dv1jiz6eH/Su C1znqd/P1WpUL0yJGXxU= X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 10 September 2014 10:42:20 Alban Bedel wrote: > > > Please describe clocks in the binding. If the clock inputs are named, > > please use clock-names. > > No clock is defined in the current LPC32xx DTS, what should I do in > this case? This is a bit tricky. I would recommend describing the clock inputs in the binding anyway, as "optional" properties, in case we ever get a full DT-aware clocksource driver for lpc32xx. I've just mentioned the topic to Roland yesterday, I would really like to see such a clocksource driver done for other reasons (multiplatform support), but introducing one with full DT support is hard to do without breaking existing dtb files. Arnd