From: Daniel Borkmann <daniel@iogearbox.net>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Simon Horman <simon.horman@netronome.com>,
David Miller <davem@davemloft.net>
Cc: jakub.kicinski@netronome.com, netdev@vger.kernel.org,
johannes@sipsolutions.net, dsa@cumulusnetworks.com,
alexei.starovoitov@gmail.com, bblanco@gmail.com,
john.fastabend@gmail.com, kubakici@wp.pl,
oss-drivers@netronome.com
Subject: Re: [oss-drivers] Re: [RFC 3/4] nfp: make use of extended ack message reporting
Date: Wed, 26 Apr 2017 15:31:58 +0200 [thread overview]
Message-ID: <5900A14E.1030008@iogearbox.net> (raw)
In-Reply-To: <646e0fb0-1f10-f4d0-936c-7fdf96b6cc43@mojatatu.com>
On 04/26/2017 03:03 PM, Jamal Hadi Salim wrote:
> On 17-04-26 07:13 AM, Simon Horman wrote:
>
>> I don't feel strongly about this and perhaps it can be revisited at some
>> point but perhaps it would be worth documenting that he strings do not
>> form part of the UAPI as my expectation would have been that they do f.e. to
>> facilitate internationalisation.
>
> I thought people script against what iproute2 outputs today. We
> may have to change habits.
I would strictly treat this kind of auxiliary information as
non-stable error message data, and it should be documented
as such, f.e. in the man page.
Every driver or subsystem using this could have different
restrictions/semantics and thus error messages will not be
the same everywhere anyway, so there's zero point in parsing
this text from an application in the first place, it's just
passing this through to the user to aide debugging.
next prev parent reply other threads:[~2017-04-26 13:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 8:06 [RFC 0/4] xdp: use netlink extended ACK reporting Jakub Kicinski
2017-04-25 8:06 ` [RFC 1/4] netlink: make extended ACK setting NULL-friendly Jakub Kicinski
2017-04-25 8:13 ` Johannes Berg
2017-04-25 20:53 ` Jakub Kicinski
2017-04-26 7:17 ` Johannes Berg
2017-04-25 9:12 ` Daniel Borkmann
2017-04-25 8:06 ` [RFC 2/4] xdp: propagate extended ack to XDP setup Jakub Kicinski
2017-04-25 8:06 ` [RFC 3/4] nfp: make use of extended ack message reporting Jakub Kicinski
2017-04-25 12:42 ` Jamal Hadi Salim
2017-04-25 14:20 ` David Miller
2017-04-26 11:13 ` [oss-drivers] " Simon Horman
2017-04-26 13:03 ` Jamal Hadi Salim
2017-04-26 13:31 ` Daniel Borkmann [this message]
2017-04-26 14:44 ` David Miller
2017-04-26 18:44 ` Simon Horman
2017-04-25 8:06 ` [RFC 4/4] virtio_net: " Jakub Kicinski
2017-04-25 9:05 ` [RFC 0/4] xdp: use netlink extended ACK reporting Daniel Borkmann
2017-04-25 16:54 ` Jesper Dangaard Brouer
2017-04-25 21:00 ` Jakub Kicinski
2017-04-25 14:53 ` David Ahern
2017-04-25 21:05 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5900A14E.1030008@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=bblanco@gmail.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=johannes@sipsolutions.net \
--cc=john.fastabend@gmail.com \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.