From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 650BAC4338F for ; Thu, 29 Jul 2021 09:23:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF4D360F6F for ; Thu, 29 Jul 2021 09:23:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CF4D360F6F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3D7F282E10; Thu, 29 Jul 2021 11:23:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="FA/aj+j9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 806E582E0D; Thu, 29 Jul 2021 11:23:42 +0200 (CEST) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DC22C82E0D for ; Thu, 29 Jul 2021 11:23:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=narmstrong@baylibre.com Received: by mail-wr1-x42c.google.com with SMTP id h14so6016776wrx.10 for ; Thu, 29 Jul 2021 02:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mrwILQRIwT6qavYUdvWJ3f/OQY0XTwD9IoSexieFgco=; b=FA/aj+j9N6P+0wPBj7IFCH/4H5QXdQeX8KrgIvbLKepz618X2xnjI5bAa5unbFhgBI H4sU+netuBxkydUsbggTEPRWfK3kq96mJk/N+i1t2Se9S1CR273j/Rsb62sfiGIZTdyi hqKcZn5L4M74O4hCIwHbi93jRPrhtxmmg67B43Uv9ShbyxmDOGNGDcnlJPI9DymHEy35 OwSc7aYwspdbYaWEGGA+m3JO4T4LLF8MHM61ePPuX2guQlu2lxSsXFnALGNtiIJrlmpS wy471F6DVznCUeLkD5DzlQXTGk0GFwpgKeT/sROEfSUhDbYp8qoM+kAr2E/vG/Gc1ntB jYDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=mrwILQRIwT6qavYUdvWJ3f/OQY0XTwD9IoSexieFgco=; b=rGu74pYlVZaBXF6zrJ5ssLhjdpzKBrO4rzKYWsk8GXHQJPrI4IirnfukMr3yieGTwc tU9LUZJhX6l1/At/5E9qBWOgorLpjrcgXTXLh1HVzKfJ2/h4xXH0/ntTjnbXChSY6AlM oFkj9RBShUDkeHHiLMqkRQHygmGG8i9cwpj4s0jWx66+wXqKLiKkac0OqWQ1NrsQD/hN 6j9WDoUT4zxYXkpB4wkcOqE88XASjpfvdvSiZVG7S9kUnxsGIij556zHzvD4sszut/UT v3bBDRl2BT3znlU97e/4O14HVZt9KxCcaV2aZ4UxHmn9IiHgTTmrfPbZ4Z6d0NsXLex3 E1pQ== X-Gm-Message-State: AOAM531YOqNFRhbmohTqwnHkyI5eYs5LfnzULpy2O988S3CAmdA5nlPh VXw9bhfLPzCTbumtQ/e7vp7Gig8+sdG4WyL6 X-Google-Smtp-Source: ABdhPJxfas2hPeEj7vTqyjbssBk0KGT6ZK2pOWl2OZoEv8UavjOJLLmNuDJ6zpQheZ/aFqnZXBVwsA== X-Received: by 2002:adf:ec10:: with SMTP id x16mr3618173wrn.375.1627550618109; Thu, 29 Jul 2021 02:23:38 -0700 (PDT) Received: from [10.1.3.29] (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id p4sm2753520wrt.23.2021.07.29.02.23.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 02:23:37 -0700 (PDT) Subject: Re: [PATCH 6/6] configs: meson64_android: don't set console bootargs To: Mattijs Korpershoek Cc: u-boot-amlogic@groups.io, u-boot@lists.denx.de References: <20210729072113.208099-1-mkorpershoek@baylibre.com> <20210729072113.208099-7-mkorpershoek@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: <59050a6f-8a97-4c14-05cc-e22fbe71c1da@baylibre.com> Date: Thu, 29 Jul 2021 11:23:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729072113.208099-7-mkorpershoek@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 29/07/2021 09:21, Mattijs Korpershoek wrote: > The console bootargs are already set from the kernel commandline. > On Android, this is done in yukawa at [1] > > Don't set it in the bootloader since it's overridden by the kernel anyways. > > [1] https://android-review.googlesource.com/c/device/amlogic/yukawa/+/1112994 > Signed-off-by: Guillaume La Roque > Signed-off-by: Mattijs Korpershoek > --- > include/configs/meson64_android.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/configs/meson64_android.h b/include/configs/meson64_android.h > index 56545a72f8..3b61d5f703 100644 > --- a/include/configs/meson64_android.h > +++ b/include/configs/meson64_android.h > @@ -86,7 +86,7 @@ > "bootcmd_system=" \ > "echo Loading Android " BOOT_PARTITION " partition...;" \ > "mmc dev ${mmcdev};" \ > - "setenv bootargs ${bootargs} console=${console} androidboot.serialno=${serial#};" \ > + "setenv bootargs ${bootargs} androidboot.serialno=${serial#};" \ > "part start mmc ${mmcdev} " BOOT_PARTITION " boot_start;" \ > "part size mmc ${mmcdev} " BOOT_PARTITION " boot_size;" \ > "if mmc read ${loadaddr} ${boot_start} ${boot_size}; then " \ > @@ -121,8 +121,6 @@ > "gpio_recovery=88\0" \ > "check_button=gpio input ${gpio_recovery};test $? -eq 0;\0" \ > "load_logo=" PREBOOT_LOAD_LOGO "\0" \ > - "console=/dev/ttyAML0\0" \ > - "bootargs=no_console_suspend\0" \ > "stdin=" STDIN_CFG "\0" \ > "stdout=" STDOUT_CFG "\0" \ > "stderr=" STDOUT_CFG "\0" \ > Acked-by: Neil Armstrong