From: Mike Christie <mchristi@redhat.com>
To: lixiubo@cmss.chinamobile.com, nab@linux-iscsi.org
Cc: agrover@redhat.com, iliastsi@arrikto.com, namei.unix@gmail.com,
sheng@yasker.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jianfei Hu <hujianfei@cmss.chinamobile.com>
Subject: Re: [PATCH v6 1/2] tcmu: Add dynamic growing data area feature support
Date: Sun, 30 Apr 2017 00:48:48 -0500 [thread overview]
Message-ID: <59057AC0.2090804@redhat.com> (raw)
In-Reply-To: <1493187952-13125-2-git-send-email-lixiubo@cmss.chinamobile.com>
On 04/26/2017 01:25 AM, lixiubo@cmss.chinamobile.com wrote:
> for_each_sg(data_sg, sg, data_nents, i) {
> @@ -275,22 +371,26 @@ static void alloc_and_scatter_data_area(struct tcmu_dev *udev,
> from = kmap_atomic(sg_page(sg)) + sg->offset;
> while (sg_remaining > 0) {
> if (block_remaining == 0) {
> - block = find_first_zero_bit(udev->data_bitmap,
> - DATA_BLOCK_BITS);
> block_remaining = DATA_BLOCK_SIZE;
> - set_bit(block, udev->data_bitmap);
> + dbi = tcmu_get_empty_block(udev, &to);
> + if (dbi < 0)
I know it you fixed the missing kunmap_atomic here and missing unlock in
tcmu_queue_cmd_ring in the next patch, but I think normally people
prefer that one patch does not add a bug, then the next patch fixes it.
next prev parent reply other threads:[~2017-04-30 5:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 6:25 [PATCH v6 0/2] tcmu: Dynamic growing data area support lixiubo
2017-04-26 6:25 ` [PATCH v6 1/2] tcmu: Add dynamic growing data area feature support lixiubo
2017-04-30 5:48 ` Mike Christie [this message]
2017-04-30 10:22 ` [PATCH v6 1/2] tcmu: Add dynamic growing data area featuresupport Xiubo Li
2017-05-01 18:37 ` Mike Christie
2017-04-26 6:25 ` [PATCH v6 2/2] tcmu: Add global data block pool support lixiubo
2017-04-26 10:07 ` kbuild test robot
2017-04-26 10:07 ` kbuild test robot
2017-04-30 7:31 ` Mike Christie
2017-04-30 11:29 ` Xiubo Li
2017-05-01 18:40 ` Mike Christie
2017-05-02 5:26 ` Nicholas A. Bellinger
2017-05-02 5:25 ` [PATCH v6 0/2] tcmu: Dynamic growing data area support Nicholas A. Bellinger
2017-05-02 9:25 ` 答复: " lixiubo
2017-05-02 9:25 ` lixiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59057AC0.2090804@redhat.com \
--to=mchristi@redhat.com \
--cc=agrover@redhat.com \
--cc=hujianfei@cmss.chinamobile.com \
--cc=iliastsi@arrikto.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
--cc=nab@linux-iscsi.org \
--cc=namei.unix@gmail.com \
--cc=sheng@yasker.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.