All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: 王守堰 <wangshouyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Man page bug report about pthread_join
Date: Mon, 29 Aug 2016 09:58:43 +1200	[thread overview]
Message-ID: <590f86e0-6af1-5fd6-d1ac-c798acbd4763@gmail.com> (raw)
In-Reply-To: <CAPrqJzHFonOuZW+k=G662CK59gpftyUCdPsYFSRUWRRDbfCaLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hello 王守堰,

On 08/24/2016 09:11 PM, 王守堰 wrote:
> Hi:
>   I have checked the newest version of pthread_join at
> *http://man7.org/linux/man-pages/man3/pthread_join.3.html
> <http://man7.org/linux/man-pages/man3/pthread_join.3.html>*
>   I think there exists something wront in this sentence:
> 
> If *retval* is not NULL, then *pthread_join*() copies the exit status of
>        the target thread (i.e., the value that the target thread supplied to
>        pthread_exit(3)
> <http://man7.org/linux/man-pages/man3/pthread_exit.3.html>) into the
> location pointed to by **retval*.
> 
> I think it should be "into the location pointed to by *retval" *or
> "into **retval".*
> 
> Because the actual behavior of pthread_join() is like:  *retval = exit_status;
> 
> But the current man page description means: *(*retval) = exit_status;
> 
> Do you agree with me?
> 
> Hope your reply.

I agree that there is a bit of confusion in the wording of the page.
I changed this paragraph to read:

       If retval is not NULL, then pthread_join() copies the exit  status
       of  the target thread (i.e., the value that the target thread sup‐
       plied to pthread_exit(3)) into the location pointed to by  retval.
       If the target thread was canceled, then PTHREAD_CANCELED is placed
       in the location pointed to by retval.

Okay?

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

       reply	other threads:[~2016-08-28 21:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAPrqJzHFonOuZW+k=G662CK59gpftyUCdPsYFSRUWRRDbfCaLQ@mail.gmail.com>
     [not found] ` <CAPrqJzHFonOuZW+k=G662CK59gpftyUCdPsYFSRUWRRDbfCaLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-28 21:58   ` Michael Kerrisk (man-pages) [this message]
     [not found]     ` <590f86e0-6af1-5fd6-d1ac-c798acbd4763-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-29 16:41       ` Man page bug report about pthread_join Mats Wichmann
     [not found]         ` <d3925e02-c02a-b969-5221-ea98fcbadbaf-mBRmNHn34rVzbRFIqnYvSA@public.gmane.org>
2016-08-29 19:59           ` Michael Kerrisk (man-pages)
     [not found]             ` <eccff3a8-f68a-4843-5ce6-b14976b260be-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-29 21:48               ` Mats Wichmann
     [not found]                 ` <279302ac-6ca2-a061-8d98-42ff6ea5a3cd-mBRmNHn34rVzbRFIqnYvSA@public.gmane.org>
2016-08-30 18:52                   ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=590f86e0-6af1-5fd6-d1ac-c798acbd4763@gmail.com \
    --to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wangshouyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.