From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 for-next] x86/mm: Fix the odd indentation of the pin_page block of do_mmuext_op()
Date: Mon, 08 May 2017 01:20:56 -0600 [thread overview]
Message-ID: <591038780200007800157931@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1494001963-30732-1-git-send-email-andrew.cooper3@citrix.com>
>>> On 05.05.17 at 18:32, <andrew.cooper3@citrix.com> wrote:
> The pin_page block is missing one level of indentation, which makes the
> MMUEXT_UNPIN_TABLE case label appear to be outside of the switch statement.
>
> However, the block isn't needed at all if page is declared with switch level
> scope. This allows for the removal of the identical local declarations for
> MMUEXT_UNPIN_TABLE, MMUEXT_NEW_USER_BASEPTR and MMUEXT_CLEAR_PAGE.
>
> While making this adjustment, delete one other piece of trailing whitespace.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-05-08 7:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 15:51 [PATCH for-next] x86/mm: Correctly indent the pin_page block of do_mmuext_op() Andrew Cooper
2017-05-05 16:11 ` Jan Beulich
2017-05-05 16:32 ` [PATCH v2 for-next] x86/mm: Fix the odd indentation of " Andrew Cooper
2017-05-05 16:35 ` Wei Liu
2017-05-08 7:20 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591038780200007800157931@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.