All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: "Zhangbo (Oscar)" <oscar.zhangbo@huawei.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH]acpi: enlarge NUM_FIXMAP_ACPI_PAGES from 4 to 5
Date: Wed, 10 May 2017 04:17:36 -0600	[thread overview]
Message-ID: <591304E0020000780015878E@prv-mh.provo.novell.com> (raw)
In-Reply-To: <0259E1C966E8C54AA93AA2B1240828E651ACD2D1@dggeml510-mbs.china.huawei.com>

>>> On 04.05.17 at 04:59, <oscar.zhangbo@huawei.com> wrote:
> --- a/xen/include/xen/acpi.h
> +++ b/xen/include/xen/acpi.h
> @@ -43,7 +43,7 @@
>   * Fixmap pages to reserve for ACPI boot-time tables (see asm-x86/fixmap.h or
>   * asm-arm/config.h)
>   */
> -#define NUM_FIXMAP_ACPI_PAGES  4
> +#define NUM_FIXMAP_ACPI_PAGES  5

Well, this is the kind of fix I don't really like: You make things work for
you without thinking about others. If you found 4 pages aren't
enough, how likely is it that soon someone will find 5 aren't enough
either? IOW, short of eliminating the fixed upper bound altogether,
you should at least add some slack for the foreseeable future. For
this it may also help to estimate the theoretical upper limit of SRAT
(and perhaps other affected tables) for systems currently around
plus, again, some slack. As you may have concluded already it
would therefore also have helped if you had indicated what size a
system you see this relatively large SRAT on.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-05-10 10:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04  2:59 [PATCH]acpi: enlarge NUM_FIXMAP_ACPI_PAGES from 4 to 5 Zhangbo (Oscar)
2017-05-10 10:17 ` Jan Beulich [this message]
2017-05-11  6:45   ` Zhangbo (Oscar)
2017-05-10  3:29 Zhangbo (Oscar)
2017-05-10  9:06 ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=591304E0020000780015878E@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=oscar.zhangbo@huawei.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.