[U-Boot] [PATCH] at91_udc.c: Fix unused variable warning

[U-Boot] [PATCH] at91_udc.c: Fix unused variable warning

[Tom Rini]

With gcc-6 and later we see warnings that at91sam9263_udc_caps and
at91rm9200_udc_caps are unused.

Fixes: 620197670a69 ("usb: gadget: at91_udc: add at91_udc into U-Boot")
Cc: Lukasz Majewski <lukma@denx.de>
Cc: Marek Vasut <marex@denx.de>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 drivers/usb/gadget/at91_udc.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index f5bc277fa6e0..01a59078b84a 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/drivers/usb/gadget/at91_udc.c
@@ -1386,11 +1386,6 @@ static void at91rm9200_udc_pullup(struct at91_udc *udc, int is_on)
 		gpio_set_value(udc->board.pullup_pin, !active);
 }
 
-static const struct at91_udc_caps at91rm9200_udc_caps = {
-	.init = at91rm9200_udc_init,
-	.pullup = at91rm9200_udc_pullup,
-};
-
 static int at91sam9260_udc_init(struct at91_udc *udc)
 {
 	struct at91_ep *ep;
@@ -1503,11 +1498,6 @@ static int at91sam9263_udc_init(struct at91_udc *udc)
 	return 0;
 }
 
-static const struct at91_udc_caps at91sam9263_udc_caps = {
-	.init = at91sam9263_udc_init,
-	.pullup = at91sam9260_udc_pullup,
-};
-
 int usb_gadget_handle_interrupts(int index)
 {
 	struct at91_udc *udc = controller;
-- 
1.9.1

[U-Boot] [PATCH] at91_udc.c: Fix unused variable warning

[Marek Vasut]

On 04/19/2017 04:23 AM, Tom Rini wrote:
> With gcc-6 and later we see warnings that at91sam9263_udc_caps and
> at91rm9200_udc_caps are unused.
> 
> Fixes: 620197670a69 ("usb: gadget: at91_udc: add at91_udc into U-Boot")
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>

I'd like Heiko's ACK on this one, since it's his patch which dropped the
references. IMO looks OK tho.

> ---
>  drivers/usb/gadget/at91_udc.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
> index f5bc277fa6e0..01a59078b84a 100644
> --- a/drivers/usb/gadget/at91_udc.c
> +++ b/drivers/usb/gadget/at91_udc.c
> @@ -1386,11 +1386,6 @@ static void at91rm9200_udc_pullup(struct at91_udc *udc, int is_on)
>  		gpio_set_value(udc->board.pullup_pin, !active);
>  }
>  
> -static const struct at91_udc_caps at91rm9200_udc_caps = {
> -	.init = at91rm9200_udc_init,
> -	.pullup = at91rm9200_udc_pullup,
> -};
> -
>  static int at91sam9260_udc_init(struct at91_udc *udc)
>  {
>  	struct at91_ep *ep;
> @@ -1503,11 +1498,6 @@ static int at91sam9263_udc_init(struct at91_udc *udc)
>  	return 0;
>  }
>  
> -static const struct at91_udc_caps at91sam9263_udc_caps = {
> -	.init = at91sam9263_udc_init,
> -	.pullup = at91sam9260_udc_pullup,
> -};
> -
>  int usb_gadget_handle_interrupts(int index)
>  {
>  	struct at91_udc *udc = controller;
> 


-- 
Best regards,
Marek Vasut

[U-Boot] [PATCH] at91_udc.c: Fix unused variable warning

[Heiko Schocher]

Hello Tom, Marek,

Am 19.04.2017 um 04:23 schrieb Tom Rini:
> With gcc-6 and later we see warnings that at91sam9263_udc_caps and
> at91rm9200_udc_caps are unused.
>
> Fixes: 620197670a69 ("usb: gadget: at91_udc: add at91_udc into U-Boot")
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>   drivers/usb/gadget/at91_udc.c | 10 ----------
>   1 file changed, 10 deletions(-)

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
> index f5bc277fa6e0..01a59078b84a 100644
> --- a/drivers/usb/gadget/at91_udc.c
> +++ b/drivers/usb/gadget/at91_udc.c
> @@ -1386,11 +1386,6 @@ static void at91rm9200_udc_pullup(struct at91_udc *udc, int is_on)
>   		gpio_set_value(udc->board.pullup_pin, !active);
>   }
>
> -static const struct at91_udc_caps at91rm9200_udc_caps = {
> -	.init = at91rm9200_udc_init,
> -	.pullup = at91rm9200_udc_pullup,
> -};
> -
>   static int at91sam9260_udc_init(struct at91_udc *udc)
>   {
>   	struct at91_ep *ep;
> @@ -1503,11 +1498,6 @@ static int at91sam9263_udc_init(struct at91_udc *udc)
>   	return 0;
>   }
>
> -static const struct at91_udc_caps at91sam9263_udc_caps = {
> -	.init = at91sam9263_udc_init,
> -	.pullup = at91sam9260_udc_pullup,
> -};
> -
>   int usb_gadget_handle_interrupts(int index)
>   {
>   	struct at91_udc *udc = controller;
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany