From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37AE0C4320A for ; Fri, 23 Jul 2021 17:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FFD260ED7 for ; Fri, 23 Jul 2021 17:36:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231691AbhGWQ4B (ORCPT ); Fri, 23 Jul 2021 12:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbhGWQ4A (ORCPT ); Fri, 23 Jul 2021 12:56:00 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FA04C061757 for ; Fri, 23 Jul 2021 10:36:33 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id l126so3428796ioa.12 for ; Fri, 23 Jul 2021 10:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dUwxjEO6jp47Rz2JEQjvKi+qFhqfV3bJEfO0Rigrqe8=; b=m5lXE98mJ1kVuFljZ9hFbkn1S7yLGd0kvhu3A6dZPL0Pcl0m2AKWx4mBQ9fLP91c5l 94MMjSaJ21QKUw7chZSIQDwbyr9RefYJHqXZ6eJ9WTHhX/Y8xMfCnNiZHe8rMdk1TA8A yBItfOpZTF0zfaxGEMOSgUGeZNbtfSUs89M8hQmUvnY635zPfc0tz7FZGbIMDinlcZaV F2gubBMSLcjXin5f4gyFpvvpabihpBOZx96lhqmCp/mHsC6dQkaDRGnnKPDZf61/dowN QfjXB2j4kdE2wlvwHTzNUJUInJEX1ChXNa5lvnwk7n8XRs4uXVbvmguK5ImrHgMnjdXK AyLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dUwxjEO6jp47Rz2JEQjvKi+qFhqfV3bJEfO0Rigrqe8=; b=iYF+BfEhmoYp605zaGkiYhMCAUp+eVvXrqT01r595OMxg4fB159xP7R0bZd8M7mO4T XRNCjfrk9lthducHO3oazh6bwbd5lvUqICGanJo5Z7ToHdjTUuWFCkAXO0x7KfJ+QuL7 lx6zA4/JbEykzW1sFiY1/SjZ5+qn8jO46aGi+8On8CFsP0gDxTXFuKM0rclVddc4o6o8 /NgxnJm2zjowMevD6SQYUGCzC9P7h1EHCGH9m/zoc81jHnNIiluiscQJVPbQcT+9aMJe MilkdK/P7Opu7IZ2SUzk1OvN7sEVWVr7t8LYmLt+yN/4WvkBQcNw7NIoI15lsCzKr1Na LOjg== X-Gm-Message-State: AOAM531+RSV4liO4wEduD0mY1NWurkwRmtdrKH9NvBQPsJCct0rGCTAD YR0iCPRilDhO0OV+eZPFLHWcBg== X-Google-Smtp-Source: ABdhPJz92FO6x1+kfUTpbgotTdFxhjXK67vWFylh+q1fNBgGNRgJf0U1hFfjbcZTNBizIxjzcAQvkg== X-Received: by 2002:a05:6638:2111:: with SMTP id n17mr4993668jaj.76.1627061792384; Fri, 23 Jul 2021 10:36:32 -0700 (PDT) Received: from [192.168.1.10] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id x11sm3681181ilu.3.2021.07.23.10.36.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 10:36:32 -0700 (PDT) Subject: Re: [PATCH 3/3] io_uring: refactor io_sq_offload_create() From: Jens Axboe To: Al Viro Cc: Pavel Begunkov , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linus Torvalds References: <939776f90de8d2cdd0414e1baa29c8ec0926b561.1618916549.git.asml.silence@gmail.com> <57758edf-d064-d37e-e544-e0c72299823d@kernel.dk> <8fb39022-ba21-2c1f-3df5-29be002014d8@kernel.dk> Message-ID: <591b4a1e-606a-898c-7470-b5a1be621047@kernel.dk> Date: Fri, 23 Jul 2021 11:36:31 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 7/23/21 11:32 AM, Jens Axboe wrote: > Outside of that, we're not submitting off release, only killing anything > pending. The only odd case there is iopoll, but that doesn't resubmit > here. OK perhaps I'm wrong on this one - if we have a pending iopoll request, and we run into the rare case of needing resubmit, we are doing that off the release path and that should not happen. Hence it could potentially happen for iosched and/or low queue depth devices, if you are using a ring for pure polling. I'll patch that up. -- Jens Axboe