From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0FB5C4332F for ; Mon, 6 Nov 2023 14:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231610AbjKFO1E (ORCPT ); Mon, 6 Nov 2023 09:27:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230514AbjKFO1B (ORCPT ); Mon, 6 Nov 2023 09:27:01 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3898184 for ; Mon, 6 Nov 2023 06:26:58 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5AB9C433CA; Mon, 6 Nov 2023 14:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699280818; bh=mA1LhY1QNKSMIHIzpniKfSDIhyBdqrkTOBTwMlQ+F60=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GGvtBe/mJPzBZrsXtD13r/LBh+W/LNiJ6X99xlvAp0Y9hViaKyz2zMNZbyly7nEyG Ok3vr5aXW8KlwCU/N9pLps4MFR5omiQOfIunngHS40fjI5tgtwhr2TnUWTyu5z4alr G3l0sfbw0BBil7jB1/6pKlCIPdEnEvOe8+09Na9+FyT2xwzwkyRxMl27M4J6iWuh6C nx6NlCljt/eOgFwZQ+ktQJXxm38rUopywGAI4xquO+zYLVql1+nL8XShKF5xo8MZzu eqX1t128vHZ1Yj3k5p+tzsjY78DIMgnCB4o3KDar4pk6K9g69IXcUP5dzvxby5Yajm fyzCLlPjI+fnQ== Message-ID: <59203a63-f759-431c-a035-d3cbc433dcfb@kernel.org> Date: Mon, 6 Nov 2023 15:26:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/7] sched/fair: Add trivial fair server To: Peter Zijlstra Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, Luca Abeni , Tommaso Cucinotta , Thomas Gleixner , Joel Fernandes , Vineeth Pillai , Shuah Khan , Phil Auld References: <4e0d14eb6e0ec33055197ac7ddb57ef7ab3894a5.1699095159.git.bristot@kernel.org> <20231106142430.GF3818@noisy.programming.kicks-ass.net> Content-Language: en-US, pt-BR, it-IT From: Daniel Bristot de Oliveira In-Reply-To: <20231106142430.GF3818@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/6/23 15:24, Peter Zijlstra wrote: > On Sat, Nov 04, 2023 at 11:59:22AM +0100, Daniel Bristot de Oliveira wrote: > >> [ dl_server do not account for rt ] >> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c >> index 541d547e1019..1d7b96ca9011 100644 >> --- a/kernel/sched/deadline.c >> +++ b/kernel/sched/deadline.c >> @@ -1382,6 +1382,13 @@ static void update_curr_dl_se(struct rq *rq, struct sched_dl_entity *dl_se, s64 >> resched_curr(rq); >> } >> >> + /* >> + * The fair server (sole dl_server) does not account for real-time >> + * workload because it is running fair work. >> + */ >> + if (dl_server(dl_se)) >> + return; >> + >> /* >> * Because -- for now -- we share the rt bandwidth, we need to >> * account our runtime there too, otherwise actual rt tasks > Should we perhaps write this like so? > > if (dl_se == &rq->fair_server) > return; right, it is better for the next step (making it generic). -- Daniel