From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF488C433E0 for ; Wed, 13 Jan 2021 16:57:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C91123383 for ; Wed, 13 Jan 2021 16:57:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C91123383 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzjSo-0003in-2c for qemu-devel@archiver.kernel.org; Wed, 13 Jan 2021 11:57:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzjHh-0001G2-BQ for qemu-devel@nongnu.org; Wed, 13 Jan 2021 11:46:13 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:50868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzjHd-0000l8-L3 for qemu-devel@nongnu.org; Wed, 13 Jan 2021 11:46:13 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10DGi1uJ156819; Wed, 13 Jan 2021 16:46:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=hPu7wN7ju0+TsPfCYfKU+uzvPIPaNwfpLs7IAFj+BMg=; b=TdhMCvcWBGL8Ynlo+OKsnEQL1ClUX7/7uWSzCoveBjPGmQra2qfOWRKjAutMn6JT1qhh bMU9qhKtNxuMgnSyRo8a2dJoHQ4R1gk2XPESglPLIRGNw9r23R3gXNXlgITnX0tdS9zM Q4z1FBvhUsjj6dM8GQmprQy6MTiuQ8q6V6thTA8n9lSmeYnukKY3DfmWaoFTgDxRoRzy GRtZeWNClZsptVrHMlyLaZHOlczsjQ24ajWnv7hseeWrb/JvXRZr9VzSZ0tat1l4F9Ll Et1xFL/xFVm6TtYcgXZLROt+PGOi9Typtk2wp5uda9TEiWmn/vxUrviPMY4wqcHbgUc+ hg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 360kcyve8j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Jan 2021 16:46:01 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10DGeiGi061734; Wed, 13 Jan 2021 16:46:00 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 360kekm77h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Jan 2021 16:46:00 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 10DGjwp7025412; Wed, 13 Jan 2021 16:45:58 GMT Received: from dhcp-10-39-210-223.vpn.oracle.com (/10.39.210.223) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 13 Jan 2021 08:45:58 -0800 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: [PATCH v16 00/20] Initial support for multi-process Qemu From: Jag Raman In-Reply-To: Date: Wed, 13 Jan 2021 11:45:55 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <5920F8E4-3B63-49B0-9936-94689AA373B4@oracle.com> References: To: luoyonggang@gmail.com X-Mailer: Apple Mail (2.3654.40.0.2.32) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9863 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 spamscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101130101 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9863 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 mlxlogscore=999 mlxscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101130101 Received-SPF: pass client-ip=141.146.126.78; envelope-from=jag.raman@oracle.com; helo=aserp2120.oracle.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elena Ufimtseva , Fam Zheng , Swapnil Ingle , John G Johnson , qemu-level , Gerd Hoffmann , Juan Quintela , "Michael S. Tsirkin" , Markus Armbruster , kanth.ghatraju@oracle.com, Felipe Franciosi , Thomas Huth , Eduardo Habkost , konrad.wilk@oracle.com, "Dr . David Alan Gilbert" , alex.williamson@redhat.com, Stefan Hajnoczi , Paolo Bonzini , Kevin Wolf , =?utf-8?B?IkRhbmllbCBQLiBCZXJyYW5nw6ki?= , Max Reitz , ross.lagerwall@citrix.com, =?utf-8?Q?Marc-Andr=C3=A9_Lureau?= , thanos.makatos@nutanix.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > On Jan 11, 2021, at 3:13 PM, =E7=BD=97=E5=8B=87=E5=88=9A(Yonggang Luo) = wrote: >=20 >=20 >=20 > On Tue, Jan 12, 2021 at 2:02 AM Jag Raman = wrote: > > > > > > > > > On Jan 11, 2021, at 12:20 AM, =E7=BD=97=E5=8B=87=E5=88=9A(Yonggang = Luo) wrote: > > > > > > I have a question, does this support/test on Windows? > > > > Hi Yonggang, we have not tested this on Windows. The project only = builds on Linux for now. > > > > Thank you! > I may interested add Windows support, what's the hard part? Hi Yonggang, I think it would be the unix sockets and sharing file descriptors via = them. Thanks! > If we add Windows/OSX support, we can create same code base for all = three platforms, and reduce #ifdef _WIN32 like macros >=20 >=20 > > =E2=80=94 > > Jag > > > > > > > > On Mon, Jan 11, 2021 at 1:08 PM Jagannathan Raman = wrote: > > > > > > > > Hi > > > > > > > > This is the v16 of the patchset. Thank you for your time = reviewing v15. > > > > > > > > This version has the following changes: > > > > > > > > [PATCH v16 04/20] multi-process: Add config option for = multi-process QEMU > > > > - Using =E2=80=9Cdefault_feature=E2=80=9D value to = enable/disable multiprocess > > > > > > > > [PATCH v16 07/20] io: add qio_channel_writev_full_all helper > > > > - Removed local variable in qio_channel_writev_full_all(), = setting arguments > > > > directly > > > > - Fixed indentation issues > > > > - Updated commit message > > > > > > > > [PATCH v16 08/20] io: add qio_channel_readv_full_all_eof & > > > > qio_channel_readv_full_all helpers > > > > - Added two variants of readv - _full_all_eof & _full_all = based on feedback > > > > - Dropped errno return value > > > > - Updated commit message > > > > - Unable to remove local variables and set arguments directly = as the > > > > arguments are later needed for cleanup (g_free/close) during = failure > > > > > > > > Switched to using OBJECT_DECLARE_{SIMPLE_TYPE, TYPE} macros in = the > > > > following patches: > > > > - [PATCH v16 05/20] multi-process: setup PCI host bridge for = remote device > > > > - [PATCH v16 06/20] multi-process: setup a machine object for = remote device > > > > process > > > > - [PATCH v16 11/20] multi-process: Associate fd of a PCIDevice = with its object > > > > - [PATCH v16 13/20] multi-process: introduce proxy object > > > > > > > > Updated copyright text to use the year 2021 in the files that = show them. > > > > > > > > To touch upon the history of this project, we posted the Proof = Of Concept > > > > patches before the BoF session in 2018. Subsequently, we have = posted 15 > > > > versions on the qemu-devel mailing list. You can find them by = following > > > > the links below ([1] - [15]). Following people contributed to = the design and > > > > implementation of this project: > > > > Jagannathan Raman > > > > Elena Ufimtseva > > > > John G Johnson > > > > Stefan Hajnoczi > > > > Konrad Wilk > > > > Kanth Ghatraju > > > > > > > > We would like to thank the QEMU community for your feedback in = the > > > > design and implementation of this project. Qemu wiki page: > > > > https://wiki.qemu.org/Features/MultiProcessQEMU > > > > > > > > For the full concept writeup about QEMU multi-process, please > > > > refer to docs/devel/qemu-multiprocess.rst. Also, see > > > > docs/qemu-multiprocess.txt for usage information. > > > > > > > > Thank you for reviewing this series! > > > > > > > > [POC]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg566538.html > > > > [1]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg602285.html > > > > [2]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg624877.html > > > > [3]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg642000.html > > > > [4]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg655118.html > > > > [5]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg682429.html > > > > [6]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg697484.html > > > > [7]: = https://patchew.org/QEMU/cover.1593273671.git.elena.ufimtseva@oracle.com/ > > > > [8]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg727007.html > > > > [9]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg734275.html > > > > [10]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg747638.html > > > > [11]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg750972.html > > > > [12]: = https://patchew.org/QEMU/cover.1606853298.git.jag.raman@oracle.com/ > > > > [13]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg766825.html > > > > [14]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg768376.html > > > > [15]: = https://www.mail-archive.com/qemu-devel@nongnu.org/msg769178.html > > > > > > > > Elena Ufimtseva (8): > > > > multi-process: add configure and usage information > > > > io: add qio_channel_writev_full_all helper > > > > io: add qio_channel_readv_full_all_eof & = qio_channel_readv_full_all > > > > helpers > > > > multi-process: define MPQemuMsg format and transmission = functions > > > > multi-process: introduce proxy object > > > > multi-process: add proxy communication functions > > > > multi-process: Forward PCI config space acceses to the remote = process > > > > multi-process: perform device reset in the remote process > > > > > > > > Jagannathan Raman (11): > > > > memory: alloc RAM from file at offset > > > > multi-process: Add config option for multi-process QEMU > > > > multi-process: setup PCI host bridge for remote device > > > > multi-process: setup a machine object for remote device = process > > > > multi-process: Initialize message handler in remote device > > > > multi-process: Associate fd of a PCIDevice with its object > > > > multi-process: setup memory manager for remote device > > > > multi-process: PCI BAR read/write handling for proxy & remote > > > > endpoints > > > > multi-process: Synchronize remote memory > > > > multi-process: create IOHUB object to handle irq > > > > multi-process: Retrieve PCI info from remote process > > > > > > > > John G Johnson (1): > > > > multi-process: add the concept description to > > > > docs/devel/qemu-multiprocess > > > > > > > > docs/devel/index.rst | 1 + > > > > docs/devel/multi-process.rst | 966 = ++++++++++++++++++++++++++++++ > > > > docs/multi-process.rst | 64 ++ > > > > configure | 10 + > > > > meson.build | 5 +- > > > > hw/remote/trace.h | 1 + > > > > include/exec/memory.h | 2 + > > > > include/exec/ram_addr.h | 2 +- > > > > include/hw/pci-host/remote.h | 30 + > > > > include/hw/pci/pci_ids.h | 3 + > > > > include/hw/remote/iohub.h | 42 ++ > > > > include/hw/remote/machine.h | 38 ++ > > > > include/hw/remote/memory.h | 19 + > > > > include/hw/remote/mpqemu-link.h | 99 +++ > > > > include/hw/remote/proxy-memory-listener.h | 28 + > > > > include/hw/remote/proxy.h | 48 ++ > > > > include/io/channel.h | 76 +++ > > > > include/qemu/mmap-alloc.h | 4 +- > > > > include/sysemu/iothread.h | 6 + > > > > backends/hostmem-memfd.c | 2 +- > > > > hw/misc/ivshmem.c | 3 +- > > > > hw/pci-host/remote.c | 75 +++ > > > > hw/remote/iohub.c | 119 ++++ > > > > hw/remote/machine.c | 80 +++ > > > > hw/remote/memory.c | 65 ++ > > > > hw/remote/message.c | 230 +++++++ > > > > hw/remote/mpqemu-link.c | 267 +++++++++ > > > > hw/remote/proxy-memory-listener.c | 227 +++++++ > > > > hw/remote/proxy.c | 379 ++++++++++++ > > > > hw/remote/remote-obj.c | 203 +++++++ > > > > io/channel.c | 88 ++- > > > > iothread.c | 6 + > > > > softmmu/memory.c | 3 +- > > > > softmmu/physmem.c | 11 +- > > > > util/mmap-alloc.c | 7 +- > > > > util/oslib-posix.c | 2 +- > > > > Kconfig.host | 4 + > > > > MAINTAINERS | 24 + > > > > hw/Kconfig | 1 + > > > > hw/meson.build | 1 + > > > > hw/pci-host/Kconfig | 3 + > > > > hw/pci-host/meson.build | 1 + > > > > hw/remote/Kconfig | 4 + > > > > hw/remote/meson.build | 13 + > > > > hw/remote/trace-events | 4 + > > > > 45 files changed, 3234 insertions(+), 32 deletions(-) > > > > create mode 100644 docs/devel/multi-process.rst > > > > create mode 100644 docs/multi-process.rst > > > > create mode 100644 hw/remote/trace.h > > > > create mode 100644 include/hw/pci-host/remote.h > > > > create mode 100644 include/hw/remote/iohub.h > > > > create mode 100644 include/hw/remote/machine.h > > > > create mode 100644 include/hw/remote/memory.h > > > > create mode 100644 include/hw/remote/mpqemu-link.h > > > > create mode 100644 include/hw/remote/proxy-memory-listener.h > > > > create mode 100644 include/hw/remote/proxy.h > > > > create mode 100644 hw/pci-host/remote.c > > > > create mode 100644 hw/remote/iohub.c > > > > create mode 100644 hw/remote/machine.c > > > > create mode 100644 hw/remote/memory.c > > > > create mode 100644 hw/remote/message.c > > > > create mode 100644 hw/remote/mpqemu-link.c > > > > create mode 100644 hw/remote/proxy-memory-listener.c > > > > create mode 100644 hw/remote/proxy.c > > > > create mode 100644 hw/remote/remote-obj.c > > > > create mode 100644 hw/remote/Kconfig > > > > create mode 100644 hw/remote/meson.build > > > > create mode 100644 hw/remote/trace-events > > > > > > > > -- > > > > 1.8.3.1 > > > > > > > > > > > > > > > > > -- > > > =E6=AD=A4=E8=87=B4 > > > =E7=A4=BC > > > =E7=BD=97=E5=8B=87=E5=88=9A > > > Yours > > > sincerely, > > > Yonggang Luo > > >=20 >=20 > -- > =E6=AD=A4=E8=87=B4 > =E7=A4=BC > =E7=BD=97=E5=8B=87=E5=88=9A > Yours > sincerely, > Yonggang Luo