From: Christopher Larson <kergoth@gmail.com>
To: bitbake-devel@lists.openembedded.org,
Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [bitbake-devel] [PATCH] cookerdata: Fix cache/reparsing issue
Date: Sun, 1 Jan 2023 09:55:30 -0700 [thread overview]
Message-ID: <59224516-17d8-4c43-9f2b-38c5034cfdba@Spark> (raw)
In-Reply-To: <20230101142509.1022073-1-richard.purdie@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Jan 1, 2023 at 7:25 AM -0700, Richard Purdie <richard.purdie@linuxfoundation.org>, wrote:
> When setting the LAYERSERIES_COMPAT and LAYERSERIES_CORENAMES variables,
> we need to be deterministic. The random ordering from the sets was causing
> unexpected reparses.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> lib/bb/cookerdata.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
> index b4e0c4216b..8198f509e2 100644
> --- a/lib/bb/cookerdata.py
> +++ b/lib/bb/cookerdata.py
> @@ -425,7 +425,7 @@ class CookerDataBuilder(object):
> data.delVar('LAYERDIR_RE')
> data.delVar('LAYERDIR')
> for c in compat_entries:
> - data.setVar("LAYERSERIES_COMPAT_%s" % c, compat_entries[c])
> + data.setVar("LAYERSERIES_COMPAT_%s" % c, sorted(compat_entries[c]))
Missed a “ “.join() here, it’s currently setting the variable to a generator object, afaik :)
[-- Attachment #2: Type: text/html, Size: 1416 bytes --]
next prev parent reply other threads:[~2023-01-01 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 14:25 [PATCH] cookerdata: Fix cache/reparsing issue Richard Purdie
2023-01-01 16:55 ` Christopher Larson [this message]
2023-01-02 0:50 ` [bitbake-devel] " Richard Purdie
2023-01-02 10:01 ` Quentin Schulz
2023-01-02 10:04 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59224516-17d8-4c43-9f2b-38c5034cfdba@Spark \
--to=kergoth@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.