From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] testpmd: check return value of rte_eth_dev_vlan_filter() Date: Tue, 27 Jan 2015 23:22:11 +0100 Message-ID: <59280674.3ZXkOACZBp@xps13> References: <1422009831-11092-1-git-send-email-michalx.k.jastrzebski@intel.com> <3441479.cVrRmaIGdi@xps13> <60ABE07DBB3A454EB7FAD707B4BB1582138D57F7@IRSMSX109.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Jastrzebski, MichalX K" Return-path: In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB1582138D57F7-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-01-27 15:58, Jastrzebski, MichalX K: > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > And more importantly, you make it clear that sometimes we cannot enable > > all vlans and return no error. > > Should I return this error somewhere? Isn't just printing the error best option here? Yes printing a warning before "break" seems a good idea. > > So I wonder how is it documented in the testpmd help? > > I can add a note in testpmd_funcs.rst file or I can place some info in .help_str? > What do you mean "testpmd help"? I mean both :) But maybe it's not appropriate in .help_str, I'm not sure. -- Thomas