From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbdFAH4E (ORCPT ); Thu, 1 Jun 2017 03:56:04 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:65462 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbdFAHzx (ORCPT ); Thu, 1 Jun 2017 03:55:53 -0400 Message-ID: <592FC889.3020001@mentor.com> Date: Thu, 1 Jun 2017 00:55:53 -0700 From: Jiada Wang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 MIME-Version: 1.0 To: Fabio Estevam CC: Mark Brown , "linux-spi@vger.kernel.org" , linux-kernel , Sascha Hauer Subject: Re: [PATCH linux-next v3 1/1] spi: imx: dynamic burst length adjust for PIO mode References: <1495774962-2981-1-git-send-email-jiada_wang@mentor.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Fabio On 05/29/2017 04:07 AM, Fabio Estevam wrote: > Hi Jiada, > > On Fri, May 26, 2017 at 2:02 AM, wrote: >> From: Jiada Wang >> >> previously burst length (BURST_LENGTH) is always set to equal >> to bits_per_word, causes a 10us gap between each word in >> transfer, which significantly affects performance. >> >> This patch uses 32 bits transfer to simulate lower bits transfer, >> and adjusts burst length runtimely to use biggeest burst length >> as possible to reduce the gaps in transfer for PIO mode. > Just curious: what is the performance gain you observe with this patch? I did some performance test with 576/384/192 bytes data, following is the result between the test w & w/o this patch (ecspi controller works in PIO and loopback mode) with this patch: bytes bpw time (ms) 576 8 9.2 576 16 9.2 384 8 6.2 192 8 3.1 without this patch bytes bpw time(ms) 576 8 14.4 576 16 11.6 384 8 9.6 384 16 7.8 192 8 4.8 192 16 3.9 Thanks, Jiada