All of lore.kernel.org
 help / color / mirror / Atom feed
From: L A Walsh <lkml@tlinx.org>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Patch: ensure mount & umount are root-owned before setting SUID bit
Date: Tue, 06 Jun 2017 10:12:50 -0700	[thread overview]
Message-ID: <5936E292.4000709@tlinx.org> (raw)
In-Reply-To: <5936D40E.3040000@tlinx.org>

L A Walsh wrote:
>
>
> Maybe the install should check to see
> if it is root before setting a SUID bit on the executable?
Maybe this can be applied to source tree sometime before nxt release?
Won't help if you are running the make as 'root', but at least
it will flag an error when you try to "make install" it...

tnx,
-l


-----
--- Makefile.in    2017-05-23 03:21:36.000000000 -0700
+++ Makefile.in    2017-06-06 10:09:12.318352218 -0700
@@ -12332,7 +12332,9 @@
 @BUILD_SETARCH_TRUE@    done
 
 @BUILD_MOUNT_TRUE@@MAKEINSTALL_DO_SETUID_TRUE@install-exec-hook-mount:
+@BUILD_MOUNT_TRUE@@MAKEINSTALL_DO_SETUID_TRUE@    chown root:root 
$(DESTDIR)$(bindir)/mount
 @BUILD_MOUNT_TRUE@@MAKEINSTALL_DO_SETUID_TRUE@    chmod 4755 
$(DESTDIR)$(bindir)/mount
+@BUILD_MOUNT_TRUE@@MAKEINSTALL_DO_SETUID_TRUE@    chown root:root 
$(DESTDIR)$(bindir)/umount
 @BUILD_MOUNT_TRUE@@MAKEINSTALL_DO_SETUID_TRUE@    chmod 4755 
$(DESTDIR)$(bindir)/umount
 
 @BUILD_BASH_COMPLETION_TRUE@@BUILD_RUNUSER_TRUE@install-data-hook-bashcomp-runuser::


  reply	other threads:[~2017-06-06 17:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 23:07 Bug: mount doing bad security check: only root can use -types, (effective EUID is 5013) L A Walsh
2017-06-06  9:36 ` Karel Zak
2017-06-06 14:15   ` L A Walsh
2017-06-06 15:10     ` Karel Zak
2017-06-06 15:11     ` L A Walsh
2017-06-06 15:21       ` Tilman Schmidt
2017-06-06 16:03         ` Karel Zak
2017-06-06 16:10         ` L A Walsh
2017-06-06 17:12           ` L A Walsh [this message]
2017-06-20 11:14             ` Patch: ensure mount & umount are root-owned before setting SUID bit Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5936E292.4000709@tlinx.org \
    --to=lkml@tlinx.org \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.