From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932565AbcASQoG (ORCPT ); Tue, 19 Jan 2016 11:44:06 -0500 Received: from forward16p.cmail.yandex.net ([87.250.241.143]:41825 "EHLO forward16p.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbcASQn4 (ORCPT ); Tue, 19 Jan 2016 11:43:56 -0500 X-Greylist: delayed 322 seconds by postgrey-1.27 at vger.kernel.org; Tue, 19 Jan 2016 11:43:55 EST From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: Andreas Kemnade , "hns@goldelico.com" , Fabian Frederick , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" In-Reply-To: <1452948530-10639-1-git-send-email-andreas@kemnade.info> References: <1452948530-10639-1-git-send-email-andreas@kemnade.info> Subject: Re: [PATCH RESEND] omap_hdq: fix usecount handling MIME-Version: 1.0 Message-Id: <59381453221508@web14g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 19 Jan 2016 19:38:28 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andreas >>From w1 perspective this doesn't break things :) Greg, please pull it into your tree if no one objects. Acked-by: Evgeniy Polyakov 16.01.2016, 15:48, "Andreas Kemnade" : > hdq_usecount was set to zero after a successful read, so > omap_hdq_put could not properly free resources which leads > e.g. to increasing usecounts in lsmod output > > Signed-off-by: Andreas Kemnade > --- > šdrivers/w1/masters/omap_hdq.c | 1 - > š1 file changed, 1 deletion(-) > > diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c > index 0e2f43b..a2eec97 100644 > --- a/drivers/w1/masters/omap_hdq.c > +++ b/drivers/w1/masters/omap_hdq.c > @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq) > > šššššššššhdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS, > ššššššššššššššššššššššššššššššš~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK); > - hdq_data->hdq_usecount = 0; > > ššššššššš/* Write followed by a read, release the module */ > šššššššššif (hdq_data->init_trans) { > -- > 2.1.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evgeniy Polyakov Subject: Re: [PATCH RESEND] omap_hdq: fix usecount handling Date: Tue, 19 Jan 2016 19:38:28 +0300 Message-ID: <59381453221508@web14g.yandex.ru> References: <1452948530-10639-1-git-send-email-andreas@kemnade.info> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1452948530-10639-1-git-send-email-andreas@kemnade.info> Sender: linux-kernel-owner@vger.kernel.org To: Andreas Kemnade , "hns@goldelico.com" , Fabian Frederick , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" List-Id: linux-omap@vger.kernel.org Hi Andreas =46rom w1 perspective this doesn't break things :) Greg, please pull it into your tree if no one objects. Acked-by: Evgeniy Polyakov 16.01.2016, 15:48, "Andreas Kemnade" : > hdq_usecount was set to zero after a successful read, so > omap_hdq_put could not properly free resources which leads > e.g. to increasing usecounts in lsmod output > > Signed-off-by: Andreas Kemnade > --- > =9Adrivers/w1/masters/omap_hdq.c | 1 - > =9A1 file changed, 1 deletion(-) > > diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_= hdq.c > index 0e2f43b..a2eec97 100644 > --- a/drivers/w1/masters/omap_hdq.c > +++ b/drivers/w1/masters/omap_hdq.c > @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq) > > =9A=9A=9A=9A=9A=9A=9A=9A=9Ahdq_disable_interrupt(hdq_data, OMAP_HDQ_C= TRL_STATUS, > =9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A=9A= =9A=9A=9A=9A=9A=9A=9A=9A~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK); > - hdq_data->hdq_usecount =3D 0; > > =9A=9A=9A=9A=9A=9A=9A=9A=9A/* Write followed by a read, release the m= odule */ > =9A=9A=9A=9A=9A=9A=9A=9A=9Aif (hdq_data->init_trans) { > -- > 2.1.4