All of lore.kernel.org
 help / color / mirror / Atom feed
From: Langer Thomas (LQDE RD ST PON SW) <thomas.langer@lantiq.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Pull request: u-boot-net.git master
Date: Tue, 11 Dec 2012 23:47:51 +0000	[thread overview]
Message-ID: <593AEF6C47F46446852B067021A273D660C3348E@MUCSE039.lantiq.com> (raw)
In-Reply-To: <CANr=Z=bxE=7RT8AUmYC++xOc-i4dexskkhAy4B4wfuTfTUBn8w@mail.gmail.com>

Hello Joe,

> Tomas Hlavacek (67):
>       net: dm: Pull out ops from struct eth_device
>       net: 4xx_enet: Pull out init of struct eth_ops
>       net: altera_tse: Pull out init of struct eth_ops
>       net: dm9000x: Pull out init of struct eth_ops
>       net: armada100_fec: Pull out init of struct eth_ops
>       net: at91_emac: Pull out init of struct eth_ops
>       net: ax88180: Pull out init of struct eth_ops
>       net: bfin_mac: Pull out init of struct eth_ops
>       net: calxedaxgmac: Pull out init of struct eth_ops
>       net: cs8900: Pull out init of struct eth_ops
>       net: davinci_emac: Pull out init of struct eth_ops
>       net: dc2114x: Pull out init of struct eth_ops
>       net: designware: Pull out init of struct eth_ops
>       net: dnet: Pull out init of struct eth_ops
>       net: e1000: Pull out init of struct eth_ops
>       net: eepro100: Pull out init of struct eth_ops
>       net: enc28j60: Pull out init of struct eth_ops
>       net: ep93xx_eth: Pull out init of struct eth_ops
>       net: ethoc: Pull out init of struct eth_ops
>       net: fec_mxc: Pull out init of struct eth_ops
>       net: ftgmac100: Pull out init of struct eth_ops
>       net: greth.c: Pull out init of struct eth_ops
>       net: fsl_mcdmafec: Pull out init of struct eth_ops
>       net: inca-ip_sw: Pull out init of struct eth_ops
>       net: ks8695eth: Pull out init of struct eth_ops
>       net: lan91c96: Pull out init of struct eth_ops
>       net: macb: Pull out init of struct eth_ops
>       net: mcffec: Pull out init of struct eth_ops
>       net: mpc5xxx_fec: Pull out init of struct eth_ops
>       net: mvgbe: Pull out init of struct eth_ops
>       net: mpc512x_fec: Pull out init of struct eth_ops
>       net: natsemi: Pull out init of struct eth_ops
>       net: ne2000: Pull out init of struct eth_ops
>       net: npe: Pull out init of struct eth_ops
>       net: ns8382x: Pull out init of struct eth_ops
>       net: pcnet: Pull out init of struct eth_ops
>       net: plb2800_eth: Pull out init of struct eth_ops
>       net: rtl8139: Pull out init of struct eth_ops
>       net: rtl8169: Pull out init of struct eth_ops
>       net: smc91111: Pull out init of struct eth_ops
>       net: smc911x: Pull out init of struct eth_ops
>       net: tsec: Pull out init of struct eth_ops
>       net: tsi108_eth: Pull out init of struct eth_ops
>       net: uli526x: Pull out init of struct eth_ops
>       net: xilinx_axi_emac: Pull out init of struct eth_ops
>       net: xilinx_emaclite: Pull out init of struct eth_ops
>       net: zynq_gem: Pull out init of struct eth_ops
>       net: xilinx_ll_temac: Pull out init of struct eth_ops
>       net: sh_eth: Pull out init of struct eth_ops
>       net: au1x00_eth: Pull out init of struct eth_ops
>       net: mpc8220_fec: Pull out init of struct eth_ops
>       net: mpc8260_fec: Pull out init of struct eth_ops
>       net: mpc8260_scc: Pull out init of struct eth_ops
>       net: mpc85xx_fec: Pull out init of struct eth_ops
>       net: mpc8xx_scc: Pull out init of struct eth_ops
>       net: db64360/mv_eth: Pull out init of struct eth_ops
>       net: mpc8xx_fec: Pull out init of struct eth_ops
>       net: db64460/mv_eth: Pull out init of struct eth_ops
>       net: cpci750/mv_eth: Pull out init of struct eth_ops
>       net: evb64260: Pull out init of struct eth_ops
>       net: p3mx/mv_eth: Pull out init of struct eth_ops
>       net: cpsw: Pull out init of struct eth_ops
>       net: fm_eth: Pull out init of struct eth_ops
>       net: ftmac100: Pull out init of struct eth_ops
>       net: qe: uec: Pull out init of struct eth_ops
>       net: usb: asix: Pull out init of struct eth_ops
>       net: usb: smsc95xx: Pull out init of struct eth_ops

These patches for static initialization of the struct eth_ops will break the drivers on any architecture which needs manual relocation!

I've send a comment regarding this, please see here:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/146092/focus=147607

The tests with QEMU are insufficient, as probably the memory locations before relocation were still available and used via the 
uncorrected pointers.

So please consider to revoke the pull request until an update with fixes for the "eth_ops" series is available.

Best Regards,
Thomas

  reply	other threads:[~2012-12-11 23:47 UTC|newest]

Thread overview: 176+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 19:38 [U-Boot] Pull request: u-boot-net.git master Joe Hershberger
2012-12-11 23:47 ` Langer Thomas [this message]
2012-12-12  3:42   ` Joe Hershberger
2012-12-12 13:16     ` Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2019-09-04 16:42 Joe Hershberger
2019-09-05 13:24 ` Tom Rini
2019-07-25 18:38 Joe Hershberger
2019-07-26 19:37 ` Tom Rini
2019-07-26 19:39   ` Joe Hershberger
2019-07-18 21:38 Joe Hershberger
2019-07-23 13:46 ` Tom Rini
2019-07-15 22:49 Joe Hershberger
2019-07-16 14:57 ` Tom Rini
2019-06-01 23:10 Joe Hershberger
2019-06-02 20:03 ` Tom Rini
2019-05-14 19:57 Joe Hershberger
2019-05-15 17:42 ` Tom Rini
2019-05-08 22:30 Joe Hershberger
2019-05-09 22:25 ` Tom Rini
2019-05-07 22:09 Joe Hershberger
2019-05-08 22:24 ` Joe Hershberger
2019-05-08 22:37   ` Tom Rini
2019-05-08 22:40   ` [U-Boot] [EXT] " Vladimir Oltean
2019-05-08 22:42     ` Tom Rini
2019-05-08 22:45       ` [U-Boot] " Vladimir Oltean
2019-05-08 22:48         ` Tom Rini
2019-05-08 22:52           ` Vladimir Oltean
2019-05-08 22:54             ` Tom Rini
2019-05-08 23:05               ` Vladimir Oltean
2019-05-09  2:38                 ` Tom Rini
2019-05-09 12:51                 ` Vladimir Oltean
2019-05-10 21:50                   ` Joe Hershberger
2019-05-15 14:58                     ` Tom Rini
2019-07-25 22:40                       ` Vladimir Oltean
2019-07-25 23:12                         ` Tom Rini
2019-11-02 13:17                       ` Michael Walle
2019-11-02 14:12                         ` Tom Rini
2019-11-02 14:30                           ` Vladimir Oltean
2019-11-02 15:05                             ` Tom Rini
2019-11-03 15:22                               ` Michael Walle
2019-03-12 18:15 Joe Hershberger
2019-03-19 22:41 ` Tom Rini
2019-04-30 21:15   ` Joe Hershberger
2019-04-30 21:28     ` Tom Rini
2019-05-01  0:56       ` Joe Hershberger
2019-05-01  1:19         ` Tom Rini
2019-03-05 18:02 Joe Hershberger
2019-03-07 14:15 ` Tom Rini
2019-01-24 17:35 Joe Hershberger
2019-01-25 15:16 ` Tom Rini
2018-11-05 17:51 Joe Hershberger
2018-11-06  4:06 ` Tom Rini
2018-11-06 20:58   ` Joe Hershberger
2018-10-24 19:45 Joe Hershberger
2018-10-26 11:52 ` Tom Rini
2018-10-26 12:24   ` Stefano Babic
2018-10-26 12:40     ` Tom Rini
2018-10-26 13:04   ` Anatolij Gustschin
2018-10-26 14:46   ` York Sun
2018-10-26 16:45 ` Tom Rini
2018-10-11 19:23 Joe Hershberger
2018-10-12 15:52 ` Tom Rini
2018-07-26 19:12 Joe Hershberger
2018-07-27 17:09 ` Tom Rini
2018-07-02 19:49 Joe Hershberger
2018-07-02 19:57 ` Tom Rini
2018-07-02 20:09   ` Joe Hershberger
2018-07-03  3:24 ` Tom Rini
2018-06-13 19:00 Joe Hershberger
2018-06-14 15:36 ` Tom Rini
2018-04-15  4:18 Joe Hershberger
2018-04-15 17:52 ` Tom Rini
2018-03-22 20:39 Joe Hershberger
2018-03-23  1:21 ` Tom Rini
2018-02-27 17:17 Joe Hershberger
2018-02-28  3:41 ` Tom Rini
2018-01-15 18:06 Joe Hershberger
2018-01-16  2:25 ` Tom Rini
2018-01-17 18:46   ` Joe Hershberger
2018-01-03 21:32 Joe Hershberger
2018-01-04  1:09 ` Tom Rini
2018-01-04 17:56   ` Joe Hershberger
2018-01-09 18:06 ` Tom Rini
2018-01-15 18:10   ` Joe Hershberger
2018-01-15 18:13     ` Tom Rini
2018-01-15 18:15       ` Joe Hershberger
2018-01-15 18:22         ` Tom Rini
2018-01-15 18:23           ` Joe Hershberger
2017-09-07 18:29 Joe Hershberger
2017-09-08  0:02 ` Tom Rini
2017-08-14 17:48 Joe Hershberger
2017-08-15  0:03 ` Tom Rini
2017-08-07 20:30 Joe Hershberger
2017-08-08 21:03 ` Tom Rini
2017-06-02 19:45 Joe Hershberger
2017-06-04 17:11 ` Tom Rini
2017-03-27 16:50 Joe Hershberger
2017-04-04 19:59 ` Tom Rini
2017-03-07 20:01 Joe Hershberger
2017-03-08 17:48 ` Tom Rini
2017-02-09 16:25 Joe Hershberger
2017-02-09 19:50 ` Tom Rini
2016-12-08 16:37 Joe Hershberger
2016-12-09 12:12 ` Tom Rini
2016-12-09 16:22   ` Joe Hershberger
2016-12-09 17:43     ` Michal Simek
2016-12-09 18:35       ` Joe Hershberger
2016-12-09 19:09         ` Michal Simek
2016-12-09 19:52         ` Tom Rini
2016-11-07 17:29 Joe Hershberger
2016-11-08 20:52 ` Tom Rini
2016-10-13 17:34 Joe Hershberger
2016-10-13 22:45 ` Tom Rini
2016-09-09 18:52 Joe Hershberger
2016-09-09 19:53 ` Tom Rini
2016-08-23  2:26 Joe Hershberger
2016-08-24 15:32 ` Tom Rini
2016-08-15 20:30 Joe Hershberger
2016-08-16  1:09 ` Tom Rini
2016-08-15 20:20 Joe Hershberger
2016-08-15 20:26 ` Joe Hershberger
2016-07-06 15:46 Joe Hershberger
2016-07-08  2:50 ` Tom Rini
2016-06-21 22:04 Joe Hershberger
2016-06-22 14:38 ` Tom Rini
2016-05-24 16:50 Joe Hershberger
2016-05-24 23:18 ` Tom Rini
2016-05-03 22:58 Joe Hershberger
2016-05-04  1:35 ` Tom Rini
2016-05-03 20:01 Joe Hershberger
2016-05-03 21:34 ` Tom Rini
2016-05-03 21:49   ` Joe Hershberger
2016-02-26 19:42 Joe Hershberger
2016-02-28  1:19 ` Tom Rini
2016-02-18 17:39 Joe Hershberger
2016-02-20  0:54 ` Tom Rini
2016-01-28 23:32 Joe Hershberger
2016-02-09 17:01 ` Tom Rini
2015-10-29 19:34 Joe Hershberger
2015-10-30  2:09 ` Tom Rini
2015-09-30 17:23 Joe Hershberger
2015-10-03  0:35 ` Tom Rini
2015-08-21 21:48 Joe Hershberger
2015-08-24 13:44 ` Tom Rini
2015-08-12 19:37 Joe Hershberger
2015-08-13 13:16 ` Tom Rini
2015-06-01 18:24 Joe Hershberger
2015-06-02 12:55 ` Tom Rini
2015-05-26 17:24 Joe Hershberger
2015-05-27  2:02 ` Tom Rini
2015-05-27 16:17   ` Joe Hershberger
2015-05-19 18:56 Joe Hershberger
2015-05-20 11:28 ` Tom Rini
2015-05-20 17:11   ` Joe Hershberger
2015-05-21 13:09     ` Tom Rini
2015-05-21 13:50       ` Joe Hershberger
2015-04-20 23:08 Joe Hershberger
2015-04-21 14:06 ` Tom Rini
2015-01-30 22:01 Joe Hershberger
2015-02-02 18:59 ` Tom Rini
2014-01-14 19:12 Joe Hershberger
2014-01-14 21:01 ` Tom Rini
2013-11-22 23:08 Joe Hershberger
2013-11-25 21:56 ` Tom Rini
2013-08-19 17:39 Joe Hershberger
2013-08-19 21:59 ` Tom Rini
2013-06-25  0:21 Joe Hershberger
2013-06-25 14:55 ` Tom Rini
2012-12-15 18:41 Joe Hershberger
2012-12-18 19:59 ` Tom Rini
2012-09-27 17:38 Joe Hershberger
2012-09-27 20:05 ` Tom Rini
2012-07-24 19:19 Joe Hershberger
2012-07-26  8:57 ` Wolfgang Denk
2012-07-19 16:54 Joe Hershberger
2012-07-20  6:57 ` Wolfgang Denk
2012-05-23 19:36 Joe Hershberger
2012-05-24 19:24 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=593AEF6C47F46446852B067021A273D660C3348E@MUCSE039.lantiq.com \
    --to=thomas.langer@lantiq.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.