From: "Pei, Andy" <andy.pei@intel.com>
To: "Xu, Rosen" <rosen.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] raw/ifpga: fix unintentional integer overflow
Date: Thu, 23 May 2019 02:52:51 +0000 [thread overview]
Message-ID: <5941F446C088714A85408FA3132CFCBB010191FC@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A76EA2C@SHSMSX104.ccr.corp.intel.com>
Hi Rosen,
I use git send-email for internal check, I seems I should not cc you and stable@dpdk.
-----Original Message-----
From: Xu, Rosen
Sent: Thursday, May 23, 2019 10:11 AM
To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
Cc: stable@dpdk.org
Subject: RE: [PATCH] raw/ifpga: fix unintentional integer overflow
Hi Andy,
Why you sent this patch two times?
> -----Original Message-----
> From: Pei, Andy
> Sent: Wednesday, May 22, 2019 14:43
> To: dev@dpdk.org
> Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] raw/ifpga: fix unintentional integer overflow
>
> cast unsigned int ports_per_retimer, unsigned int nums_retimer,
> unsigned int nums_fvl and unsigned int ports_per_fvl to uint64_t
> before multiply operation, to avoid Unintentional integer overflow.
>
> Coverity issue: 337924, 337926
> Fixes: d1cd4eb2d48e ("raw/ifpga: support ipn3ke")
> Cc: rosen.xu@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> index 41be1a2..9c68666 100644
> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -494,8 +494,8 @@
> if (!strcmp(attr_name, "LineSideLinkPortNum")) {
> if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
> return -1;
> - uint64_t tmp = opae_rtm_info.ports_per_retimer *
> - opae_rtm_info.nums_retimer;
> + uint64_t tmp = (uint64_t)opae_rtm_info.ports_per_retimer *
> +
> (uint64_t)opae_rtm_info.nums_retimer;
> *attr_value = tmp;
> return 0;
> }
> @@ -547,8 +547,8 @@
> if (!strcmp(attr_name, "NICSideLinkPortNum")) {
> if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
> return -1;
> - uint64_t tmp = opae_rtm_info.nums_fvl *
> - opae_rtm_info.ports_per_fvl;
> + uint64_t tmp = (uint64_t)opae_rtm_info.nums_fvl *
> +
> (uint64_t)opae_rtm_info.ports_per_fvl;
> *attr_value = tmp;
> return 0;
> }
> --
> 1.8.3.1
next prev parent reply other threads:[~2019-05-23 2:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 6:42 [dpdk-dev] [PATCH] raw/ifpga: fix unintentional integer overflow Andy Pei
2019-05-23 2:11 ` Xu, Rosen
2019-05-23 2:52 ` Pei, Andy [this message]
2019-05-23 3:00 ` Xu, Rosen
2019-07-04 7:16 ` Pei, Andy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5941F446C088714A85408FA3132CFCBB010191FC@SHSMSX105.ccr.corp.intel.com \
--to=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.