All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	SELinux <selinux@tycho.nsa.gov>, Paul Moore <paul@paul-moore.com>
Subject: Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #2]
Date: Thu, 18 Jun 2015 19:23:28 +0100	[thread overview]
Message-ID: <5947.1434651808@warthog.procyon.org.uk> (raw)
In-Reply-To: <5583007A.8040704@tycho.nsa.gov>

Stephen Smalley <sds@tycho.nsa.gov> wrote:

> >> +	rc = selinux_determine_inode_label(d_inode(dentry), name,
> > 
> > We want d_inode(dentry->d_parent) here.
> 
> Not sure why the caller didn't just pass in the dir inode in the first
> place.

Might be something in one of the other LSMs?

David

WARNING: multiple messages have this Message-ID
From: David Howells <dhowells@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	dhowells@redhat.com, linux-security-module@vger.kernel.org,
	SELinux <selinux@tycho.nsa.gov>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #2]
Date: Thu, 18 Jun 2015 19:23:28 +0100	[thread overview]
Message-ID: <5947.1434651808@warthog.procyon.org.uk> (raw)
In-Reply-To: <5583007A.8040704@tycho.nsa.gov>

Stephen Smalley <sds@tycho.nsa.gov> wrote:

> >> +	rc = selinux_determine_inode_label(d_inode(dentry), name,
> > 
> > We want d_inode(dentry->d_parent) here.
> 
> Not sure why the caller didn't just pass in the dir inode in the first
> place.

Might be something in one of the other LSMs?

David

  parent reply	other threads:[~2015-06-18 18:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 16:41 David Howells
2015-06-18 16:41 ` David Howells
2015-06-18 17:08 ` Stephen Smalley
2015-06-18 17:08   ` Stephen Smalley
2015-06-18 17:31   ` Stephen Smalley
2015-06-18 17:31     ` Stephen Smalley
2015-06-18 18:23   ` David Howells [this message]
2015-06-18 18:23     ` David Howells
2015-06-18 18:22 ` David Howells
2015-06-18 18:22   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5947.1434651808@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    --subject='Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #2]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.