From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752920AbdFUAtE (ORCPT ); Tue, 20 Jun 2017 20:49:04 -0400 Received: from regular1.263xmail.com ([211.150.99.133]:55820 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592AbdFUAtD (ORCPT ); Tue, 20 Jun 2017 20:49:03 -0400 X-263anti-spam: BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <73b7ec7a0f38e5b8de0532c79547f535> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures To: Bhumika Goyal , julia.lawall@lip6.fr, maxime.ripard@free-electrons.com, airlied@linux.ie, wens@csie.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org References: <1497964080-27301-1-git-send-email-bhumirks@gmail.com> <1497964080-27301-2-git-send-email-bhumirks@gmail.com> From: Mark yao Message-ID: <5949C274.6050806@rock-chips.com> Date: Wed, 21 Jun 2017 08:48:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1497964080-27301-2-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年06月20日 21:07, Bhumika Goyal wrote: > Add const to drm_encoder_helper_funcs structures as they are only passed > as an argument to the function drm_encoder_helper_add and this argument > is of type const. So, add const to these structures. Also, fix line over > 80 characters warning while adding const. > > Signed-off-by: Bhumika Goyal > --- > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 3 ++- > drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index 9606121..96c6c10 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -252,7 +252,8 @@ rockchip_dp_drm_encoder_atomic_check(struct drm_encoder *encoder, > return 0; > } > > -static struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = { > +static > +const struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = { I don't think split static and const into two line is a good idea, it's ugly. I'm ok over 80 characters with good-looking. Or split like following: static const struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = { > .mode_fixup = rockchip_dp_drm_encoder_mode_fixup, > .mode_set = rockchip_dp_drm_encoder_mode_set, > .enable = rockchip_dp_drm_encoder_enable, > diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c > index 7d9b75e..4ab9fad 100644 > --- a/drivers/gpu/drm/rockchip/inno_hdmi.c > +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c > @@ -530,7 +530,7 @@ inno_hdmi_encoder_atomic_check(struct drm_encoder *encoder, > return 0; > } > > -static struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = { > +static const struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = { > .enable = inno_hdmi_encoder_enable, > .disable = inno_hdmi_encoder_disable, > .mode_fixup = inno_hdmi_encoder_mode_fixup, Thanks -- Ｍark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures Date: Wed, 21 Jun 2017 08:48:52 +0800 Message-ID: <5949C274.6050806@rock-chips.com> References: <1497964080-27301-1-git-send-email-bhumirks@gmail.com> <1497964080-27301-2-git-send-email-bhumirks@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1497964080-27301-2-git-send-email-bhumirks@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bhumika Goyal , julia.lawall@lip6.fr, maxime.ripard@free-electrons.com, airlied@linux.ie, wens@csie.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxN+W5tDA25pyIMjDml6UgMjE6MDcsIEJodW1pa2EgR295YWwgd3JvdGU6Cj4gQWRkIGNv bnN0IHRvIGRybV9lbmNvZGVyX2hlbHBlcl9mdW5jcyBzdHJ1Y3R1cmVzIGFzIHRoZXkgYXJlIG9u bHkgcGFzc2VkCj4gYXMgYW4gYXJndW1lbnQgdG8gdGhlIGZ1bmN0aW9uIGRybV9lbmNvZGVyX2hl bHBlcl9hZGQgYW5kIHRoaXMgYXJndW1lbnQKPiBpcyBvZiB0eXBlIGNvbnN0LiBTbywgYWRkIGNv bnN0IHRvIHRoZXNlIHN0cnVjdHVyZXMuIEFsc28sIGZpeCBsaW5lIG92ZXIKPiA4MCBjaGFyYWN0 ZXJzIHdhcm5pbmcgd2hpbGUgYWRkaW5nIGNvbnN0Lgo+Cj4gU2lnbmVkLW9mZi1ieTogQmh1bWlr YSBHb3lhbCA8Ymh1bWlya3NAZ21haWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlwLmMgfCAzICsrLQo+ICAgZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL2lubm9faGRtaS5jICAgICAgICAgICAgfCAyICstCj4gICAyIGZpbGVzIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvYW5hbG9naXhfZHAtcm9ja2NoaXAuYyBiL2RyaXZlcnMvZ3B1 L2RybS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC5jCj4gaW5kZXggOTYwNjEyMS4uOTZj NmMxMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvYW5hbG9naXhfZHAt cm9ja2NoaXAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1y b2NrY2hpcC5jCj4gQEAgLTI1Miw3ICsyNTIsOCBAQCByb2NrY2hpcF9kcF9kcm1fZW5jb2Rlcl9h dG9taWNfY2hlY2soc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+ICAgCXJldHVybiAwOwo+ ICAgfQo+ICAgCj4gLXN0YXRpYyBzdHJ1Y3QgZHJtX2VuY29kZXJfaGVscGVyX2Z1bmNzIHJvY2tj aGlwX2RwX2VuY29kZXJfaGVscGVyX2Z1bmNzID0gewo+ICtzdGF0aWMKPiArY29uc3Qgc3RydWN0 IGRybV9lbmNvZGVyX2hlbHBlcl9mdW5jcyByb2NrY2hpcF9kcF9lbmNvZGVyX2hlbHBlcl9mdW5j cyA9IHsKCkkgZG9uJ3QgdGhpbmsgc3BsaXQgc3RhdGljIGFuZCBjb25zdCBpbnRvIHR3byBsaW5l IGlzIGEgZ29vZCBpZGVhLCBpdCdzIAp1Z2x5LiBJJ20gb2sgb3ZlciA4MCBjaGFyYWN0ZXJzIHdp dGggZ29vZC1sb29raW5nLgpPciBzcGxpdCBsaWtlIGZvbGxvd2luZzoKc3RhdGljIGNvbnN0IHN0 cnVjdCBkcm1fZW5jb2Rlcl9oZWxwZXJfZnVuY3MKcm9ja2NoaXBfZHBfZW5jb2Rlcl9oZWxwZXJf ZnVuY3MgPSB7Cgo+ICAgCS5tb2RlX2ZpeHVwID0gcm9ja2NoaXBfZHBfZHJtX2VuY29kZXJfbW9k ZV9maXh1cCwKPiAgIAkubW9kZV9zZXQgPSByb2NrY2hpcF9kcF9kcm1fZW5jb2Rlcl9tb2RlX3Nl dCwKPiAgIAkuZW5hYmxlID0gcm9ja2NoaXBfZHBfZHJtX2VuY29kZXJfZW5hYmxlLAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvaW5ub19oZG1pLmMgYi9kcml2ZXJzL2dw dS9kcm0vcm9ja2NoaXAvaW5ub19oZG1pLmMKPiBpbmRleCA3ZDliNzVlLi40YWI5ZmFkIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9pbm5vX2hkbWkuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9pbm5vX2hkbWkuYwo+IEBAIC01MzAsNyArNTMwLDcgQEAg aW5ub19oZG1pX2VuY29kZXJfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2Rl ciwKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgc3RydWN0IGRybV9lbmNvZGVy X2hlbHBlcl9mdW5jcyBpbm5vX2hkbWlfZW5jb2Rlcl9oZWxwZXJfZnVuY3MgPSB7Cj4gK3N0YXRp YyBjb25zdCBzdHJ1Y3QgZHJtX2VuY29kZXJfaGVscGVyX2Z1bmNzIGlubm9faGRtaV9lbmNvZGVy X2hlbHBlcl9mdW5jcyA9IHsKPiAgIAkuZW5hYmxlICAgICA9IGlubm9faGRtaV9lbmNvZGVyX2Vu YWJsZSwKPiAgIAkuZGlzYWJsZSAgICA9IGlubm9faGRtaV9lbmNvZGVyX2Rpc2FibGUsCj4gICAJ Lm1vZGVfZml4dXAgPSBpbm5vX2hkbWlfZW5jb2Rlcl9tb2RlX2ZpeHVwLAoKVGhhbmtzCgotLSAK 77ytYXJrIFlhbwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Wed, 21 Jun 2017 08:48:52 +0800 Subject: [PATCH 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures In-Reply-To: <1497964080-27301-2-git-send-email-bhumirks@gmail.com> References: <1497964080-27301-1-git-send-email-bhumirks@gmail.com> <1497964080-27301-2-git-send-email-bhumirks@gmail.com> Message-ID: <5949C274.6050806@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2017?06?20? 21:07, Bhumika Goyal wrote: > Add const to drm_encoder_helper_funcs structures as they are only passed > as an argument to the function drm_encoder_helper_add and this argument > is of type const. So, add const to these structures. Also, fix line over > 80 characters warning while adding const. > > Signed-off-by: Bhumika Goyal > --- > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 3 ++- > drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index 9606121..96c6c10 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -252,7 +252,8 @@ rockchip_dp_drm_encoder_atomic_check(struct drm_encoder *encoder, > return 0; > } > > -static struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = { > +static > +const struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = { I don't think split static and const into two line is a good idea, it's ugly. I'm ok over 80 characters with good-looking. Or split like following: static const struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = { > .mode_fixup = rockchip_dp_drm_encoder_mode_fixup, > .mode_set = rockchip_dp_drm_encoder_mode_set, > .enable = rockchip_dp_drm_encoder_enable, > diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c > index 7d9b75e..4ab9fad 100644 > --- a/drivers/gpu/drm/rockchip/inno_hdmi.c > +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c > @@ -530,7 +530,7 @@ inno_hdmi_encoder_atomic_check(struct drm_encoder *encoder, > return 0; > } > > -static struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = { > +static const struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = { > .enable = inno_hdmi_encoder_enable, > .disable = inno_hdmi_encoder_disable, > .mode_fixup = inno_hdmi_encoder_mode_fixup, Thanks -- ?ark Yao