From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: [PATCH 04/11] domctl: restrict DOMCTL_set_target to HVM
 domains
Date: Wed, 21 Jun 2017 03:33:31 -0600
Message-ID: <594A598B0200007800165056@prv-mh.provo.novell.com>
References: <594A57B10200007800165012@prv-mh.provo.novell.com>
 <594A57B10200007800165012@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=__Part3D05237B.3__="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <JBeulich@suse.com>) id 1dNc11-0008GB-Sb
 for xen-devel@lists.xenproject.org; Wed, 21 Jun 2017 09:33:35 +0000
In-Reply-To: <594A57B10200007800165012@prv-mh.provo.novell.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

This is a MIME message. If you are reading this text, you may want to 
consider changing to a mail reader or gateway that understands how to 
properly handle MIME multipart messages.

--=__Part3D05237B.3__=
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Both the XSA-217 fix and
lists.xenproject.org/archives/html/xen-devel/2017-04/msg02945.html
make this assumption, so let's enforce it.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -1071,7 +1071,9 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
             break;
         }
=20
-        ret =3D xsm_set_target(XSM_HOOK, d, e);
+        ret =3D -EOPNOTSUPP;
+        if ( is_hvm_domain(e) )
+            ret =3D xsm_set_target(XSM_HOOK, d, e);
         if ( ret ) {
             put_domain(e);
             break;




--=__Part3D05237B.3__=
Content-Type: text/plain; name="domctl-set-target-HVM.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment; filename="domctl-set-target-HVM.patch"

domctl: restrict DOMCTL_set_target to HVM domains=0A=0ABoth the XSA-217 =
fix and=0Alists.xenproject.org/archives/html/xen-devel/2017-04/msg02945.htm=
l=0Amake this assumption, so let's enforce it.=0A=0ASigned-off-by: Jan =
Beulich <jbeulich@suse.com>=0A=0A--- a/xen/common/domctl.c=0A+++ b/xen/comm=
on/domctl.c=0A@@ -1071,7 +1071,9 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(x=
e=0A             break;=0A         }=0A =0A-        ret =3D xsm_set_target(=
XSM_HOOK, d, e);=0A+        ret =3D -EOPNOTSUPP;=0A+        if ( is_hvm_dom=
ain(e) )=0A+            ret =3D xsm_set_target(XSM_HOOK, d, e);=0A         =
if ( ret ) {=0A             put_domain(e);=0A             break;=0A
--=__Part3D05237B.3__=
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--=__Part3D05237B.3__=--