From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy Subject: Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices Date: Thu, 22 Jun 2017 10:33:47 +0800 Message-ID: <594B2C8B.3000401@rock-chips.com> References: <1498039313-24220-1-git-send-email-jeffy.chen@rock-chips.com> <1498039313-24220-4-git-send-email-jeffy.chen@rock-chips.com> <594A91C9.1090906@rock-chips.com> <20170621153632.7cajs5xwdmhdm2fg@kozik-lap> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170621153632.7cajs5xwdmhdm2fg@kozik-lap> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Kukjin Kim , Thierry Reding , Heiko Stuebner , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jonathan Hunter , Catalin Marinas , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Will Deacon , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Rutland List-Id: linux-tegra@vger.kernel.org Hi Krzysztof, thanx for noting that, will add it to next version :) On 06/21/2017 11:36 PM, Krzysztof Kozlowski wrote: > On Wed, Jun 21, 2017 at 11:33:29PM +0800, jeffy wrote: >> Hi Krzysztof, >> >> thanx for your comment. >> >> On 06/21/2017 06:45 PM, Krzysztof Kozlowski wrote: >>> On Wed, Jun 21, 2017 at 12:01 PM, Jeffy Chen wrote: >>>> We used to enable wakeup for cros-ec-spi devices unconditionally. >>>> Now we are using the more generic wakeup-source property to enable it. >>> >>> Using wakeup-source property is still enabling this unconditionally. >>> What do you exactly mean here? >> i mean the wakeup-source is an optional property, we can disable wakeup by >> not adding it. > > Maybe mention this in commit msg? This removes any confusion. "Till now > the driver always enabled wakeup but now it supports wakeup property so > add it to keep same functionality." > > Best regards, > Krzysztof > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752452AbdFVCeL (ORCPT ); Wed, 21 Jun 2017 22:34:11 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:58544 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbdFVCeJ (ORCPT ); Wed, 21 Jun 2017 22:34:09 -0400 X-263anti-spam: BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: krzk@kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <76bf829315f59baf6bd98a145c233ea9> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <594B2C8B.3000401@rock-chips.com> Date: Thu, 22 Jun 2017 10:33:47 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Krzysztof Kozlowski CC: linux-kernel@vger.kernel.org, briannorris@chromium.org, dmitry.torokhov@gmail.com, dianders@chromium.org, Kukjin Kim , Thierry Reding , Heiko Stuebner , devicetree@vger.kernel.org, Jonathan Hunter , Catalin Marinas , linux-tegra@vger.kernel.org, Russell King , linux-samsung-soc@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Will Deacon , linux-rockchip@lists.infradead.org, Mark Rutland Subject: Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices References: <1498039313-24220-1-git-send-email-jeffy.chen@rock-chips.com> <1498039313-24220-4-git-send-email-jeffy.chen@rock-chips.com> <594A91C9.1090906@rock-chips.com> <20170621153632.7cajs5xwdmhdm2fg@kozik-lap> In-Reply-To: <20170621153632.7cajs5xwdmhdm2fg@kozik-lap> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, thanx for noting that, will add it to next version :) On 06/21/2017 11:36 PM, Krzysztof Kozlowski wrote: > On Wed, Jun 21, 2017 at 11:33:29PM +0800, jeffy wrote: >> Hi Krzysztof, >> >> thanx for your comment. >> >> On 06/21/2017 06:45 PM, Krzysztof Kozlowski wrote: >>> On Wed, Jun 21, 2017 at 12:01 PM, Jeffy Chen wrote: >>>> We used to enable wakeup for cros-ec-spi devices unconditionally. >>>> Now we are using the more generic wakeup-source property to enable it. >>> >>> Using wakeup-source property is still enabling this unconditionally. >>> What do you exactly mean here? >> i mean the wakeup-source is an optional property, we can disable wakeup by >> not adding it. > > Maybe mention this in commit msg? This removes any confusion. "Till now > the driver always enabled wakeup but now it supports wakeup property so > add it to keep same functionality." > > Best regards, > Krzysztof > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy.chen@rock-chips.com (jeffy) Date: Thu, 22 Jun 2017 10:33:47 +0800 Subject: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices In-Reply-To: <20170621153632.7cajs5xwdmhdm2fg@kozik-lap> References: <1498039313-24220-1-git-send-email-jeffy.chen@rock-chips.com> <1498039313-24220-4-git-send-email-jeffy.chen@rock-chips.com> <594A91C9.1090906@rock-chips.com> <20170621153632.7cajs5xwdmhdm2fg@kozik-lap> Message-ID: <594B2C8B.3000401@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Krzysztof, thanx for noting that, will add it to next version :) On 06/21/2017 11:36 PM, Krzysztof Kozlowski wrote: > On Wed, Jun 21, 2017 at 11:33:29PM +0800, jeffy wrote: >> Hi Krzysztof, >> >> thanx for your comment. >> >> On 06/21/2017 06:45 PM, Krzysztof Kozlowski wrote: >>> On Wed, Jun 21, 2017 at 12:01 PM, Jeffy Chen wrote: >>>> We used to enable wakeup for cros-ec-spi devices unconditionally. >>>> Now we are using the more generic wakeup-source property to enable it. >>> >>> Using wakeup-source property is still enabling this unconditionally. >>> What do you exactly mean here? >> i mean the wakeup-source is an optional property, we can disable wakeup by >> not adding it. > > Maybe mention this in commit msg? This removes any confusion. "Till now > the driver always enabled wakeup but now it supports wakeup property so > add it to keep same functionality." > > Best regards, > Krzysztof > > > >