From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbdF0CES (ORCPT ); Mon, 26 Jun 2017 22:04:18 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:42358 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbdF0CER (ORCPT ); Mon, 26 Jun 2017 22:04:17 -0400 X-263anti-spam: BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: dmitry.torokhov@gmail.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <6ac844547c9c563e383afe00d4f71daa> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5951BD17.305@rock-chips.com> Date: Tue, 27 Jun 2017 10:04:07 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Dmitry Torokhov , Rob Herring CC: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org, Mark Brown , linux-spi@vger.kernel.org, Mark Rutland Subject: Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source optional property References: <1498039313-24220-1-git-send-email-jeffy.chen@rock-chips.com> <1498039313-24220-3-git-send-email-jeffy.chen@rock-chips.com> <20170626160011.qi3bliz5jt6d5wgb@rob-hp-laptop> <20170626164016.GA4965@dtor-ws> In-Reply-To: <20170626164016.GA4965@dtor-ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 06/27/2017 12:40 AM, Dmitry Torokhov wrote: > On Mon, Jun 26, 2017 at 11:00:11AM -0500, Rob Herring wrote: >> On Wed, Jun 21, 2017 at 06:01:49PM +0800, Jeffy Chen wrote: >>> Update document devicetree bindings to support "wakeup-source" property. >>> >>> Signed-off-by: Jeffy Chen >>> --- >>> >>> Changes in v3: None >>> >>> Documentation/devicetree/bindings/spi/spi-bus.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt >>> index 1f6e86f..0fa1ccf 100644 >>> --- a/Documentation/devicetree/bindings/spi/spi-bus.txt >>> +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt >>> @@ -77,6 +77,7 @@ All slave nodes can contain the following optional properties: >>> Defaults to 1 if not present. >>> - spi-rx-delay-us - Microsecond delay after a read transfer. >>> - spi-tx-delay-us - Microsecond delay after a write transfer. >>> +- wakeup-source - Device can be used as a wakeup source. >> >> wakeup-source is valid for any device with an interrupts property >> already, so I don't think this is necessary. i saw http://lkml.iu.edu/hypermail/linux/kernel/1510.2/04553.html add a Documentation/devicetree/bindings/power/wakeup-source.txt for this, but that serial didn't remove all wakeup-source property from other bindings, but standardize them, for example: 71a0151 Documentation: devicetree: fix reference to legacy wakeup properties +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt @@ -24,6 +24,7 @@ Optional subnode-properties: - debounce-interval: Debouncing interval time in milliseconds. If not specified defaults to 5. - wakeup-source: Boolean, button can wake-up the system. + (Legacy property supported: "gpio-key,wakeup") > > Do you mean it is not necessary on SPI level or not necessary at all? Or > you disagree with wording? Because we do need a way to say that on given > platform the device is supposed to be configured as a wakeup source. > > Thanks. > Hi guys, Mark Brown suggested to put wakeup-source support in some common place instead of sub drivers, should we do that? From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy Subject: Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source optional property Date: Tue, 27 Jun 2017 10:04:07 +0800 Message-ID: <5951BD17.305@rock-chips.com> References: <1498039313-24220-1-git-send-email-jeffy.chen@rock-chips.com> <1498039313-24220-3-git-send-email-jeffy.chen@rock-chips.com> <20170626160011.qi3bliz5jt6d5wgb@rob-hp-laptop> <20170626164016.GA4965@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170626164016.GA4965@dtor-ws> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Torokhov , Rob Herring Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Rutland List-Id: devicetree@vger.kernel.org Hi Rob, On 06/27/2017 12:40 AM, Dmitry Torokhov wrote: > On Mon, Jun 26, 2017 at 11:00:11AM -0500, Rob Herring wrote: >> On Wed, Jun 21, 2017 at 06:01:49PM +0800, Jeffy Chen wrote: >>> Update document devicetree bindings to support "wakeup-source" property. >>> >>> Signed-off-by: Jeffy Chen >>> --- >>> >>> Changes in v3: None >>> >>> Documentation/devicetree/bindings/spi/spi-bus.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt >>> index 1f6e86f..0fa1ccf 100644 >>> --- a/Documentation/devicetree/bindings/spi/spi-bus.txt >>> +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt >>> @@ -77,6 +77,7 @@ All slave nodes can contain the following optional properties: >>> Defaults to 1 if not present. >>> - spi-rx-delay-us - Microsecond delay after a read transfer. >>> - spi-tx-delay-us - Microsecond delay after a write transfer. >>> +- wakeup-source - Device can be used as a wakeup source. >> >> wakeup-source is valid for any device with an interrupts property >> already, so I don't think this is necessary. i saw http://lkml.iu.edu/hypermail/linux/kernel/1510.2/04553.html add a Documentation/devicetree/bindings/power/wakeup-source.txt for this, but that serial didn't remove all wakeup-source property from other bindings, but standardize them, for example: 71a0151 Documentation: devicetree: fix reference to legacy wakeup properties +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt @@ -24,6 +24,7 @@ Optional subnode-properties: - debounce-interval: Debouncing interval time in milliseconds. If not specified defaults to 5. - wakeup-source: Boolean, button can wake-up the system. + (Legacy property supported: "gpio-key,wakeup") > > Do you mean it is not necessary on SPI level or not necessary at all? Or > you disagree with wording? Because we do need a way to say that on given > platform the device is supposed to be configured as a wakeup source. > > Thanks. > Hi guys, Mark Brown suggested to put wakeup-source support in some common place instead of sub drivers, should we do that? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html