From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754927AbaGVNAI (ORCPT ); Tue, 22 Jul 2014 09:00:08 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:58767 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbaGVNAF (ORCPT ); Tue, 22 Jul 2014 09:00:05 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Chanwoo Choi , jic23@kernel.org, devicetree@vger.kernel.org, kgene.kim@samsung.com, linux-doc@vger.kernel.org, linux-iio@vger.kernel.org, t.figa@samsung.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, ch.naveen@samsung.com Subject: Re: [PATCH 2/2] iio: adc: exynos_adc: Add support for S3C24xx ADC Date: Tue, 22 Jul 2014 14:59:25 +0200 Message-ID: <5954793.q4YDWmuNDB@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1405995074-3271-3-git-send-email-cw00.choi@samsung.com> References: <1405995074-3271-1-git-send-email-cw00.choi@samsung.com> <1405995074-3271-3-git-send-email-cw00.choi@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V02:K0:CqfUWSPawIHe9G2hERHNqpWNZ5Jtq82tT02MsA76YLF S2AUxCAReddNqOaX9pabf7+LpojcUNa48mHLGWzzA/rX88HW0Y mzCXU8rxEhuiYbm9XIxm/JUlgSBnvQpU6js/NdwRNAsMGY2MAw Tckl3mEb8z0VM6T0CYkr/H8cEinjgNjaEafnfGlxg0UFEcqqN+ oL5fUgRQCWc6dfpVXDxmNsr8VdnYc1a0xWAaad1BN2/uJiu8WL Q203St4MfxjjXEn8M1lTW+cpeZXPZxDbimcGwcJW1bEhXqHo09 ROeFFL//WreYvcalZd+vj0EGVc0eNaQjYYC6KyiSXXxU9/G7nm vz7Ioecqa7EWTg7MWpf0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 22 July 2014 11:11:14 Chanwoo Choi wrote: > This patch add support for s3c2410/s3c2416/s3c2440/s3c2443 ADC. The s3c24xx > is alomost same as ADCv1. But, There are a little difference as following: > - ADCMUX register address to select channel > - ADCDAT mask (10bit or 12bit ADC resolution according to SoC version) > > Signed-off-by: Chanwoo Choi > Signed-off-by: Arnd Bergmann > While looking at the driver again to see if the touchscreen patch needs an update for this, I noticed that the s3c24xx variants don't have the ADC_V1_INTCLR and ADC_V1_CLRINTPNDNUP registers, so I assume your patch will have to be updated not to acknowledge the interrupts. It's possible that writing to the missing registers is harmless though and that you don't need that change. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 22 Jul 2014 14:59:25 +0200 Subject: [PATCH 2/2] iio: adc: exynos_adc: Add support for S3C24xx ADC In-Reply-To: <1405995074-3271-3-git-send-email-cw00.choi@samsung.com> References: <1405995074-3271-1-git-send-email-cw00.choi@samsung.com> <1405995074-3271-3-git-send-email-cw00.choi@samsung.com> Message-ID: <5954793.q4YDWmuNDB@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 22 July 2014 11:11:14 Chanwoo Choi wrote: > This patch add support for s3c2410/s3c2416/s3c2440/s3c2443 ADC. The s3c24xx > is alomost same as ADCv1. But, There are a little difference as following: > - ADCMUX register address to select channel > - ADCDAT mask (10bit or 12bit ADC resolution according to SoC version) > > Signed-off-by: Chanwoo Choi > Signed-off-by: Arnd Bergmann > While looking at the driver again to see if the touchscreen patch needs an update for this, I noticed that the s3c24xx variants don't have the ADC_V1_INTCLR and ADC_V1_CLRINTPNDNUP registers, so I assume your patch will have to be updated not to acknowledge the interrupts. It's possible that writing to the missing registers is harmless though and that you don't need that change. Arnd