* [PATCH] powerpc: allow compiling with GENERIC_MSI_IRQ
@ 2017-06-30 9:50 laurentiu.tudor
2017-06-30 10:08 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: laurentiu.tudor @ 2017-06-30 9:50 UTC (permalink / raw)
To: oss, mpe, linuxppc-dev; +Cc: Laurentiu Tudor
From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
This allows building powerpc with the GENERIC_MSI_IRQ Kconfig
by enabling the asm-generic msi.h in Kbuild. Without this,
there's a compilation error [1] because powerpc, as most arches,
doesn't provide an asm/msi.h.
[1] In file included from ./include/linux/kvm_host.h:20:0,
from ./arch/powerpc/include/asm/kvm_ppc.h:30,
from arch/powerpc/kernel/dbell.c:20:
./include/linux/msi.h:195:21: fatal error: asm/msi.h: No such file or directory
Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
arch/powerpc/include/asm/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
index 5c4fbc8..2542ea1 100644
--- a/arch/powerpc/include/asm/Kbuild
+++ b/arch/powerpc/include/asm/Kbuild
@@ -8,3 +8,4 @@ generic-y += mcs_spinlock.h
generic-y += preempt.h
generic-y += rwsem.h
generic-y += vtime.h
+generic-y += msi.h
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: allow compiling with GENERIC_MSI_IRQ
2017-06-30 9:50 [PATCH] powerpc: allow compiling with GENERIC_MSI_IRQ laurentiu.tudor
@ 2017-06-30 10:08 ` Michael Ellerman
2017-06-30 10:25 ` Laurentiu Tudor
0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2017-06-30 10:08 UTC (permalink / raw)
To: laurentiu.tudor, oss, linuxppc-dev; +Cc: Laurentiu Tudor
Hi Laurentiu,
laurentiu.tudor@nxp.com writes:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>
> This allows building powerpc with the GENERIC_MSI_IRQ Kconfig
> by enabling the asm-generic msi.h in Kbuild. Without this,
> there's a compilation error [1] because powerpc, as most arches,
> doesn't provide an asm/msi.h.
>
> [1] In file included from ./include/linux/kvm_host.h:20:0,
> from ./arch/powerpc/include/asm/kvm_ppc.h:30,
> from arch/powerpc/kernel/dbell.c:20:
> ./include/linux/msi.h:195:21: fatal error: asm/msi.h: No such file or directory
I have >50 configs here with GENERIC_MSI_IRQ=y, so I don't understand
what's going wrong for you.
Can you tell me more about what you're doing and how it's breaking.
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: allow compiling with GENERIC_MSI_IRQ
2017-06-30 10:08 ` Michael Ellerman
@ 2017-06-30 10:25 ` Laurentiu Tudor
0 siblings, 0 replies; 3+ messages in thread
From: Laurentiu Tudor @ 2017-06-30 10:25 UTC (permalink / raw)
To: Michael Ellerman, oss, linuxppc-dev
Hi Michael,
On 06/30/2017 01:08 PM, Michael Ellerman wrote:
> Hi Laurentiu,
>
> laurentiu.tudor@nxp.com writes:
>> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>>
>> This allows building powerpc with the GENERIC_MSI_IRQ Kconfig
>> by enabling the asm-generic msi.h in Kbuild. Without this,
>> there's a compilation error [1] because powerpc, as most arches,
>> doesn't provide an asm/msi.h.
>>
>> [1] In file included from ./include/linux/kvm_host.h:20:0,
>> from ./arch/powerpc/include/asm/kvm_ppc.h:30,
>> from arch/powerpc/kernel/dbell.c:20:
>> ./include/linux/msi.h:195:21: fatal error: asm/msi.h: No such file or di=
rectory
>
> I have >50 configs here with GENERIC_MSI_IRQ=3Dy, so I don't understand
> what's going wrong for you.
>
> Can you tell me more about what you're doing and how it's breaking.
>
Actually i made an error in the commit message, sorry about that. It's=20
GENERIC_MSI_IRQ_DOMAIN that breaks the arch/powerpc build. If this is=20
enabled, the generic header include/linux/msi.h wants an asm/msi.h and=20
we don't have one on powerpc. That's what the patch tries to fix.
Want me to resend with the correct commit message? ... if you're ok with=20
the patch, of course.
---
Thanks & Best Regards, Laurentiu=
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-30 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 9:50 [PATCH] powerpc: allow compiling with GENERIC_MSI_IRQ laurentiu.tudor
2017-06-30 10:08 ` Michael Ellerman
2017-06-30 10:25 ` Laurentiu Tudor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.