Hi Am 15.12.22 um 04:01 schrieb Ma Jun: > Add the missing declaration of struct drm_atomic_state to fix the > compile error below: > > error: 'struct drm_atomic_state' declared inside parameter > list will not be visible outside of this definition or declaration [-Werror] > > Signed-off-by: Ma Jun > --- > include/drm/drm_plane_helper.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h > index b00ad36cf5b6..530f88176db4 100644 > --- a/include/drm/drm_plane_helper.h > +++ b/include/drm/drm_plane_helper.h > @@ -30,6 +30,7 @@ struct drm_crtc; > struct drm_framebuffer; > struct drm_modeset_acquire_ctx; > struct drm_plane; > +struct drm_atomic_state; Thanks for the patch. Please sort the forward declarations alphabetically. Best regards Thomas > > int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc, > struct drm_framebuffer *fb, -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev